From users-return-27682-archive-asf-public=cust-asf.ponee.io@subversion.apache.org Wed Dec 12 19:07:54 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id DDF29180676 for ; Wed, 12 Dec 2018 19:07:53 +0100 (CET) Received: (qmail 69607 invoked by uid 500); 12 Dec 2018 18:07:52 -0000 Mailing-List: contact users-help@subversion.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list users@subversion.apache.org Received: (qmail 69585 invoked by uid 99); 12 Dec 2018 18:07:52 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 12 Dec 2018 18:07:52 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id BEAD6180796; Wed, 12 Dec 2018 18:07:51 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.203 X-Spam-Level: X-Spam-Status: No, score=-0.203 tagged_above=-999 required=6.31 tests=[DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id Ui1Z7fFVF4zY; Wed, 12 Dec 2018 18:07:49 +0000 (UTC) Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id BAA4D60DF7; Wed, 12 Dec 2018 18:07:48 +0000 (UTC) Received: by mail-ed1-f48.google.com with SMTP id f9so16322952eds.10; Wed, 12 Dec 2018 10:07:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=hcSt7SX6ACrodaeZnob4s+5P9kH4tegiHXQ8OTZVP3w=; b=iHd9Bv66+V+rvOm+sIzg7n07TLVsFDRIqGSKHXzWtYPCXGrSJRY2FRk+5H+ZtiJVRv GL3ZiVG7GkX2aj4jkL60wo/jxIkLYqxqtr37Iv7WyT8JfkeRZKSHATIGaQ0ONo2Eu/pd yQWNK+G/WIeSxkqODLXc1u8fCoqQq6HdieWPz75L19PRIdIgpnA10LJ7koG4N6GgoYEr 4gUghSo3rhBnA8qfZrUZX98bTqX8ABJ05KIQw7B0iSnShpbjiUCw5FVpZd1aTZhIfHAV isEd3Xo8e3uh0ExpGlaOMxs1suDfySmKDsAa2LBqwDQI5wYEFuyRzwihtF+axLll1H9V BUFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=hcSt7SX6ACrodaeZnob4s+5P9kH4tegiHXQ8OTZVP3w=; b=dcj64RH8seul7OCD+eLjaUqpxGh8M86emOatHtlCAFdDwO+bQGrHG6Wi1+fG0YDR+E kDzRPfxJQW4XriaOsQUKX6yncXy7HW9nB/TOk8IWQrVRVZQSFKf0+sECd78H5oYbpxI7 /QQsW5Of6qMnwogs4puqgVwRP9YWFdGYfFpu6pPhJZOUV4oau1sqjVVH8xJdFYwW6VTH 3ac6k97MEDuEyfQDHMqXrV68h+mC4ikRVEVTNtnhF6m2s9d+jFwBFqJ8J9bYPuuVVKYG ZL5nP5VymZxnGLRFmCX1L1dCCKeSDYlR11bnIMYVlRCla/uQjo4VgdYrn+yUg9FRTH/v 9FLQ== X-Gm-Message-State: AA+aEWa21/zbN7DBuHrDGOilDZqme63r6EqvzY5Gt095uChWoXATKzJA 6ZTQouwVfLngvLAgU8pMZcXEXOvi X-Google-Smtp-Source: AFSGD/VhWZLi5EnGzVP7P64TQoQ7Nt+J+hDBwLwdmuqFG8FGhkkzGuGWNyzb6J5V8r0WpFyoGHosLw== X-Received: by 2002:aa7:dace:: with SMTP id x14mr20449419eds.13.1544638062069; Wed, 12 Dec 2018 10:07:42 -0800 (PST) Received: from [192.168.1.243] (cable-static-20-197.rsnweb.ch. [88.84.20.197]) by smtp.googlemail.com with ESMTPSA id e53sm5124571ede.90.2018.12.12.10.07.40 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Dec 2018 10:07:40 -0800 (PST) Subject: Re: Subversion Exception! To: TortoiseSVN-dev on behalf of Julian Foad , dev@subversion.apache.org, Svn users References: From: Stefan Kueng Message-ID: Date: Wed, 12 Dec 2018 19:07:37 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.3.3 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit On 12.12.2018 13:55, TortoiseSVN-dev on behalf of Julian Foad wrote: >>> Subversion encountered a serious problem. >>> Please take the time to report this on the Subversion mailing list > […] >>> https://subversion.apache.org/mailing-lists.html > >> It is likely that this is a problem specific to TortoiseSVN, and not >> to core SVN. TortoiseSVN has its own mailinglists, so you should >> report your problem there: > (Cross-posting.) Since this happens in the project monitor, my best guess is that the path/url the user entered to be monitored is not correct. > > It makes me sad every time I see this pattern. Software is often frustrating to use, but should at least aim to be polite to its users. Telling the user "Please do X" and then when the user does X saying "No, it's no good doing X; do Y" is not polite, and I would not expect anyone but the most calm, patient and helpful of users to gracefully comply with such a request. > > I'm not meaning to criticise Johan but rather our whole system. > > Can we please fix this problem. Both: > 1) Tsvn please change the message. Sorry, won't do that. Because I've argued multiple times over the years here that calling exit() or even abort() in a library is the worst idea ever. Especially if this can happen by having the user enter a wrong path/url. Just one of the many discussions I had here: https://lists.apache.org/thread.html/924d8493ad71b9c428f4d575540b8688481f2ba1e00b70d58a421303@1433953117@%3Cdev.subversion.apache.org%3E if svn_xxx_canonicalize() don't guarantee that a path/uri is correct and won't throw an exception (or return an error), then how can I in an UI client guarantee that before passing the user input to the library? Since I can't (only the svn lib and specifically the API that consumes the path/uri can know what exactly it expects), I made the dialog that catches the abort() calls show exactly this message. I figured that maybe if you get bored answering all the users bug reports you might reconsider and finally not call abort() but return an error message indicating which path is wrong. It's like I said before: imagine an image lib that simply calls abort() every time it tries to load a corrupted image. Now imagine photoshop or paint.net or ... uses that lib: user has maybe 10 images open, tries to load another one and the lib calls abort(). Now the user lost the other 10 images as well because abort() ends the application with NO possibility to either save changes first. Sorry if this message seems rude - but I'm tired of arguing the same over and over again. Stefan -- ___ oo // \\ "De Chelonian Mobile" (_,\/ \_/ \ TortoiseSVN \ \_/_\_/> The coolest interface to (Sub)version control /_/ \_\ http://tortoisesvn.net