From users-return-27707-archive-asf-public=cust-asf.ponee.io@subversion.apache.org Thu Dec 27 16:19:22 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id D7036180625 for ; Thu, 27 Dec 2018 16:19:21 +0100 (CET) Received: (qmail 72630 invoked by uid 500); 27 Dec 2018 15:19:20 -0000 Mailing-List: contact users-help@subversion.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list users@subversion.apache.org Received: (qmail 72620 invoked by uid 99); 27 Dec 2018 15:19:20 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Dec 2018 15:19:20 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id CAC86180D3D for ; Thu, 27 Dec 2018 15:19:19 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.301 X-Spam-Level: X-Spam-Status: No, score=-0.301 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, KAM_NUMSUBJECT=0.5, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001] autolearn=disabled Authentication-Results: spamd3-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=daniel.shahaf.name header.b=W23WITwg; dkim=pass (2048-bit key) header.d=messagingengine.com header.b=jZgPHEu/ Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id BkDR0sL5AMmP for ; Thu, 27 Dec 2018 15:19:18 +0000 (UTC) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 15AD55F206 for ; Thu, 27 Dec 2018 15:19:18 +0000 (UTC) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id C5C8722001; Thu, 27 Dec 2018 10:19:16 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Thu, 27 Dec 2018 10:19:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= daniel.shahaf.name; h=date:from:to:subject:message-id:references :mime-version:content-type:in-reply-to; s=fm2; bh=Iu6Oc2kELOFurU 5l5ZWBi7wL6D7GwHfsOfQKO06ujac=; b=W23WITwgSC8X3GfqoYBwImL7El9wy7 ZO2BT6SqHd1WZFFqZOIFhKoLEqTmeiDoAFyQ5GmLT5qp4XmeZ1V1Ut9qWYRXd73E jYrqcjiZMTcYmv1iKjSYy4luMCj2XnsIxTk1rVnRzX1jBUplV2ylQd57WyZNaJvb LQBXRCtCagkzPlwbEmJUFk6nl4z5waoJQVsX6LpTWHsAXuuKCPChWFEDu08PQ/ng lfGc47R1g2zlhqerR1lw71SdEf5MRTMg7dCHpOqsRE4GK86rfT85harQdDghWc8A D+UAC0aqBKhjXAKqqxlVQb6qO51A6NBkAz6E3T3k7sq0b7+Me2kpVHwg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=Iu6Oc2 kELOFurU5l5ZWBi7wL6D7GwHfsOfQKO06ujac=; b=jZgPHEu/ygPEU1eoOjo6m/ NtWe9ixGVEf9DjcAE1WLoapR0AnNdhmE0tg7Fijp8a6VM+ecY4eBMXeyw+Ld1eY6 iyaD40eVqSXjk/wL3Cnei7oMQROucEvxhO3XIAaY4dPEvQDOgtnCsfzKYqGNUejj lUXbrZG6O/SzuISDpuFzvWmpIFRlRoONseORstZWQaJz9areB9ge8qs1lMUN2jEE bKImtKLKJvoZC7eK0r9sjo2piLzfwcWoX1H/A69SL2JkbTnwkz7pGm3d3xuWG7VL XmlSxolXkTzhRkVg+S1TmJ4E0X1DYV0eOGJkdEC31ia0ci1AidAwr7EohnXmg9gA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrtdefgddufeculddtuddrgedtkedrtddtmd cutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuffkfhggtggujggfsehttd dttddtredvnecuhfhrohhmpeffrghnihgvlhcuufhhrghhrghfuceougdrshesuggrnhhi vghlrdhshhgrhhgrfhdrnhgrmhgvqeenucfkphepjeelrddujeekrddutdeirdegleenuc frrghrrghmpehmrghilhhfrhhomhepugdrshesuggrnhhivghlrdhshhgrhhgrfhdrnhgr mhgvnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from tarpaulin.shahaf.local2 (bzq-79-178-106-49.red.bezeqint.net [79.178.106.49]) by mail.messagingengine.com (Postfix) with ESMTPA id 06E3210084; Thu, 27 Dec 2018 10:19:16 -0500 (EST) Received: by tarpaulin.shahaf.local2 (Postfix, from userid 1005) id 43QYQp22y2zQX; Thu, 27 Dec 2018 15:19:14 +0000 (UTC) Date: Thu, 27 Dec 2018 15:19:14 +0000 From: Daniel Shahaf To: "Prannoy K.v" , users@subversion.apache.org Subject: Re: Issue with binaries generated(subversion 1.10.2) after compilation on AiX 7.2 Message-ID: <20181227151914.xjrrknnmfqvn24hx@tarpaulin.shahaf.local2> References: <1432956971.9672740.1545917753595.ref@mail.yahoo.com> <1432956971.9672740.1545917753595@mail.yahoo.com> <1545923049.927091.1619248288.0A00868C@webmail.messagingengine.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1545923049.927091.1619248288.0A00868C@webmail.messagingengine.com> User-Agent: NeoMutt/20170113 (1.7.2) Daniel Shahaf wrote on Thu, Dec 27, 2018 at 15:04:09 +0000: > In subversion/libsvn_subr/io.c, in svn_io_file_flush_to_disk(), there's > an APR_STATUS_IS_EINVAL() check. Try making it check > APR_STATUS_IS_EBADF() as well and handle it the same way (assuming "Bad > file number" is strerror(3) of EBADF) For clarity, I meant this: [[[ Index: subversion/libsvn_subr/io.c =================================================================== --- subversion/libsvn_subr/io.c (revision 1849781) +++ subversion/libsvn_subr/io.c (working copy) @@ -2505,6 +2505,10 @@ svn_error_t *svn_io_file_flush_to_disk(apr_file_t ignore the error. */ if (rv == -1 && APR_STATUS_IS_EINVAL(apr_get_os_error())) return SVN_NO_ERROR; +#ifdef _AIX + if (rv == -1 && APR_STATUS_IS_EBADF(apr_get_os_error())) + return SVN_NO_ERROR; +#endif if (rv == -1) return svn_error_wrap_apr(apr_get_os_error(), ]]] > --- read the comment there while > you're at it. For context, creating new revisions relies on being able > to flush the revision files to disk.