From users-return-27569-archive-asf-public=cust-asf.ponee.io@subversion.apache.org Tue Nov 6 01:07:18 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 4B4A8180670 for ; Tue, 6 Nov 2018 01:07:18 +0100 (CET) Received: (qmail 53070 invoked by uid 500); 6 Nov 2018 00:07:17 -0000 Mailing-List: contact users-help@subversion.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list users@subversion.apache.org Received: (qmail 53059 invoked by uid 99); 6 Nov 2018 00:07:16 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Nov 2018 00:07:16 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 1B9AD18587B for ; Tue, 6 Nov 2018 00:07:16 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 0.372 X-Spam-Level: X-Spam-Status: No, score=0.372 tagged_above=-999 required=6.31 tests=[KAM_SHORT=0.001, RDNS_DYNAMIC=0.363, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_HK_NAME_DR=0.01] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id r4xumzpM3Dfv for ; Tue, 6 Nov 2018 00:07:14 +0000 (UTC) Received: from projectstore.net (ec2-18-228-164-192.sa-east-1.compute.amazonaws.com [18.228.164.192]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 6E31E5F542 for ; Tue, 6 Nov 2018 00:07:13 +0000 (UTC) Received: from mail.obsigna.com (unknown [189.29.185.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by projectstore.net (Postfix) with ESMTPSA id 62A651E1604; Mon, 5 Nov 2018 22:07:10 -0200 (-02) Received: from rolf-mini.obsigna.com (rolf-mini.obsigna.com [192.168.222.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.obsigna.com (Postfix) with ESMTPSA id 102A31350FA79; Mon, 5 Nov 2018 22:07:10 -0200 (-02) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\)) Subject: Re: subversion 1.11.0 on FreeBSD 11.2: ... does not support the HTTP/DAV protocol From: "Dr. Rolf Jansen" In-Reply-To: Date: Mon, 5 Nov 2018 22:07:09 -0200 Cc: Nico Kadel-Garcia Content-Transfer-Encoding: quoted-printable Message-Id: <063226D1-ADEC-4024-AC6F-520CCB1E7B3A@obsigna.com> References: <16862E55-81D9-4FA7-B6D0-ABCCDD4D3E1D@obsigna.com> <20181105224336.GO78578@ted.stsp.name> To: users@subversion.apache.org X-Mailer: Apple Mail (2.3445.9.1) > Am 05.11.2018 um 21:55 schrieb Nico Kadel-Garcia : >=20 > On Mon, Nov 5, 2018 at 6:28 PM Dr. Rolf Jansen wrote: >>=20 >>> Am 05.11.2018 um 20:43 schrieb Stefan Sperling : >>>=20 >>> On Mon, Nov 05, 2018 at 08:21:20PM -0200, Dr. Rolf Jansen wrote: >>>> and of course the GitHub server does support HTTP/DAV. >>>=20 >>>> # svn co https://github.com/cyclaero/ContentCGI.git/trunk = ContentCGI >>>> svn: E170013: Unable to connect to a repository at URL = 'https://github.com/cyclaero/ContentCGI.git/trunk' >>>> svn: E175003: The server at = 'https://github.com/cyclaero/ContentCGI.git/trunk' does not support the = HTTP/DAV protocol >>>=20 >>> There is a problem at Github's end with SVN 1.11. >>>=20 >>> See the thread titled "Problems accessing GitHub's SVN-bridge with = SVN 1.11" >>> on this very mailing list: = https://svn.haxx.se/users/archive-2018-11/0008.shtml >>=20 >> In the meantime, I saw this thread. >>=20 >>> There is a problem at Github=E2=80=99s end with SVN 1.11. >>=20 >>=20 >> Reading the whole thread, my impression is that there is another = issue with the Robustness Principle of software design on Subversion=E2=80= =99s end. See: https://en.wikipedia.org/wiki/Robustness_principle. >>=20 >> I won=E2=80=99t hold on my breath, until the Subversion Developers = and the GitHub engineers sorted out their animosities. I put the patch = shown below to = /usr/ports/devel/subversion/files/patch-zz-DAV-robustness.local on my = FreeBSD system, and then I reinstalled the port - problem solved. Happy = discussions! >>=20 >> Best regards >>=20 >> Rolf >=20 > May I suggest never simply expanding a comment to take out a chunk of > live code ,such as you've done in your patch? If you have to take out > a chunk of live code, add a *separate* coment about why you're doing > it, and add a distinct set of comment marks around it. This will make > merges *much* cleaner for the future. >=20 >> --- subversion/libsvn_ra_serf/options.c.orig 2018-02-25 = 10:22:55.000000000 -0300 >> +++ subversion/libsvn_ra_serf/options.c 2018-11-05 20:50:29.431635000 = -0200 >> @@ -403,7 +403,7 @@ options_response_handler(serf_request_t >>=20 >> /* Bail out early if we're not talking to a DAV server. >> Note that this check is only valid if we've received a = success >> - response; redirects and errors don't count. */ >> + response; redirects and errors don't count. >> if (opt_ctx->handler->sline.code >=3D 200 >> && opt_ctx->handler->sline.code < 300 >> && !opt_ctx->received_dav_header) >> @@ -413,7 +413,7 @@ options_response_handler(serf_request_t >> _("The server at '%s' does not support the HTTP/DAV = protocol"), >> session->session_url_str); >> } >> - >> + */ >> /* Assume mergeinfo capability unsupported, if didn't receive = information >> about server or repository mergeinfo capability. */ >> if (!svn_hash_gets(session->capabilities, = SVN_RA_CAPABILITY_MERGEINFO)) In general, you=E2=80=99re right, in the special case, the patch is = meant to be used as a hot fix on FreeBSD production systems, and it is = in no way meant to make it into the upstream code base. Best regards Rolf