From users-return-27018-archive-asf-public=cust-asf.ponee.io@subversion.apache.org Wed Apr 4 20:25:15 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id C58F018064F for ; Wed, 4 Apr 2018 20:25:14 +0200 (CEST) Received: (qmail 16084 invoked by uid 500); 4 Apr 2018 18:25:08 -0000 Mailing-List: contact users-help@subversion.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list users@subversion.apache.org Received: (qmail 16072 invoked by uid 99); 4 Apr 2018 18:25:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Apr 2018 18:25:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id BCB96C00E0 for ; Wed, 4 Apr 2018 18:25:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.801 X-Spam-Level: X-Spam-Status: No, score=-0.801 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=daniel.shahaf.name header.b=kk51FzqY; dkim=pass (2048-bit key) header.d=messagingengine.com header.b=lY4lRuC9 Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id Nx3IgQ7ywx7e for ; Wed, 4 Apr 2018 18:25:06 +0000 (UTC) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 740B65F124 for ; Wed, 4 Apr 2018 18:25:05 +0000 (UTC) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id A92B420CB1; Wed, 4 Apr 2018 14:25:04 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Wed, 04 Apr 2018 14:25:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= daniel.shahaf.name; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=hV6Mlb NivdAclszncTJn2RNvGWwBtt3bCgLwd2LNgeo=; b=kk51FzqYfYPrTlgFui+/Px KEeD/tXl5T4pSpJpjRSsJI+JNbAu/a5fKMG3arnYoYgV05G6xzgXAXatsiZrABhM bIsy1W4tMXK+/lNIe5kBdgxOcfQzX9DPJgyC4p8C3paPd75Xpj984P3q52r5QXFX Q7SEUb6uM+BBelg8cvH9lOxGxrmAzOrXmYF+d+2JUVcsPGpPBwfgTAB1kgl3n+6c Y58xmm2HWvqzPfrY/dhZ/YFQEKSiY0BdYgoVUD9+lLWMJQVxttEi7WVD7DjlfpTt 3jn1bwNH1IGffALudbqG0+JwtXwTfriaVdKMGcheXC8xeOFJQxha/aO7Ke/o3Tmg == DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=hV6Mlb NivdAclszncTJn2RNvGWwBtt3bCgLwd2LNgeo=; b=lY4lRuC94uNybA/+h4Jxj9 Sm0tmBRWiut/9ffvFJyYQzV2tgjWDHnKQ0z5/6Jxyplnc2qoJq/aqoPzCHBcaPks R+Eil/purdHHioZwwuTCDtIxt84RAFLSzuNaJ0npz81uq5tSrCv4WvXM3wcgGmkt OR42ZKhcOyQS58nslCiEzGbYZKEUjDbPQMnVzgA2i/z0PCWKo0KUH5qCDogIo4/W bonXh/Gi6b/rRGRm+9j/Ln/4TJjVsysHOXjbHhhpOosKnOYhaIkEmqqOgoEHb7ZO YpD+5qaWiBS1F4tDAPYrfvReDjlJukX05oeKHhuQFsl39oTX8FnF29fHQ6JLedhQ == X-ME-Sender: Received: from tarpaulin.shahaf.local2 (bzq-79-178-51-227.red.bezeqint.net [79.178.51.227]) by mail.messagingengine.com (Postfix) with ESMTPA id 093111025E; Wed, 4 Apr 2018 14:25:04 -0400 (EDT) Received: by tarpaulin.shahaf.local2 (Postfix, from userid 1005) id 40GZBQ3qrxzTx; Wed, 4 Apr 2018 18:25:02 +0000 (UTC) Date: Wed, 4 Apr 2018 18:25:02 +0000 From: Daniel Shahaf To: wuzhouhui <1530108435@qq.com> Cc: Subversion Subject: Re: width of output of 'svn shelves' is too large Message-ID: <20180404182502.c7bzte3oes2gytam@tarpaulin.shahaf.local2> References: <8C9079C3-396F-4DB8-A7E6-2919522BD59B@qq.com> <20180330172846.2rkh7exwl322qtzy@tarpaulin.shahaf.local2> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) wuzhouhui wrote on Sat, Mar 31, 2018 at 18:17:17 +0800: > > > On 31 Mar 2018, at 1:28 AM, Daniel Shahaf wrote: > > > > wuzhouhui wrote on Mon, Mar 19, 2018 at 19:26:08 +0800: > >> The width of terminal is 80 column, but the width of output of 'svn shelves' is 82 > >> at least, I think 80 is better. > > > > Thanks for testing the pre-releases. > > > >> What do you think? > > > > Agreed in principle, but cannot reproduce the original problem. With current > > trunk, the output for me is 70 columns. By code inspection, that should be the > > case so long as the shelf name is ≤29 characters (plus or minus the length of > > the right-hand side description, which can vary by ±5 columns). > > > > What version are you testing with? > > Version: subversion-1.10.0-rc1.tar.bz2 > OS: ubuntu 16.04 > Configure args: ./configure --with-lz4=internal > Okay. 1.10.0-rc2 should be released soon (it's being prepared), but I haven't the time to test it. Which reminds me, sorry that we took so long to reply to your original email. It must have slipped through the cracks. > In addition, I found another issue: > 1. Create a empty file (named 'a') and version it, then commit. > 2. Add some contents to file 'a' > 3. svn shelve a a > Now, the file 'a' will be deleted, that isn't what I want. I assume this is a use-case we'd like to support, but I'll let the devs who work on shelving comment on this. (I've pinged them) The cause will be that the backend of 'shelve' is patch files, which make no distinction between an empty file and a non-existent file. (So to support this use-case we'll have either to swap backends or to make 'svn patch' smarter; I believe Julian has considered both options) Thanks again for your patience. Daniel