From users-return-26956-archive-asf-public=cust-asf.ponee.io@subversion.apache.org Fri Mar 16 12:28:27 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 3FD2318067B for ; Fri, 16 Mar 2018 12:28:27 +0100 (CET) Received: (qmail 45376 invoked by uid 500); 16 Mar 2018 11:28:25 -0000 Mailing-List: contact users-help@subversion.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list users@subversion.apache.org Received: (qmail 45357 invoked by uid 99); 16 Mar 2018 11:28:25 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 16 Mar 2018 11:28:25 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 8E7A71A0010; Fri, 16 Mar 2018 11:28:24 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.802 X-Spam-Level: X-Spam-Status: No, score=-0.802 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001] autolearn=disabled Authentication-Results: spamd2-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=daniel.shahaf.name header.b=XsqCTROv; dkim=pass (2048-bit key) header.d=messagingengine.com header.b=UwkF+Ibf Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 6-RGFOgblhsm; Fri, 16 Mar 2018 11:28:23 +0000 (UTC) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 910FC5F202; Fri, 16 Mar 2018 11:28:23 +0000 (UTC) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id C341B211D8; Fri, 16 Mar 2018 07:28:17 -0400 (EDT) Received: from web6 ([10.202.2.216]) by compute3.internal (MEProxy); Fri, 16 Mar 2018 07:28:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= daniel.shahaf.name; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=Wb+JlK JeLhrCGnkyu4e2d7RY5B1f3bCq/UG3p+nclu0=; b=XsqCTROv1+4iVegb0hoMB/ pCzKG0AlNvBHdjRfKiG+x1i2g0ZvkjV5ravYAC4mnnsNj6Z3wjtHYP0Nk4R26Kyh ySJKvp8qGbPbo5UeF05M7M3Sob9f5bDHcDUwy26++6ivX3p9NYKTIwhBhm1OJSNa rrbVZzffWUK8K8ditfLCmy1U0Np+/yc++0tLa9xHFUt3ZRNUcEFDLtsHB2OjOZfQ 11pi6T1vXPwrx4wMtdf+5olujcuOvM7EGJzPofYHtx44afRXE+6LKGN1hI/Bq+Bf 8BEptSDg0a2A/eA7ZcuZ8jxpeV0Xu1CsQBKRpn8gs1q6wWLM++kfDbEorhMNOSbw == DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=Wb+JlK JeLhrCGnkyu4e2d7RY5B1f3bCq/UG3p+nclu0=; b=UwkF+Ibf1NVkoxRoWxMSR1 Zxcx8yeBMTEVvH0k9uZ4yYKDFzI48xT7uRBdK1icSlWbfnqhNnh+f9MWz4xiKeyx 9EJDBuhqf/uwzltteQjNnCl4wczKr0dlMCpLYGai4aVEA+x2BvslOIWlCgUDFUuA VsOcEaS0zajhXRoy1SlhZO3h29gaNZtR3jNiWNPPFxaf1dwOLJmxUI9WOQwYrwq3 EztGAees+hEwYLWepmoAUEIANgVfpObE1h+jKAl6dO2h+BujsANwXdqw3WOczDlI Rb44JIf00Nxp/3T4iKyXo0ZQmYOjJHx+ww3eG63RahgdDdVhY5I/VRCiVlh4j7Cg == X-ME-Sender: Received: by mailuser.nyi.internal (Postfix, from userid 99) id 8E4FB4100; Fri, 16 Mar 2018 07:28:17 -0400 (EDT) Message-Id: <1521199697.2394095.1305332264.405F70EE@webmail.messagingengine.com> From: Daniel Shahaf To: "NOCERA, ANDY" , Johan Corveleyn Cc: users@subversion.apache.org, dev@subversion.apache.org MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" X-Mailer: MessagingEngine.com Webmail Interface - ajax-b3834dbb References: <99BCC400E8B6334C91FACA6B284C927D41C2A706@MISOUT7MSGUSRCC.ITServices.sbc.com> Subject: fsfs 'structure' terminology: length/size v. size/expanded-size (was: Re: E130003: The XML response contains invalid XML - Follow-up) In-Reply-To: <99BCC400E8B6334C91FACA6B284C927D41C2A706@MISOUT7MSGUSRCC.ITServices.sbc.com> Date: Fri, 16 Mar 2018 11:28:17 +0000 [ cc += dev@ ] NOCERA, ANDY wrote on Thu, 15 Mar 2018 22:35 +0000: > Folks, > > I used dump and load to debug the malformed node revision ID. Here are > my steps and what learned. Looks like the revs' file text: entry has > a zero instead of size. To be clear, you mean the fourth field. On line 562 'size' is the name of the fourth field but on line 119, and in the representation_t struct, 'size' is the name of the third field.[1] This is a recipe for confusion. Normally I think of the fields using the size/expanded-size terminology so I propose to change 'structure' to use that terminology in lieu of length/size (and leave a note behind pointing out that old versions of the document used differently). WDYT? Daniel [1] All line numbers refer to subversion/libsvn_fs_fs/structure. > diff db/revs/0/1 /usr/tmp/xrepox/db/revs/0/1 > 18c18 > < text: 1 76 48 0 ec69809945c46f2bb74e99a3ff7cd917 > --- > > text: 1 76 48 48 ec69809945c46f2bb74e99a3ff7cd917 > 22c22