subversion-users mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Sperling <s...@elego.de>
Subject Re: SHA-1 collision in repository?
Date Sun, 04 Mar 2018 10:28:05 GMT
On Sat, Mar 03, 2018 at 09:08:41PM -0500, Nathan Hartman wrote:
> On Mar 2, 2018, at 6:16 PM, Philip Martin <philip@codematters.co.uk> wrote:
> > 
> > Since the file being committed matched a SHA1 in the rep-cache the
> > commit process will attempt to remove this delta but will first verify
> > that the fulltext obtained by expanding the delta in the protorev file
> > matches the fulltext in the repository, see get_shared_rep() in
> > subversion/libsvn_fs_fs/transaction.c.
> > 
> 
> Does this mean that content being committed to the repository is never elided
> based on the SHA hash alone but only after a fulltext verification that the
> content actually already exists in the repository?

Yes. And if the content differs, it must be rejected, because an FSFS
repository can only store one content per SHA1 checksum.

Mime
View raw message