Mailing-List: contact users-help@subversion.apache.org; run by ezmlm
Precedence: bulk
From: "Bert Huijben" <bert@qqmail.nl>
To: "'Stefan Sperling'" <stsp@elego.de>,
	"'yuan lixin'" <woodsp@126.com>
Cc: <users@subversion.apache.org>
References: <2a1d970.9388.157e6b6da6b.Coremail.woodsp@126.com> <20161021105209.k6jxzx5vpbgkxbjw@jim.stsp.name> <1be81926.ab2e.157e70b937d.Coremail.woodsp@126.com> <20161021121340.fplt3r3skefaaium@jim.stsp.name>
In-Reply-To: <20161021121340.fplt3r3skefaaium@jim.stsp.name>
Subject: RE: Re: subversion issue: ignore server invaild certificate in linux
Date: Fri, 21 Oct 2016 22:25:51 +0200
Message-ID: <043601d22bd9$524559e0$f6d00da0$@qqmail.nl>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 7bit
Thread-Index: AQHzJYhYYVwrv4QQL0OVZp+T9HHmzgETb6L2AXsnNEIBG92+XqBUEv8w
Content-Language: nl
archived-at: Fri, 21 Oct 2016 20:26:04 -0000


> -----Original Message-----
> From: Stefan Sperling [mailto:stsp@elego.de]
> Sent: vrijdag 21 oktober 2016 14:14
> To: yuan lixin <woodsp@126.com>
> Cc: users@subversion.apache.org
> Subject: Re: Re: subversion issue: ignore server invaild certificate in
linux
> 
> On Fri, Oct 21, 2016 at 07:41:18PM +0800, yuan lixin wrote:
> > but in the interface "svn_auth_ssl_server_trust_prompt_func_t",
> > the actual parameter is "failures", not "*failures".  so it can not
change
> > the svn's failures in linux, then can not ignore certificate.
> > could you look at my code for a solution.
> >
> > Thank you
> > --woodsp
> 
> libsvn_subr gets 'failures' from the 'parameters' hash:

Code shouldn't touch the failures value; they should change the
accepted_failures in the credentials value. 

/** @c SVN_AUTH_CRED_SSL_SERVER_TRUST credentials. */
typedef struct svn_auth_cred_ssl_server_trust_t
{
  /** Indicates if the credentials may be saved (to disk). For example, a
   * GUI prompt implementation with a checkbox to accept the certificate
   * permanently shall set @a may_save to TRUE if the checkbox is checked.
   */
  svn_boolean_t may_save;
  /** Bit mask of the accepted failures */
  apr_uint32_t accepted_failures;
} svn_auth_cred_ssl_server_trust_t;


If svn uses a different way to change a value in the caller that is a bug
that should be fixed there.

	Bert