Mailing-List: contact users-help@subversion.apache.org; run by ezmlm
Precedence: bulk
MIME-Version: 1.0
In-Reply-To: <76a58dde-35e6-998c-6bc4-3d3da486d262@elego.de>
References: <76a58dde-35e6-998c-6bc4-3d3da486d262@elego.de>
From: Mark Phippard <markphip@gmail.com>
Date: Fri, 8 Jul 2016 10:38:16 -0400
Message-ID: <CAHFaGCqtKgjyQczt6xZr_7Gg_x+aNjvF-fYWjFuaRKJXgSqHyw@mail.gmail.com>
Subject: Re: JavaHL: JNIError: bad C++ this
To: Walter Klust <walter.klust@elego.de>
Cc: "users@subversion.apache.org" <users@subversion.apache.org>
Content-Type: multipart/alternative; boundary=001a1141f4a8e1f73b053720c0eb
archived-at: Fri, 08 Jul 2016 14:38:26 -0000

--001a1141f4a8e1f73b053720c0eb
Content-Type: text/plain; charset=UTF-8

On Fri, Jul 8, 2016 at 4:58 AM, Walter Klust <walter.klust@elego.de> wrote:

> Hello,
>
> I have an interesting problem concerning JavaHL:
>
> - Windows 7, JRE 8u66, Eclipse 4.2.1, Subclipse 1.8.22, JavaHL 1.8.10
> - a changeset of around 2000 files; roughly 50% modified and 50% deleted
> (probably to a large refactoring)
> - on trying to commit the changes eclipse pops up a message after a short
> time: "Internal error occured during SVNCommit",  "bad C++ this"
>

I do not know if you are using changeset generically or referencing the
Eclipse changeset feature.  But just to clarify for SVN devs, this is not
the SVN changelist feature.  In terms of SVN commit, it would just be a
specific list of files to commit like any other commit.  Eclipse changesets
are just a UI feature to organize the modified files.


> - in the eclipse logs a stacktrace was found:
>
> org.apache.subversion.javahl.JNIError: bad C++ this
>          at org.apache.subversion.javahl.SVNClient.dispose(Native Method)
>          at
>
>  org.tigris.subversion.svnclientadapter.javahl.AbstractJhlClientAdapter.dispose(AbstractJhlClientAdapter.java:3007)
>          at
>
>  org.tigris.subversion.subclipse.core.SVNClientManager.returnSVNClient(SVNClientManager.java:162)
>          at
>
>  org.tigris.subversion.subclipse.ui.operations.CommitOperation.execute(CommitOperation.java:113)
>          at
>
>  org.tigris.subversion.subclipse.ui.operations.SVNOperation.run(SVNOperation.java:90)
>          at
>
>  org.eclipse.team.internal.ui.actions.JobRunnableContext.run(JobRunnableContext.java:144)
>          at
>
>  org.eclipse.team.internal.ui.actions.JobRunnableContext$ResourceJob.runInWorkspace(JobRunnableContext.java:72)
>          at
>
>  org.eclipse.core.internal.resources.InternalWorkspaceJob.run(InternalWorkspaceJob.java:38)
>          at org.eclipse.core.internal.jobs.Worker.run(Worker.java:53)
>
>
> - this error does not occur when trying to commit a subset of the changes,
> e.g. any 2 of 4 subdirectories can be comitted successfully but not all 4
> together.
>
> It looks to me like a quantity problem; something like an internal buffer
> overflow due to the large changeset. I tried to reproduce this with a
> similar number of modified/deleted files but had no success so far.
>
> Any ideas how to analyze this problem further ?
>
>
It sort of seems like it could be a Subclipse bug, though it is interesting
that it only manifests in specific scenarios.  Makes me not really sure
where to look.

Does the commit work or record any errors?  This exception is only
happening in some cleanup that occurs after the API calls would all be
completed or possibly after having processed an exception.  IOW, this is
not failing during an API call, it is failing when Subclipse is just
disposing of the JavaHL client it obtained to make the API calls.
Something that is done for every API call.

The stack trace does not make a lot of sense either.  This should be the
relevant place in the code:

 org.tigris.subversion.subclipse.ui.operations.CommitOperation.execute(CommitOperation.java:113)

But that does not line up with anything that makes a lot of sense for the
error.


-- 
Thanks

Mark Phippard
http://markphip.blogspot.com/

--001a1141f4a8e1f73b053720c0eb
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">On Fri, Jul 8, 2016 at 4:58 AM, Walter Klust <span dir=3D"=
ltr">&lt;<a href=3D"mailto:walter.klust@elego.de" target=3D"_blank">walter.=
klust@elego.de</a>&gt;</span> wrote:<br><div class=3D"gmail_extra"><div cla=
ss=3D"gmail_quote"><blockquote class=3D"gmail_quote" style=3D"margin:0px 0p=
x 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border=
-left-style:solid;padding-left:1ex">Hello,<br>
<br>
I have an interesting problem concerning JavaHL:<br>
<br>
- Windows 7, JRE 8u66, Eclipse 4.2.1, Subclipse 1.8.22, JavaHL 1.8.10<br>
- a changeset of around 2000 files; roughly 50% modified and 50% deleted (p=
robably to a large refactoring)<br>
- on trying to commit the changes eclipse pops up a message after a short t=
ime: &quot;Internal error occured during SVNCommit&quot;,=C2=A0 &quot;bad C=
++ this&quot;<br></blockquote><div><br></div><div>I do not know if you are =
using changeset generically or referencing the Eclipse changeset feature.=
=C2=A0 But just to clarify for SVN devs, this is not the SVN changelist fea=
ture.=C2=A0 In terms of SVN commit, it would just be a specific list of fil=
es to commit like any other commit.=C2=A0 Eclipse changesets are just a UI =
feature to organize the modified files.</div><div><br></div><div>=C2=A0</di=
v><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;borde=
r-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid=
;padding-left:1ex">
- in the eclipse logs a stacktrace was found:<br>
<br>
org.apache.subversion.javahl.JNIError: bad C++ this<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0at org.apache.subversion.javahl.SVNClient=
.dispose(Native Method)<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0at<br>
=C2=A0org.tigris.subversion.svnclientadapter.javahl.AbstractJhlClientAdapte=
r.dispose(AbstractJhlClientAdapter.java:3007)<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0at<br>
=C2=A0org.tigris.subversion.subclipse.core.SVNClientManager.returnSVNClient=
(SVNClientManager.java:162)<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0at<br>
=C2=A0org.tigris.subversion.subclipse.ui.operations.CommitOperation.execute=
(CommitOperation.java:113)<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0at<br>
=C2=A0org.tigris.subversion.subclipse.ui.operations.SVNOperation.run(SVNOpe=
ration.java:90)<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0at<br>
=C2=A0org.eclipse.team.internal.ui.actions.JobRunnableContext.run(JobRunnab=
leContext.java:144)<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0at<br>
=C2=A0org.eclipse.team.internal.ui.actions.JobRunnableContext$ResourceJob.r=
unInWorkspace(JobRunnableContext.java:72)<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0at<br>
=C2=A0org.eclipse.core.internal.resources.InternalWorkspaceJob.run(Internal=
WorkspaceJob.java:38)<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0at org.eclipse.core.internal.jobs.Worker.=
run(Worker.java:53)<br>
<br>
<br>
- this error does not occur when trying to commit a subset of the changes, =
e.g. any 2 of 4 subdirectories can be comitted successfully but not all 4 t=
ogether.<br>
<br>
It looks to me like a quantity problem; something like an internal buffer o=
verflow due to the large changeset. I tried to reproduce this with a simila=
r number of modified/deleted files but had no success so far.<br>
<br>
Any ideas how to analyze this problem further ?<br><br></blockquote><div><b=
r></div><div>It sort of seems like it could be a Subclipse bug, though it i=
s interesting that it only manifests in specific scenarios.=C2=A0 Makes me =
not really sure where to look.</div><div><br></div><div>Does the commit wor=
k or record any errors?=C2=A0 This exception is only happening in some clea=
nup that occurs after the API calls would all be completed or possibly afte=
r having processed an exception.=C2=A0 IOW, this is not failing during an A=
PI call, it is failing when Subclipse is just disposing of the JavaHL clien=
t it obtained to make the API calls.=C2=A0 Something that is done for every=
 API call.</div><div><br></div><div>The stack trace does not make a lot of =
sense either.=C2=A0 This should be the relevant place in the code:</div><di=
v><br></div><div>=C2=A0org.tigris.subversion.subclipse.ui.operations.Commit=
Operation.execute(CommitOperation.java:113)<br></div><div><br></div><div>Bu=
t that does not line up with anything that makes a lot of sense for the err=
or.</div><div>=C2=A0</div></div><div><br></div>-- <br><div class=3D"gmail_s=
ignature" data-smartmail=3D"gmail_signature">Thanks<br><br>Mark Phippard<br=
><a href=3D"http://markphip.blogspot.com/" target=3D"_blank">http://markphi=
p.blogspot.com/</a></div>
</div></div>

--001a1141f4a8e1f73b053720c0eb--