Return-Path: 
 <users-return-24602-apmail-subversion-users-archive=subversion.apache.org@subversion.apache.org>
X-Original-To: apmail-subversion-users-archive@minotaur.apache.org
Delivered-To: apmail-subversion-users-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id DE6A41902B
	for <apmail-subversion-users-archive@minotaur.apache.org>;
 Sun, 24 Apr 2016 00:43:46 +0000 (UTC)
Received: (qmail 33350 invoked by uid 500); 24 Apr 2016 00:43:45 -0000
Delivered-To: apmail-subversion-users-archive@subversion.apache.org
Received: (qmail 33308 invoked by uid 500); 24 Apr 2016 00:43:45 -0000
Mailing-List: contact users-help@subversion.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:users-help@subversion.apache.org>
List-Unsubscribe: <mailto:users-unsubscribe@subversion.apache.org>
List-Post: <mailto:users@subversion.apache.org>
List-Id: <users.subversion.apache.org>
Delivered-To: mailing list users@subversion.apache.org
Received: (qmail 33298 invoked by uid 99); 24 Apr 2016 00:43:45 -0000
Received: from mail-relay.apache.org (HELO mail-relay.apache.org)
 (140.211.11.15)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 24 Apr 2016 00:43:45 +0000
Received: from mail-oi0-f41.google.com (mail-oi0-f41.google.com
 [209.85.218.41])
	by mail-relay.apache.org (ASF Mail Server at mail-relay.apache.org) with
 ESMTPSA id 2B9D91A009D
	for <users@subversion.apache.org>; Sun, 24 Apr 2016 00:43:45 +0000 (UTC)
Received: by mail-oi0-f41.google.com with SMTP id k142so148220009oib.1
        for <users@subversion.apache.org>;
 Sat, 23 Apr 2016 17:43:45 -0700 (PDT)
X-Gm-Message-State: 
 AOPr4FWqsScCN9AhJNGrPabE/2wzzi8dKMT55BdEBAJp/O5E2Pfh5DXQSegnTkFinrjgz43fAbWkpqi3Mos0YQ==
MIME-Version: 1.0
X-Received: by 10.202.51.87 with SMTP id z84mr11024456oiz.5.1461458624452;
 Sat, 23 Apr 2016 17:43:44 -0700 (PDT)
Received: by 10.202.189.9 with HTTP; Sat, 23 Apr 2016 17:43:44 -0700 (PDT)
In-Reply-To: <20160423221918.GC5310@tarsus.local2>
References: 
 <CA+BGpn9ptBEjzN3Wru=GaZNnhQ-w14HT0GT-dTMY907SnaLNpQ@mail.gmail.com>
	<20160423214838.GA5310@tarsus.local2>
	<20160423221918.GC5310@tarsus.local2>
Date: Sat, 23 Apr 2016 17:43:44 -0700
X-Gmail-Original-Message-ID: 
 <CA+BGpn-pBOV+cy4yHw99VLb5cJJSKaOKahanLcBBYuqDViHr=g@mail.gmail.com>
Message-ID: 
 <CA+BGpn-pBOV+cy4yHw99VLb5cJJSKaOKahanLcBBYuqDViHr=g@mail.gmail.com>
Subject: Re: Modifying transaction properties (svnadmin setrevprop)
From: Ryan J Ollos <rjollos@apache.org>
To: Daniel Shahaf <danielsh@apache.org>
Cc: users@subversion.apache.org
Content-Type: multipart/alternative; boundary=001a113cf4f02a24820531305acd

--001a113cf4f02a24820531305acd
Content-Type: text/plain; charset=UTF-8

On Sat, Apr 23, 2016 at 3:19 PM, Daniel Shahaf <danielsh@apache.org> wrote:

> Daniel Shahaf wrote on Sat, Apr 23, 2016 at 21:48:38 +0000:
> > Ryan J Ollos wrote on Sat, Apr 23, 2016 at 14:23:37 -0700:
> > > For a long time I've known the rule "don't modify a transaction in a
> > > pre-commit hook", documented in (1) and recently repeated in (2).
> > >
> > > I was therefore surprised to read about the "svnadmin setrevprop"
> command
> > > (3) in 1.9, and to see an example of modifying transaction properties
> in
> > > the hook-scripts: "persist-ephemeral-txnprops.py" (4).
> > >
> > > Are there some conditions under which it's okay to modify the
> transaction,
> > > or are there only specific use-cases when this should be done?
>
> I think I can give a simpler answer: anything you can do using only
> svnadmin/svnlook is okay.  The rule you quote refers to people who
> directly use the svn_fs_* APIs, or DAV clients.
>
> Cheers,
>
> Daniel
>

Thanks, that makes sense. In the past, I have applied the rule in an
overly-restrictive way when considering pre-/post-commit hook use cases.

- Ryan

--001a113cf4f02a24820531305acd
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><br><div class=3D"gmail_extra"><br><div class=3D"gmail_quo=
te">On Sat, Apr 23, 2016 at 3:19 PM, Daniel Shahaf <span dir=3D"ltr">&lt;<a=
 href=3D"mailto:danielsh@apache.org" target=3D"_blank">danielsh@apache.org<=
/a>&gt;</span> wrote:<br><blockquote class=3D"gmail_quote" style=3D"margin:=
0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class=3D"">Da=
niel Shahaf wrote on Sat, Apr 23, 2016 at 21:48:38 +0000:<br>
&gt; Ryan J Ollos wrote on Sat, Apr 23, 2016 at 14:23:37 -0700:<br>
&gt; &gt; For a long time I&#39;ve known the rule &quot;don&#39;t modify a =
transaction in a<br>
&gt; &gt; pre-commit hook&quot;, documented in (1) and recently repeated in=
 (2).<br>
&gt; &gt;<br>
&gt; &gt; I was therefore surprised to read about the &quot;svnadmin setrev=
prop&quot; command<br>
&gt; &gt; (3) in 1.9, and to see an example of modifying transaction proper=
ties in<br>
&gt; &gt; the hook-scripts: &quot;persist-ephemeral-txnprops.py&quot; (4).<=
br>
&gt; &gt;<br>
&gt; &gt; Are there some conditions under which it&#39;s okay to modify the=
 transaction,<br>
&gt; &gt; or are there only specific use-cases when this should be done?<br=
>
<br>
</span>I think I can give a simpler answer: anything you can do using only<=
br>
svnadmin/svnlook is okay.=C2=A0 The rule you quote refers to people who<br>
directly use the svn_fs_* APIs, or DAV clients.<br>
<br>
Cheers,<br>
<br>
Daniel<br></blockquote><div><br></div><div>Thanks, that makes sense. In the=
 past, I have applied the rule in an overly-restrictive way when considerin=
g pre-/post-commit hook use cases.</div><div><br></div><div>- Ryan</div></d=
iv><br></div></div>

--001a113cf4f02a24820531305acd--