subversion-users mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ryan J Ollos <rjol...@apache.org>
Subject Re: Modifying transaction properties (svnadmin setrevprop)
Date Sun, 24 Apr 2016 00:43:44 GMT
On Sat, Apr 23, 2016 at 3:19 PM, Daniel Shahaf <danielsh@apache.org> wrote:

> Daniel Shahaf wrote on Sat, Apr 23, 2016 at 21:48:38 +0000:
> > Ryan J Ollos wrote on Sat, Apr 23, 2016 at 14:23:37 -0700:
> > > For a long time I've known the rule "don't modify a transaction in a
> > > pre-commit hook", documented in (1) and recently repeated in (2).
> > >
> > > I was therefore surprised to read about the "svnadmin setrevprop"
> command
> > > (3) in 1.9, and to see an example of modifying transaction properties
> in
> > > the hook-scripts: "persist-ephemeral-txnprops.py" (4).
> > >
> > > Are there some conditions under which it's okay to modify the
> transaction,
> > > or are there only specific use-cases when this should be done?
>
> I think I can give a simpler answer: anything you can do using only
> svnadmin/svnlook is okay.  The rule you quote refers to people who
> directly use the svn_fs_* APIs, or DAV clients.
>
> Cheers,
>
> Daniel
>

Thanks, that makes sense. In the past, I have applied the rule in an
overly-restrictive way when considering pre-/post-commit hook use cases.

- Ryan

Mime
View raw message