Mailing-List: contact users-help@subversion.apache.org; run by ezmlm
Precedence: bulk
From: "Ren Wang" <renwang101@gmail.com>
To: "'Daniel Shahaf'" <d.s@daniel.shahaf.name>,
	<dev@subversion.apache.org>
Cc: <users@subversion.apache.org>
References: <000a01d12857$3f6192c0$be24b840$@gmail.com>
 <56571B5A.5010806@apache.org> <000401d1285a$d710dfb0$85329f10$@gmail.com>
 <000501d1285b$5c9bbba0$15d332e0$@gmail.com> <56572F91.9060501@apache.org>
 <000c01d12923$a694aa50$f3bdfef0$@gmail.com>
 <001101d12924$f0251aa0$d06f4fe0$@gmail.com>
 <20151128172652.GJ2498@tarsus.local2> <20151128174123.GK2498@tarsus.local2>
In-Reply-To: <20151128174123.GK2498@tarsus.local2>
Subject: RE: FW: getting file or directory property/metadata
Date: Sun, 29 Nov 2015 02:58:35 -0500
Message-ID: <001201d12a7b$c0375210$40a5f630$@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 7bit
Content-language: en-us
Thread-Index: 
 AQHg8xcUkhtTcdM9M9yLv9RX2zAmwwG7GeGYAx/W8KUBxcSxegLtmENcAS2XsfgCFZNW1QH+zt5wAfyho5eeDKlz4A==

Thank you for the response. I just did a test, svn_fs_node_created_rev()
works great!

-----Original Message-----
From: Daniel Shahaf [mailto:d.s@daniel.shahaf.name] 
Sent: Saturday, November 28, 2015 12:41 PM
To: Ren Wang <renwang101@gmail.com>; dev@subversion.apache.org
Cc: users@subversion.apache.org
Subject: Re: FW: getting file or directory property/metadata

[moving to dev@; please drop users@ from replies]

Daniel Shahaf wrote on Sat, Nov 28, 2015 at 17:26:52 +0000:
> To be fair, though, the same trick with 'svn info' would have lead you 
> to svn_fs_node_created_rev(), which is documented to return "the 
> revision in which @a path under @a root was created", but in fact 
> returns the revision in which it was last modified.

I think the first sentence of the following docstring is wrong:

    /** Set @a *revision to the revision in which @a path under @a root was
     * created.  Use @a pool for any temporary allocations.  @a *revision
will
     * be set to #SVN_INVALID_REVNUM for uncommitted nodes (i.e. modified
nodes
     * under a transaction root).  Note that the root of an unmodified
transaction
     * is not itself considered to be modified; in that case, return the
revision
     * upon which the transaction was based.
     */
    svn_error_t *
    svn_fs_node_created_rev(svn_revnum_t *revision,

It sounds as though it gives the answer to `svn log --stop-on-copy
--limit=1 -r 0:HEAD path@root`, but in fact it gives the "Last Changed
Revision" of path@root.

I think we need at least this patch:

    Index: subversion/include/svn_fs.h
    ===================================================================
    --- subversion/include/svn_fs.h	(revision 1717002)
    +++ subversion/include/svn_fs.h	(working copy)
    @@ -1775,2 +1775,2 @@
    -/** Set @a *revision to the revision in which @a path under @a root was
    - * created.  Use @a pool for any temporary allocations.  @a *revision
will
    +/** Set @a *revision to the revision in which @a path under @a root was
last
    + * modified.  Use @a pool for any temporary allocations.  @a *revision
will

I didn't check the sibling functions for analogous docstring bugs.

I can't commit this myself due to an outstanding issue with my apache
account :-(

Cheers,

Daniel