Mailing-List: contact users-help@subversion.apache.org; run by ezmlm
Precedence: bulk
Subject: [PATCH] APR install/configuration issue error handling (was: building
 SVN trunk on Windows fails on python gen-make.py)
To: Bert Huijben <bert@qqmail.nl>, 'subversion' <users@subversion.apache.org>
References: <5537A910.5080409@egosoft.com>
 <07e801d07d17$34eb4ca0$9ec1e5e0$@qqmail.nl>
From: Stefan Hett <stefan@egosoft.com>
Message-ID: <55AD16F1.4050301@egosoft.com>
Date: Mon, 20 Jul 2015 17:42:41 +0200
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.1.0
MIME-Version: 1.0
In-Reply-To: <07e801d07d17$34eb4ca0$9ec1e5e0$@qqmail.nl>
Content-Type: multipart/mixed;
 boundary="------------050003000808070307000004"

This is a multi-part message in MIME format.
--------------050003000808070307000004
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit


>> -----Original Message-----
>> From: Stefan Hett [mailto:stefan@egosoft.com]
>> Sent: woensdag 22 april 2015 15:59
>> To: 'subversion'
>> Subject: building SVN trunk on Windows fails on python gen-make.py
>>
>> Hi,
>>
>> I just tried to build
>> https://svn.apache.org/repos/asf/subversion/branches/svn-mergeinfo-
>> normalizer
>> on Windows following the INSTALL file documentation up to the point
>> where the make file is being generated.
>>
>> Using this call: python gen-make.py -t vcproj --with-zlib=..\zlib
>> --with-apr=..\apr --with-apr-util=..\apr-util --vsnet-version=2010
>> I'm now getting the following error:
>>
>> Traceback (most recent call last):
>>     File "gen-make.py", line 325, in <module> main(conf, gentype,
>> skip_depends=skip, other_options=rest.list)
>>     File "gen-make.py", line 62, in main generator =
>> gen_module.Generator(fname, verfname, other_options)
>>     File "build\generator\gen_vcnet_vcproj.py", line 36, in __init__
>> 'vcnet-vcproj')
>>     File "build\generator\gen_win.py", line 83, in __init__
>> self.find_libraries(True)
>>     File "build\generator\gen_win_dependencies.py", line 286, in
>> find_libraries self._find_apr()
>>     File "build\generator\gen_win_dependencies.py", line 395, in
>> _find_apr bin_files = os.listdir(dll_dir)
>> FileNotFoundError: [WinError 3] The system cannot find the path
>> specified: '..\\apr\\bin'
>>
>> Looking at the apr-directory I downloaded/extracted, there's no
>> apr/bin-directory.
>> I downloaded the following APR-source package (1.5.1):
>> http://mirror.serversupportforum.de/apache//apr/apr-1.5.1-win32-src.zip
>>
>> Did I get the wrong one? Or did I miss some step?
> Subversion expects that you already build apr before using it as a source of binaries to link against. It is not going to build apr for you.
>
> Building APR would have created this bin directory. (A patch to produce a nicer error message would be welcome :))
>
>
> There are other scripts that may help you building Subversion and all dependencies. I maintain one such script as part of SharpSvn (Repository: https://ctf.open.collab.net/svn/repos/sharpsvn/trunk/imports ; username guest; no password). This script uses NAnt, and is used to produce the publicly available binaries for SharpSvn and SlikSvn.
>
> Somewhere in the Subversion repository there is a perl script that should also be able to help with building on Windows, but I don't have experience with that script.
>
> 	Bert
As the saying goes "better later than never", as per ur suggestion, 
here's a patch which adds some better handling to detect user-errors 
when putting just the downloaded source of apr (and/or apr-util) into 
the specified folder. Suggested patch for trunk and nomination for 1.9 I 
guess.

[[[
    Produce human readable error when APR/APR-util wasn't 
installed/configured correctly.

* build/generator/gen_win_dependencies.py
   (_find_apr,
    _find_apr_util): Add detection for missing lib/dll directories, 
pointing to
                     an unconfigured/uninstalled source directory.
]]]

Regards,
Stefan

--------------050003000808070307000004
Content-Type: text/plain; charset=UTF-8;
 name="apr_install_error_detection.patch"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
 filename="apr_install_error_detection.patch"

SW5kZXg6IGdlbl93aW5fZGVwZW5kZW5jaWVzLnB5DQo9PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gZ2Vu
X3dpbl9kZXBlbmRlbmNpZXMucHkJKHJldmlzaW9uIDE2OTE5MTMpDQorKysgZ2VuX3dpbl9k
ZXBlbmRlbmNpZXMucHkJKHdvcmtpbmcgY29weSkNCkBAIC00MDEsNiArNDAxLDEyIEBADQog
ICAgICAgICBkbGxfZGlyID0gb3MucGF0aC5qb2luKHNlbGYuYXByX3BhdGgsICdiaW4nKQog
ICAgICAgICBkZWJ1Z19kbGxfZGlyID0gTm9uZQogCisgICAgaWYgbm90IGxpYl9kaXIgb3Ig
bm90IG9zLnBhdGguaXNkaXIobGliX2Rpcikgb3IgXAorICAgICAgIGRsbF9kaXIgYW5kIG5v
dCBvcy5wYXRoLmlzZGlyKGRsbF9kaXIpOgorICAgICAgc3lzLnN0ZGVyci53cml0ZSgiRVJS
T1I6ICdhcHIgYmluaWFyZXMnIG5vdCBmb3VuZC5cbiIpCisgICAgICBzeXMuc3RkZXJyLndy
aXRlKCJVc2UgJy0td2l0aC1hcHInIG9wdGlvbiB0byBjb25maWd1cmUgQVBSIGxvY2F0aW9u
IGFuZCBtYWtlIHN1cmUgdG8gaGF2ZSBBUFIgcHJvcGVybHkgY29uZmlndXJlZC9pbnN0YWxs
ZWQuXG4iKQorICAgICAgc3lzLmV4aXQoMSkKKwogICAgIGV4dHJhX2JpbiA9IFtdCiAKICAg
ICBpZiBkbGxfZGlyOgpAQCAtNTAyLDYgKzUwOCwxMiBAQA0KICAgICAgICAgZGxsX2RpciA9
IG9zLnBhdGguam9pbihzZWxmLmFwcl91dGlsX3BhdGgsICdiaW4nKQogICAgICAgICBkZWJ1
Z19kbGxfZGlyID0gTm9uZQogCisgICAgaWYgbm90IGxpYl9kaXIgb3Igbm90IG9zLnBhdGgu
aXNkaXIobGliX2Rpcikgb3IgXAorICAgICAgIGRsbF9kaXIgYW5kIG5vdCBvcy5wYXRoLmlz
ZGlyKGRsbF9kaXIpOgorICAgICAgc3lzLnN0ZGVyci53cml0ZSgiRVJST1I6ICcgYXByLXV0
aWwgYmluaWFyZXMnIG5vdCBmb3VuZC5cbiIpCisgICAgICBzeXMuc3RkZXJyLndyaXRlKCJV
c2UgJy0td2l0aC1hcHItdXRpbCcgb3B0aW9uIHRvIGNvbmZpZ3VyZSBBUFItVXRpbCBsb2Nh
dGlvbiBhbmQgbWFrZSBzdXJlIHRvIGhhdmUgQVBSLVV0aWwgcHJvcGVybHkgY29uZmlndXJl
ZC9pbnN0YWxsZWQuXG4iKQorICAgICAgc3lzLmV4aXQoMSkKKwogICAgIGV4dHJhX2JpbiA9
IFtdCiAKICAgICBpZiBkbGxfZGlyOgo=
--------------050003000808070307000004--