Return-Path: 
 <users-return-22100-apmail-subversion-users-archive=subversion.apache.org@subversion.apache.org>
X-Original-To: apmail-subversion-users-archive@minotaur.apache.org
Delivered-To: apmail-subversion-users-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id D4E3411884
	for <apmail-subversion-users-archive@minotaur.apache.org>;
 Mon,  8 Sep 2014 13:42:41 +0000 (UTC)
Received: (qmail 96443 invoked by uid 500); 8 Sep 2014 13:42:41 -0000
Delivered-To: apmail-subversion-users-archive@subversion.apache.org
Received: (qmail 96395 invoked by uid 500); 8 Sep 2014 13:42:41 -0000
Mailing-List: contact users-help@subversion.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:users-help@subversion.apache.org>
List-Unsubscribe: <mailto:users-unsubscribe@subversion.apache.org>
List-Post: <mailto:users@subversion.apache.org>
List-Id: <users.subversion.apache.org>
Delivered-To: mailing list users@subversion.apache.org
Received: (qmail 96377 invoked by uid 99); 8 Sep 2014 13:42:40 -0000
Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 08 Sep 2014 13:42:40 +0000
X-ASF-Spam-Status: No, hits=-0.7 required=5.0
	tests=RCVD_IN_DNSWL_LOW,SPF_PASS
X-Spam-Check-By: apache.org
Received-SPF: pass (nike.apache.org: domain of kim.grasman@gmail.com
 designates 209.85.216.53 as permitted sender)
Received: from [209.85.216.53] (HELO mail-qa0-f53.google.com) (209.85.216.53)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 08 Sep 2014 13:42:15 +0000
Received: by mail-qa0-f53.google.com with SMTP id w8so13723595qac.26
        for <multiple recipients>; Mon, 08 Sep 2014 06:42:11 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type;
        bh=0J3oFDMaJBQqrjHdkq9wgosloPGqqiMPldC3mPAVFCE=;
        b=HpRk7vbfTB+B5QYxxXp6NfwAe4txk0KhkAnLef/L/+HW9iNv6L0qTje9EVT1ZHFO3w
         ublwTpsa4rEBJ33ks/YqhPDNzAaPgTgG4BqlvdCHRYL7BEeGxOUD8Y1N7T84BiIZkMsT
         ZBb7a0Sbdj2bjFq2A4FQZlXegazffCRsPIOteyCP75XebpwJO0hkOnL5dquvQq3EruDD
         9f24yhbV1gbtFVtfSUznn7DvMkRqkzNdBC3tb9LsgQ8QOTmvUW9XqgMDpPg/1VE6JVwE
         L1+uzBtH4SHgy+AmgOrHVkDk4QZ2fROYGVBC0B0z1wp9PSCD0fEZ4DC7WVcVkLcXIGXi
         DNNw==
MIME-Version: 1.0
X-Received: by 10.140.28.8 with SMTP id 8mr39752683qgy.19.1410183731457; Mon,
 08 Sep 2014 06:42:11 -0700 (PDT)
Received: by 10.140.42.21 with HTTP; Mon, 8 Sep 2014 06:42:11 -0700 (PDT)
In-Reply-To: <87d2b6w8e0.fsf@ntlworld.com>
References: 
 <CAA26kuTRHTW=k+XFFvQY2bet0=Q_mH1zOJrfBEqrFnLiXk19=g@mail.gmail.com>
	<87d2b6w8e0.fsf@ntlworld.com>
Date: Mon, 8 Sep 2014 15:42:11 +0200
Message-ID: 
 <CANt7B+d+syVYG8ptfJFh7iXKKznfJAkULt0iaOr0Krq=n_pcrg@mail.gmail.com>
Subject: Re: Change prevprops in pre-commit
From: =?UTF-8?B?S2ltIEdyw6RzbWFu?= <kim.grasman@gmail.com>
To: Philip Martin <philip.martin@wandisco.com>
Cc: Sergey Azarkevich <azarkevich@gmail.com>,
 users <users@subversion.apache.org>,
	dev@subversion.apache.org
Content-Type: text/plain; charset=UTF-8
X-Virus-Checked: Checked by ClamAV on apache.org

On Mon, Sep 8, 2014 at 3:26 PM, Philip Martin
<philip.martin@wandisco.com> wrote:
>
> I think we should provide command line support for setting txnprops.
> The code is simple enough, the iterface is a bit harder.  There was was
> some debate on IRC as to whether it should be
>
>    svnlook propset -t txn
>
> or
>
>    svnadmin settxnprop -t txn
>
> For svnlook it means adding a write subcommand to a program that at
> present is read-only.  If we add "-r REV" support to be consistent with
> other subcommands then we would then need further options to run/bypass
> hooks. This would then overlap with the existing "svnadmin setrevprop".
>
> For svnadmin it means that a pre-commit needs to use different programs
> for reading and writing txnprops rather than just using svnlook, and the
> name new name "settxnprop" is a different pattern from the existing
> "propget" name.
>
> We will probably need some way to delete txnprops as well.  There is
> currently a new-in-1.9 "svnadmin delrevprop" to delete revision
> properties, so either "svnlook propdel" or "svnadmin deltxnprop".
> Or perhaps the new subcommand to set txnprops should allow a way to
> delete as well?

This would be much appreciated, we talked about this this morning in
the wake of our Python hack modifying transaction files directly.

I don't know what the tools look like on the inside, but to me it
would be nice if the interface treated -r and -t as interchangeable,
so it was just a matter of choosing whether you wanted to poke at a
transaction-in-flight or an existing revision.

- Kim