Mailing-List: contact users-help@subversion.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: neutral (nike.apache.org: local policy)
References: 
 <CAA26kuTRHTW=k+XFFvQY2bet0=Q_mH1zOJrfBEqrFnLiXk19=g@mail.gmail.com>
 <87d2b6w8e0.fsf@ntlworld.com>        
Message-ID: <1410186145.95737.YahooMailNeo@web87704.mail.ir2.yahoo.com>
Date: Mon, 8 Sep 2014 15:22:25 +0100
From: Julian Foad <julianfoad@btopenworld.com>
Reply-To: Julian Foad <julianfoad@btopenworld.com>
Subject: Re: Change prevprops in pre-commit
To: Philip Martin <philip.martin@wandisco.com>,
  Sergey Azarkevich <azarkevich@gmail.com>
Cc: users <users@subversion.apache.org>,
  "dev@subversion.apache.org" <dev@subversion.apache.org>
In-Reply-To: <87d2b6w8e0.fsf@ntlworld.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable

Philip Martin wrote:=0A> Sergey Azarkevich <azarkevich@gmail.com> writes:=
=0A> =0A>>=A0 I see in pre-commit hook template that changing revisions pro=
perties in=0A>>=A0 transaction are allowed.=0A>>=A0 But I can't find way fo=
r it (I want change svn:author to more readable).=0A>> =0A>>=A0 Is here way=
 for this with svn, svnadmin, svnlook ... or other standard=0A>>=A0 tool? O=
r I should use Subversion API and write simple tool?=0A> =0A> I think we sh=
ould provide command line support for setting txnprops.=0A> The code is sim=
ple enough, the iterface is a bit harder.=A0 There was was=0A> some debate =
on IRC as to whether it should be=0A> =0A> =A0=A0 svnlook propset -t txn=0A=
> =0A> or=0A> =0A> =A0=A0 svnadmin settxnprop -t txn=0A=0Aor=0A=0A=A0=A0 sv=
nadmin setrevprop -t txn=0A=0Ais another reasonable option.=0A=0A> For svnl=
ook it means adding a write subcommand to a program that at=0A> present is =
read-only.=A0 If we add "-r REV" support to be consistent =0A> with=0A> oth=
er subcommands then we would then need further options to run/bypass=0A> ho=
oks. This would then overlap with the existing "svnadmin =0A> setrevprop".=
=0A> =0A> For svnadmin it means that a pre-commit needs to use different pr=
ograms=0A> for reading and writing txnprops rather than just using svnlook,=
 and the=0A> name new name "settxnprop" is a different pattern from the exi=
sting=0A> "propget" name.=0A> =0A> We will probably need some way to delete=
 txnprops as well.=A0 There is=0A> currently a new-in-1.9 "svnadmin delrevp=
rop" to delete revision=0A> properties, so either "svnlook propdel" or "svn=
admin =0A> deltxnprop".=0A=0Aor, again, "svnadmin delrevprop -t TXN ...".=
=0A=0A> Or perhaps the new subcommand to set txnprops should allow a way to=
=0A> delete as well?=0A=0AFor reference, the rev-prop/txn-prop commands cur=
rently available in 'svnadmin' and 'svnlook' are:=0A=0Asvnadmin=0A=A0=A0 se=
tlog =A0 =A0 -r REV [--bypass-hooks] FILE=0A=A0=A0 setrevprop -r REV [--use=
-pre|post-revprop-change-hook] NAME FILE=0A=A0=A0 delrevprop -r REV [--use-=
pre|post-revprop-change-hook] NAME=A0 # new for 1.9=0A=0Asvnlook=0A=A0=A0 a=
uthor=A0=A0 [-t TXN|-r REV]=0A=A0=A0 date =A0=A0=A0 [-t TXN|-r REV]=0A=A0=
=A0 log=A0 =A0=A0=A0 [-t TXN|-r REV]=0A=A0=A0 propget=A0 [-t TXN|-r REV] --=
revprop NAME=0A=A0=A0 proplist [-t TXN|-r REV] --revprop=0A=0ANotice that t=
here is already a lot of inconsistency in the commands and their options.=
=0A=0A'svnlook' has so far been read-only, as the name 'svnlook' implies. T=
hat could change, although some people may be uncomfortable with that.=0A=
=0AAn option to use or bypass the hooks is needed for commands that write t=
o a rev-prop, but not applicable when writing to a txn-prop nor when readin=
g any properties.=0A=0AThe 'svn' program can also read/write rev-props, but=
 it cannot access txn-props, and can't bypass the hooks.=0A=0ANote also tha=
t the commands for setting and querying locks are distributed between 'svna=
dmin' and 'svnlook' in a non-obvious way too. I mention this because locks =
are another of the three=A0 main sorts of user data in a repository, along =
with the versioned trees and rev-props. If we are going to make a decision =
about the user interface for reading and writing revprops, we might want to=
 give some consideration to the UI for locks at the same time.=0A=0A- Julia=
n=0A