From users-return-21553-apmail-subversion-users-archive=subversion.apache.org@subversion.apache.org Thu Jun 5 15:12:42 2014 Return-Path: X-Original-To: apmail-subversion-users-archive@minotaur.apache.org Delivered-To: apmail-subversion-users-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9CECCC8DB for ; Thu, 5 Jun 2014 15:12:42 +0000 (UTC) Received: (qmail 61987 invoked by uid 500); 5 Jun 2014 15:12:42 -0000 Delivered-To: apmail-subversion-users-archive@subversion.apache.org Received: (qmail 61956 invoked by uid 500); 5 Jun 2014 15:12:42 -0000 Mailing-List: contact users-help@subversion.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list users@subversion.apache.org Received: (qmail 61949 invoked by uid 99); 5 Jun 2014 15:12:42 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Jun 2014 15:12:42 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of jcorvel@gmail.com designates 209.85.216.50 as permitted sender) Received: from [209.85.216.50] (HELO mail-qa0-f50.google.com) (209.85.216.50) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Jun 2014 15:12:38 +0000 Received: by mail-qa0-f50.google.com with SMTP id j15so1560492qaq.9 for ; Thu, 05 Jun 2014 08:12:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=l7Gp8036u2kyM2uApHrFLA7ouQEt5woXFf0+kOPAQL0=; b=cV8lkQ3uw2SveQJmDTKhGNRp2PtztEU7+QR8OKyqovgtc42+cqTaApIjsesidPqHL2 Ta22OCDPrwivpmY0CslRqBjzGicvucdZb25tmI2akGiY0hkFQc23E8v571GCICl9EG7q 8q8IW+jpI6YAQn8A90BJYIUCbLCR3TMx4rjTsc2m62uEo0PwFQxrUAnmMyuCrt/M3exG TcRffr/DBKSOK5is4HcmXf2IKWSydosV17fe2izu+OiXNw9Yq84hs4wFWMvrAyKE3R2V 0YsdHbBIQZh+tu+vwFbCuKegE44D3cgZpT9S8i64NTTYo6H/TD0rGG3aduhVEGmrZW1j 1XlA== X-Received: by 10.224.19.196 with SMTP id c4mr17904727qab.86.1401981134407; Thu, 05 Jun 2014 08:12:14 -0700 (PDT) MIME-Version: 1.0 Received: by 10.96.164.201 with HTTP; Thu, 5 Jun 2014 08:11:54 -0700 (PDT) In-Reply-To: References: <080901cf7bff$9dfffcf0$d9fff6d0$@qqmail.nl> From: Johan Corveleyn Date: Thu, 5 Jun 2014 17:11:54 +0200 Message-ID: Subject: Re: [BUG] svnlook diff infinite loop To: Kevin Priest Cc: subversion_users@googlegroups.com, Arwin Arni , Bert Huijben , "users@subversion.apache.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Virus-Checked: Checked by ClamAV on apache.org On Thu, Jun 5, 2014 at 4:02 PM, Kevin Priest wro= te: > > > On Thursday, June 5, 2014 6:03:14 AM UTC-4, Johan Corveleyn wrote: >> >> > On Fri, May 30, 2014 at 5:36 PM, Bert Huijben wrote: >> >> >> >> Hi, >> >> >> >> >> >> >> >> I tried to reproduce your problem for debugging. >> >> >> >> >> >> >> >> I did a: >> >> >> >> >> >> >> >> $ svn =E2=80=93version >> >> >> >> svn, version 1.8.9-SlikSvn-1.8.9-X64 (SlikSvn/1.8.9) X64 >> >> >> >> compiled May 8 2014, 20:00:31 on x86_64-microsoft-windows6.2.9200 >> >> >> >> >> >> >> >> $ svnadmin create svnlook-loop >> >> >> >> >> >> >> >> $ svnadmin load svnlook-loop < svnlook_diff_infinite_loop.dump >> >> >> >> >> >> >> >> <<< Started new transaction, based on original revision 1 >> >> >> >> * adding path : xyz ... done. >> >> >> >> >> >> >> >> ------- Committed revision 1 >>> >> >> >> >> >> >> >> >> <<< Started new transaction, based on original revision 2 >> >> >> >> * editing path : xyz ... done. >> >> >> >> >> >> >> >> ------- Committed revision 2 >>> >> >> >> >> >> >> >> >> <<< Started new transaction, based on original revision 3 >> >> >> >> * editing path : xyz ... done. >> >> >> >> >> >> >> >> ------- Committed revision 3 >>> >> >> >> >> >> >> >> >> $ svnlook diff svnlook-loop >> >> >> >> Index: xyz >> >> >> >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> >> >> >> --- xyz 2014-05-29 13:37:20 UTC (rev 2) >> >> >> >> +++ xyz 2014-05-29 13:37:32 UTC (rev 3) >> >> >> >> >> >> >> >> Property changes on: xyz >> >> >> >> ___________________________________________________________________ >> >> >> >> Modified: svn:mergeinfo >> >> >> >> ## -1,3 +1,3 ## >> >> >> >> /abc/2.0.A:8 >> >> >> >> /abc/2.1:6 >> >> >> >> -/abc/2.2:7 >> >> >> >> \ No newline at end of property >> >> >> >> +/abc/2.2:7,9 >> >> >> >> \ No newline at end of property >> >> >> >> >> >> >> >> >> >> >> >> Can you explain what is different for you than in this scenario, as >> >> this >> >> certainly doesn=E2=80=99t reproduce your problem >> >> >> >> >> >> >> >> Bert >> >> >> >> >> >> >> >> From: Arwin Arni Nandagopal [mailto:ar...@collab.net] >> >> Sent: donderdag 29 mei 2014 15:59 >> >> To: users@svn >> >> Subject: [BUG] svnlook diff infinite loop >> >> >> >> >> >> >> >> svnlook diff hangs on an infinite loop when it encounters certain >> >> svn:mergeinfo. >> >> >> >> >> >> >> >> This happens ONLY on Windows 64-bit svn 1.8.x or later client. >> >> >> >> >> >> >> >> I was able to trace the flow of code all the way to: >> >> >> >> >> >> >> >> subversion/svnlook/svnlook.c:display_prop_diffs >> >> >> >> >> >> >> >> Inside here, there is a call to: >> >> >> >> subversion/libsvn_diff/util.c:svn_diff__display_prop_diffs >> >> >> >> >> >> >> >> Which doesn't seem to get executed at all. >> >> >> >> >> >> >> >> I have no experience debugging C code on Windows, and hence the >> >> speculation. >> >> >> >> >> >> >> >> I have with me the smallest possible subset of data that will reprodu= ce >> >> this issue. >> >> >> >> Load the attached dumpfile and run svnlook diff -r3 /path/to/repo wit= h >> >> a >> >> 1.8.x or later binary on a Windows 64-bit machine, and it WILL hang. >> >> >> >> >> >> >> >> I really hope someone with debugging skills on Windows can help me ou= t >> >> here. >> >> >> >> >> >> Regards, >> >> >> >> Arwin Arni >> > >> >On Thu, Jun 5, 2014 at 9:04 AM, Arwin Arni Nandagopal >> > wrote: >> > Hi Bert, >> > >> > Sorry for the delayed reply. I'm not sure if SlikSvn will suffer from >> > the >> > same problem. I'm not even sure where the problem lies. I am able to >> > reproduce this issue with the open source command-line client. Does >> > SlikSvn >> > customize the client in any way (possibly removing the issue)? I >> > installed >> > SlikSvn 1.8.9 x64 and I wasn't able to reproduce the error either. Whe= re >> > I >> > am getting the error is the following environment: >> > >> > $ svn --version >> > svn, version 1.8.9 (r1591380) >> > compiled May 8 2014, 05:13:23 on >> > x86_64/x86-microsoft-windows5.1.2600 >> > >> >> What do you mean with "the open source command-line client"? Where did >> you download this client? The Apache Subversion project itself does >> not produce binaries. >> >> Or did you compile the client yourself from source? >> >> [ BTW: this list prefers bottom-posting ... i.e. please put your reply >> at the bottom or inline, thanks. ] >> >> -- >> Johan > > > Johan, > > I have been having this problem with the executable delivered from > CollabNet. > I downloaded your free client, installed it and in runs without issue. > > Thanks so much for your reply and your download! Oh, you mean the SlikSvn distribution? I have nothing to do with it, that's Bert Huijben's binary, so thank you Bert :-). So IIUC the infinite loop happens with the CollabNet binary, but not with SlikSvn? I guess someone from CollabNet should look into it then. --=20 Johan