Mailing-List: contact users-help@subversion.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: pass (nike.apache.org: domain of brane@wandisco.com designates
 74.125.83.52 as permitted sender)
Message-ID: <53212D0D.9080509@wandisco.com>
Date: Thu, 13 Mar 2014 04:59:09 +0100
From: =?UTF-8?B?QnJhbmtvIMSMaWJlag==?= <brane@wandisco.com>
Organization: WANdisco
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9;
 rv:24.0) Gecko/20100101 Thunderbird/24.3.0
MIME-Version: 1.0
To: users@subversion.apache.org
Subject: Re: Mergeinfo overwritten from successive merges
References: 
 <cca0441f6cba412392039287b5f2055e@BLUPR05MB215.namprd05.prod.outlook.com>
In-Reply-To: 
 <cca0441f6cba412392039287b5f2055e@BLUPR05MB215.namprd05.prod.outlook.com>
Content-Type: multipart/mixed;
 boundary="------------000705090009010702090306"

This is a multi-part message in MIME format.
--------------000705090009010702090306
Content-Type: multipart/alternative;
 boundary="------------090401000008010102030704"


--------------090401000008010102030704
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

On 12.03.2014 21:24, Jeb Wilson wrote:
> Hello all,
>
> Apologies if this has already been reported, but it's a difficult one to search for. This came through from TortoiseSVN 1.8.5.
>
> Here's the basic way to reproduce:
>
> User #1 merges from A -> B and commits.
> User #2 merges SOMETHING ELSE from A->B but doesn't update first to get User #1's changes.
> User #2 commits, and SVN allows the commit. After reviewing the resulting mergeinfo, User #1's mergeinfo is overwritten, and the merge info from User #1 is lost.
>
> I've reproduced this several times with TortoiseSVN 1.8.5. Note, we're using 2.5.16 version of VisualSVN server.
>
> My opinion is SVN should reject User #2's commit, and inform them they have an out-of-date working copy and it should force them to update before committing their merge changes.
> When I downgrade to 1.8.3, the proper "out of date" warning comes up and forces an update. Thus, it must have been something that was introduced as of 1.8.4.
> FYI, another user has reported this issue here: http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&dsMessageId=3071239

I can't reproduce this with either 1.8.5 or 1.8.8, with the attached
script; both give the same output (see below). If this is indeed a bug,
and not pilot error, it would appear to be specific to TortoiseSVN, not
Subversion.

-- Brane

brane@zulu:/tmp/test$ ~/repro.sh 
+ svnadmin create repo
+ svn checkout file:///tmp/test/repo structure
Checked out revision 0.
+ svn mkdir structure/trunk
A         structure/trunk
+ echo a
+ echo b
+ svn add structure/trunk/a structure/trunk/b
A         structure/trunk/a
A         structure/trunk/b
+ svn commit -mm structure
Adding         structure/trunk
Adding         structure/trunk/a
Adding         structure/trunk/b
Transmitting file data ..
Committed revision 1.
+ rm -fr structure
+ svn copy -mm file:///tmp/test/repo/trunk file:///tmp/test/repo/branch

Committed revision 2.
+ svn checkout file:///tmp/test/repo/trunk user1
A    user1/a
A    user1/b
Checked out revision 2.
+ echo aa
+ svn commit -mm user1
Sending        user1/a
Transmitting file data .
Committed revision 3.
+ svn checkout file:///tmp/test/repo/trunk user2
A    user2/a
A    user2/b
Checked out revision 3.
+ echo bb
+ svn commit -mm user2
Sending        user2/b
Transmitting file data .
Committed revision 4.
+ svn switch file:///tmp/test/repo/branch user1
U    user1/a
Updated to revision 4.
+ svn switch file:///tmp/test/repo/branch user2
U    user2/b
U    user2/a
Updated to revision 4.
+ svn merge -c3 file:///tmp/test/repo/trunk user1
--- Merging r3 into 'user1':
U    user1/a
--- Recording mergeinfo for merge of r3 into 'user1':
 U   user1
+ svn commit -mm user1
Sending        user1
Sending        user1/a
Transmitting file data .
Committed revision 5.
+ svn merge -c4 file:///tmp/test/repo/trunk user2
--- Merging r4 into 'user2':
U    user2/b
--- Recording mergeinfo for merge of r4 into 'user2':
 U   user2
+ svn commit -mm user2
Sending        user2
svn: E155011: Commit failed (details follow):
svn: E155011: Directory '/private/tmp/test/user2' is out of date
svn: E160028: Directory '/branch' is out of date


-- 
Branko Čibej | Director of Subversion
WANdisco // Non-Stop Data
e. brane@wandisco.com

--------------090401000008010102030704
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 8bit

<html>
  <head>
    <meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    <div class="moz-cite-prefix">On 12.03.2014 21:24, Jeb Wilson wrote:<br>
    </div>
    <blockquote
cite="mid:cca0441f6cba412392039287b5f2055e@BLUPR05MB215.namprd05.prod.outlook.com"
      type="cite">
      <pre wrap="">Hello all,

Apologies if this has already been reported, but it's a difficult one to search for. This came through from TortoiseSVN 1.8.5.

Here's the basic way to reproduce:

User #1 merges from A -&gt; B and commits.
User #2 merges SOMETHING ELSE from A-&gt;B but doesn't update first to get User #1's changes.
User #2 commits, and SVN allows the commit. After reviewing the resulting mergeinfo, User #1's mergeinfo is overwritten, and the merge info from User #1 is lost.

I've reproduced this several times with TortoiseSVN 1.8.5. Note, we're using 2.5.16 version of VisualSVN server.

My opinion is SVN should reject User #2's commit, and inform them they have an out-of-date working copy and it should force them to update before committing their merge changes.
When I downgrade to 1.8.3, the proper "out of date" warning comes up and forces an update. Thus, it must have been something that was introduced as of 1.8.4.
FYI, another user has reported this issue here: <a class="moz-txt-link-freetext" href="http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&amp;dsMessageId=3071239">http://tortoisesvn.tigris.org/ds/viewMessage.do?dsForumId=4061&amp;dsMessageId=3071239</a></pre>
    </blockquote>
    <br>
    I can't reproduce this with either 1.8.5 or 1.8.8, with the attached
    script; both give the same output (see below). If this is indeed a
    bug, and not pilot error, it would appear to be specific to
    TortoiseSVN, not Subversion.<br>
    <br>
    -- Brane<br>
    <br>
    <pre>brane@zulu:/tmp/test$ ~/repro.sh 
+ svnadmin create repo
+ svn checkout <a class="moz-txt-link-freetext" href="file:///tmp/test/repo">file:///tmp/test/repo</a> structure
Checked out revision 0.
+ svn mkdir structure/trunk
A         structure/trunk
+ echo a
+ echo b
+ svn add structure/trunk/a structure/trunk/b
A         structure/trunk/a
A         structure/trunk/b
+ svn commit -mm structure
Adding         structure/trunk
Adding         structure/trunk/a
Adding         structure/trunk/b
Transmitting file data ..
Committed revision 1.
+ rm -fr structure
+ svn copy -mm <a class="moz-txt-link-freetext" href="file:///tmp/test/repo/trunk">file:///tmp/test/repo/trunk</a> <a class="moz-txt-link-freetext" href="file:///tmp/test/repo/branch">file:///tmp/test/repo/branch</a>

Committed revision 2.
+ svn checkout <a class="moz-txt-link-freetext" href="file:///tmp/test/repo/trunk">file:///tmp/test/repo/trunk</a> user1
A    user1/a
A    user1/b
Checked out revision 2.
+ echo aa
+ svn commit -mm user1
Sending        user1/a
Transmitting file data .
Committed revision 3.
+ svn checkout <a class="moz-txt-link-freetext" href="file:///tmp/test/repo/trunk">file:///tmp/test/repo/trunk</a> user2
A    user2/a
A    user2/b
Checked out revision 3.
+ echo bb
+ svn commit -mm user2
Sending        user2/b
Transmitting file data .
Committed revision 4.
+ svn switch <a class="moz-txt-link-freetext" href="file:///tmp/test/repo/branch">file:///tmp/test/repo/branch</a> user1
U    user1/a
Updated to revision 4.
+ svn switch <a class="moz-txt-link-freetext" href="file:///tmp/test/repo/branch">file:///tmp/test/repo/branch</a> user2
U    user2/b
U    user2/a
Updated to revision 4.
+ svn merge -c3 <a class="moz-txt-link-freetext" href="file:///tmp/test/repo/trunk">file:///tmp/test/repo/trunk</a> user1
--- Merging r3 into 'user1':
U    user1/a
--- Recording mergeinfo for merge of r3 into 'user1':
 U   user1
+ svn commit -mm user1
Sending        user1
Sending        user1/a
Transmitting file data .
Committed revision 5.
+ svn merge -c4 <a class="moz-txt-link-freetext" href="file:///tmp/test/repo/trunk">file:///tmp/test/repo/trunk</a> user2
--- Merging r4 into 'user2':
U    user2/b
--- Recording mergeinfo for merge of r4 into 'user2':
 U   user2
+ svn commit -mm user2
Sending        user2
svn: E155011: Commit failed (details follow):
svn: E155011: Directory '/private/tmp/test/user2' is out of date
svn: E160028: Directory '/branch' is out of date
</pre>
    <br>
    <div class="moz-signature">-- <br>
      <span style="font-face:sans-serif;font-size:9pt;line-height:18pt">Branko
        Čibej <span style="color: #f90">|</span> <span
          style="font-weight:bold">Director of Subversion</span>
        <br>
        WANdisco <span style="color: #f90">//</span> <span
          style="font-style:oblique">Non-Stop Data</span>
        <br>
        <span style="color: #ccc">e.</span> <a class="moz-txt-link-abbreviated" href="mailto:brane@wandisco.com">brane@wandisco.com</a></span></div>
  </body>
</html>

--------------090401000008010102030704--

--------------000705090009010702090306
Content-Type: application/x-sh;
 name="repro.sh"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="repro.sh"

#!/bin/sh

svn="${1:-svn}"
svnadmin="${2:-svnadmin}"
repo="file://$(pwd)/repo"
rm -fr repo structure user1 user2

set -e
set -x

"$svnadmin" create repo
# r0
"$svn" checkout "$repo" structure
"$svn" mkdir structure/trunk
echo "a" > structure/trunk/a
echo "b" > structure/trunk/b
"$svn" add structure/trunk/a structure/trunk/b
"$svn" commit -mm structure
# r1
rm -fr structure
"$svn" copy -mm "$repo"/trunk "$repo"/branch
# r2

"$svn" checkout "$repo"/trunk user1
echo "aa" > user1/a
"$svn" commit -mm user1
# r3

"$svn" checkout "$repo"/trunk user2
echo "bb" > user2/b
"$svn" commit -mm user2
# r4

"$svn" switch "$repo"/branch user1
"$svn" switch "$repo"/branch user2

"$svn" merge -c3 "$repo"/trunk user1
"$svn" commit -mm user1
# r5

"$svn" merge -c4 "$repo"/trunk user2
"$svn" commit -mm user2
# r6

--------------000705090009010702090306--