Mailing-List: contact users-help@subversion.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: neutral (nike.apache.org: local policy)
From: "Bert Huijben" <bert@qqmail.nl>
To: "'Stefan Sperling'" <stsp@apache.org>,
	"'Johan Corveleyn'" <jcorvel@gmail.com>
Cc: "'Alexey Neyman'" <stilor@att.net>,
	<users@subversion.apache.org>,
	"'Alfred Perlstein'" <bright@mu.org>
References: <510A8FAA.2020903@mu.org> <201302041154.22334.stilor@att.net>
 <20130204211729.GI32109@byrne.stsp.name> <1925822.W2HtcYFXhn@etoile>
 <CAB84uBWw1rczgfD8YDjZGvVc92Ry8duM4kwX+MCBuYP-L=bQ0Q@mail.gmail.com>
 <20130205160840.GA32341@byrne.stsp.name>
 <CAB84uBV5TDL2WnAGhkuNVm_E8NqLqDD48FxC4ByoLTYNLqDq1w@mail.gmail.com>
 <20130205230759.GE32341@byrne.stsp.name>
In-Reply-To: <20130205230759.GE32341@byrne.stsp.name>
Subject: RE: FreeBSD project and subversion.
Date: Wed, 6 Feb 2013 00:41:52 +0100
Message-ID: <088501ce03fa$60f661b0$22e32510$@qqmail.nl>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 7bit
Thread-Index: 
 AQJcamsSgue8XdbfqVcRbFGvxWvZgAIETLQNAv5ndcQCOKN+wAHqfiHsAZjziO4Cg78ewQGa1WnkltgzmwA=
Content-Language: nl


> -----Original Message-----
> From: Stefan Sperling [mailto:stsp@apache.org]
> Sent: woensdag 6 februari 2013 00:08
> To: Johan Corveleyn
> Cc: Alexey Neyman; users@subversion.apache.org; Alfred Perlstein
> Subject: Re: FreeBSD project and subversion.
> 
> On Tue, Feb 05, 2013 at 09:18:33PM +0100, Johan Corveleyn wrote:
> > Hmm, okay, but I would have preferred some more discussion before you
> > implemented this. It's not clear to me that this decreases the
> > surprises. I can perfectly imagine just as many questions being asked
> > on users@ with the question: "Why does 'svn diff left.txt right.txt'
> > give me an empty diff, while 'svn diff ^/left.txt right.txt' does the
> > right thing?"
> >
> > I think it would be better to consistently point users to the
> > --old/--new syntax, so as to educate users more (so I'm okay with the
> > change in the error message), not hide it even more from them.
> 
> Well, the point that convinced me was that previously 'svn diff' raised
> an error in the case of 'svn diff ^/left.txt right.txt'.
> That's clearly intended to be a comparison between a URL and a path,
> which the diff code already supports. So I think the diff code should
> just show an appropriate diff. I don't see how people could be conflating
> a URL->WC or WC->URL diff with a WC->WC diff.
> 
> BTW, I'm thinking about adding more shortcuts:
> 
>   svn diff UNVERSIONED-PATH WCPATH
>   svn diff WCPATH UNVERSIONED-PATH
>   svn diff UNVERSIONED-PATH1 UNVERSIONED-PATH2
> 
> All of which are supported by 'svn diff --old=X --new=Y' (in 1.8-to-be,
> not in 1.7), but not by plain 'svn diff'.

I'm not sure if I like these variants with unversioned paths.

This might make users think that these paths are versioned and without
warning who wouldn't expect that?

The new unversioned/arbitrary diff is nice in specific situations, but it
shouldn't' break the normal cases where 'svn diff *' would do one thing
completely differently if it happens to match exactly two files, where one
is versioned and one is not, or both are unversioned.

If we want something like that we should support that with a flag like
--unversioned (better name suggestions welcome)

I really like the url vs path diff changes though.

	Bert