Mailing-List: contact users-help@subversion.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: pass (nike.apache.org: local policy)
Date: Thu, 15 Nov 2012 07:41:03 +0200
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Marc Schlinger <Marc.Schlinger@pace.com>
Cc: "users@subversion.apache.org" <users@subversion.apache.org>
Subject: Re: modifyng symlinks
Message-ID: <20121115054103.GE2953@lp-shahaf.local>
References: 
 <4CABA54457D642419D9D07136C83F89F0D716AC5@SN2PRD0510MB360.namprd05.prod.outlook.com>
 <20121115051246.GD2953@lp-shahaf.local>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20121115051246.GD2953@lp-shahaf.local>
User-Agent: Mutt/1.5.18 (2008-05-17)

Daniel Shahaf wrote on Thu, Nov 15, 2012 at 07:12:46 +0200:
> Marc Schlinger wrote on Wed, Nov 14, 2012 at 10:52:52 +0000:
> > Hello,
> > 
> > I'm using :
> > 
> > svn, version 1.7.7 (r1393599)
> >    compiled Nov  7 2012, 19:23:31
> > 
> > on a debian host.
> > 
> > I am trying to create and  apply a patch on a repos with the new  svn commands: svn diff and svn patch.
> > 
> > The commit is, for what matters, changing the target of a symlink.
> > The patch section related to my symlink looks like this:
> > 
> > 
> > Modified: folder/symlink
> > ===================================================================
> > --- folder/symlink	2012-10-18 10:56:32 UTC (rev 76023)
> > +++ folder/symlink	2012-10-18 11:25:32 UTC (rev 76024)
> > @@ -1 +1 @@
> > -link file
> > \ No newline at end of file
> > +link other_file
> > \ No newline at end of file
> > 
> > 
> > Since I'm on a linux host my symlink file is really a symlink.
> > This way "svn patch" is actually trying to modify  "folder/file" instead of editing file pointed by "folder/symlink".
> > 
> > Is this a known behaviour ? 
> > 
> 
> I don't recall a previous report of this, and I can reproduce it with trunk:
> 
> % $svn patch 1
> subversion/svn/patch-cmd.c:91: (apr_err=2)
> subversion/libsvn_client/patch.c:2987: (apr_err=2)
> subversion/libsvn_client/patch.c:2892: (apr_err=2)
> subversion/libsvn_client/patch.c:1915: (apr_err=2)
> subversion/libsvn_client/patch.c:919: (apr_err=2)
> subversion/libsvn_subr/io.c:3193: (apr_err=2)
> svn: E000002: Can't open file '/home/danielsh/src/svn/t1/wc/iota': No such file or directory
> zsh: exit 1     $svn patch 1
> 
> (where the patch changes "link foo" to "link bar" in the file ^/iota)
> 

I've added a regression test for this: http://svn.apache.org/r1409652

> 
> > Regards,
> > Marc Schlinger
> > 
> > 
> > 
> > 
> >