subversion-users mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel Shahaf <...@daniel.shahaf.name>
Subject Re: svnserve crash
Date Fri, 02 Nov 2012 18:52:17 GMT
Andreas Mohr wrote on Fri, Nov 02, 2012 at 19:44:24 +0100:
> Hi,
> 
> On Fri, Nov 02, 2012 at 08:35:11PM +0200, Daniel Shahaf wrote:
> > Please attach log files as text/* MIME type (maybe by renaming them to
> > *.txt) so it's easier to read/reply to them.
> > 
> > Now, the first thing that jumps out is that some of the actual
> > parameters are 0x00000000 or 0x00001000; for example:
> > 
> > #14  0x13f639fd8 in serve(conn=(svn_ra_svn_conn_st *) 0x00000000, params=(serve_params_t
*) 0x00000000, pool=(apr_pool_t *) 0x00000000) at
> > 
> > which might suggest a stack smash, or just that this is how windows
> > stack traces normally work and I'm not aware of that convention.
> 
> Input parameter values as shown by the backtrace
> deviating from their original caller values
> may also have been caused by these input variables getting modified
> *within* the function (some people in some cases tend to prefer
> creating local variable copies to actively work on, for this reason).
> 

Yes, C permits that, but it won't be the case here since we never set
'pool' variables to NULL (except when a variable declaration does that
implicitly) and never pass NULL as the actual value for an 'apr_pool_t *'
parameter.

> However, three parameters in a row being NULL
> might obviously point to a more systematic mem erase.
> 
> Andreas Mohr

Mime
View raw message