Mailing-List: contact users-help@subversion.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: pass (athena.apache.org: local policy)
Date: Wed, 17 Oct 2012 12:31:22 +0200
From: Stefan Sperling <stsp@elego.de>
To: Joshua Woodward-Clarke <jaxxa90@gmail.com>
Cc: cz02 <cz02@cdak.net>, users@subversion.apache.org
Subject: Re: SVN patch IGNORES file without newline at end of file
Message-ID: <20121017103122.GB31493@ted.stsp.name>
Mail-Followup-To: Joshua Woodward-Clarke <jaxxa90@gmail.com>,
	cz02 <cz02@cdak.net>, users@subversion.apache.org
References: <50769DFB.6060208@cdak.net>
 <20121011191415.GC25766@byrne.stsp.name>
 <5077EA3B.9050002@cdak.net>
 <CAP2CVqcE+3AccZTqmakajakJ+YTb_aGZpD_nK0HjV6s9y8kgow@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CAP2CVqcE+3AccZTqmakajakJ+YTb_aGZpD_nK0HjV6s9y8kgow@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)

On Wed, Oct 17, 2012 at 01:17:03PM +1100, Joshua Woodward-Clarke wrote:
> I just tried it and can confirm that I am getting the same issue.
> (I am fairly new to SVN so I may have done somthing wrong)
> 
> I am running Win XP SP3.
> 
> I downloaded the files and tried applying the patches.
> I tried with with the TortoiseSVN "apply patch" and "svn patch" from the
> command line.
> 
> 
> Both time the first patch "p.patch" failed to do any changed to aaa.txt
> (only bbb.txt), while "p2.patch" changed both files.

Funny, I can now reproduce this problem on unix, too.
I don't understand what happened the first time I tried to reproduce it.

Anyway, the fix is trivial: There's a rouge 'break' statement which
causes an early exit from the parsing loop before the hunk is fully
processed, which means the hunk will be ignored.

Thanks for reporting this!
I'll commit this fix along with a regression test.

Index: subversion/libsvn_diff/parse-diff.c
===================================================================
--- subversion/libsvn_diff/parse-diff.c (revision 1398725)
+++ subversion/libsvn_diff/parse-diff.c (working copy)
@@ -595,7 +595,6 @@ parse_next_hunk(svn_diff_hunk_t **hunk,
                     original_end = hunk_text_end;
                   if (modified_end == 0)
                     modified_end = hunk_text_end;
-                  break;
                 }
 
               SVN_ERR(svn_io_file_seek(apr_file, APR_SET, &pos, iterpool));