subversion-users mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Phippard <markp...@gmail.com>
Subject Re: better messaging w/ mod_dontdothat?
Date Thu, 06 Sep 2012 15:34:15 GMT
On Thu, Sep 6, 2012 at 11:26 AM, Doug Hunley <doug.hunley@gmail.com> wrote:

> On Wed, Sep 5, 2012 at 4:46 PM, Mark Phippard <markphip@gmail.com> wrote:
> > Assume you already looked at the code?  The comments are interesting and
> > might point in a direction to go:
>
> I did, but as I read it that only makes reference to populating the
> Apache logs. Where there does it show that I can set the Apache status
> code (or similar) so I can use my own custom error messaging?
>
> Apologies if it should be obvious, I'm not a coder
>
> Me neither.

But there were two things that jumped out at me.  The first is this comment:

* TODO: Try and pass back a custom document body containing a
*       serialized svn_error_t so the client displays a better
*       error message. */

It implies someone thought it might be possible to pass back an error
message the client could handle.  I do not know if they tried and failed or
it is genuinely possible for someone to try.

The other thing was just the return code itself:

e = ap_bucket_error_create(403, "No Soup For You!",
                                     f->r->pool, f->c->bucket_alloc);

It seems that it would be easy to return a different HTTP error code if you
were just looking for a different error code.  That said, it seems like 403
is the appropriate error code.

A 403 means that client authentication was successful.  There is no reason
to think that credentials were wrong.  403 means they are not allowed to do
what they tried to do and should not try again.

-- 
Thanks

Mark Phippard
http://markphip.blogspot.com/

Mime
View raw message