Mailing-List: contact users-help@subversion.apache.org; run by ezmlm
Precedence: bulk
Received-SPF: neutral (athena.apache.org: local policy)
From: Philip Martin <philip.martin@wandisco.com>
To: michael_rytting@agilent.com
Cc: users@subversion.apache.org
Subject: Re: Apparent "svn rm" scaling problem in 1.7.x
References: <20111031154444.GF14858@ted.stsp.name>
	<B9DACE0D88F57F458EAEB9B2083FFE0D033054AA6F@cos-us-mb12.agilent.com>
	<20111101084921.GB32398@ted.stsp.name>
	<B9DACE0D88F57F458EAEB9B2083FFE0D033054AE4B@cos-us-mb12.agilent.com>
	<20111101143505.GE32398@ted.stsp.name>
	<B9DACE0D88F57F458EAEB9B2083FFE0D033054AFC7@cos-us-mb12.agilent.com>
	<20111101170007.GG32398@ted.stsp.name>
	<B9DACE0D88F57F458EAEB9B2083FFE0D033054B021@cos-us-mb12.agilent.com>
	<20111101172147.GH32398@ted.stsp.name>
	<B9DACE0D88F57F458EAEB9B2083FFE0D033054B051@cos-us-mb12.agilent.com>
	<20111101180056.GJ32398@ted.stsp.name>
Date: Tue, 01 Nov 2011 18:29:59 +0000
In-Reply-To: <20111101180056.GJ32398@ted.stsp.name> (Stefan Sperling's message
	of "Tue, 1 Nov 2011 19:00:57 +0100")
Message-ID: <8739e7vgpk.fsf@stat.home.lan>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii

Stefan Sperling <stsp@elego.de> writes:

> On Tue, Nov 01, 2011 at 11:31:35AM -0600, michael_rytting@agilent.com wrote:
> Note that I am not going to commit this as is.
> It just tests whether the overhead of sorting paths in sqlite matters
> much on NFS.
>
> Index: subversion/libsvn_wc/wc-queries.sql
> ===================================================================
> --- subversion/libsvn_wc/wc-queries.sql	(revision 1196149)
> +++ subversion/libsvn_wc/wc-queries.sql	(working copy)
> @@ -1208,7 +1208,6 @@ WHERE wc_id = ?1
>  
>  -- STMT_SELECT_DELETE_LIST
>  SELECT local_relpath FROM delete_list
> -ORDER BY local_relpath
>  
>  -- STMT_FINALIZE_DELETE
>  DROP TABLE IF EXISTS delete_list

I put in the ORDER BY to preserve the parents before children
notification used by 1.6.  I wonder if that notification order is
important?

A patch that we could commit without affecting the order is:

Index: subversion/libsvn_wc/wc-queries.sql
===================================================================
--- subversion/libsvn_wc/wc-queries.sql	(revision 1196106)
+++ subversion/libsvn_wc/wc-queries.sql	(working copy)
@@ -1193,7 +1193,7 @@
 CREATE TEMPORARY TABLE delete_list (
 /* ### we should put the wc_id in here in case a delete spans multiple
    ### working copies. queries, etc will need to be adjusted.  */
-   local_relpath TEXT PRIMARY KEY NOT NULL
+   local_relpath TEXT PRIMARY KEY NOT NULL UNIQUE
    )
 
 /* This matches the selection in STMT_INSERT_DELETE_FROM_NODE_RECURSIVE */

-- 
Philip