From users-return-5433-daniel=haxx.se@subversion.apache.org Sun Oct 17 14:44:44 2010 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on giant.haxx.se X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DS_FRIEND autolearn=ham version=3.3.1 Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by giant.haxx.se (8.14.3/8.14.3/Debian-9.1) with SMTP id o9HCigCA003292 for ; Sun, 17 Oct 2010 14:44:43 +0200 Received: (qmail 6001 invoked by uid 500); 17 Oct 2010 12:44:33 -0000 Mailing-List: contact users-help@subversion.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list users@subversion.apache.org Received: (qmail 5994 invoked by uid 99); 17 Oct 2010 12:44:33 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 17 Oct 2010 12:44:33 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=10.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS Received-SPF: pass (nike.apache.org: local policy) Received: from [192.109.42.8] (HELO einhorn.in-berlin.de) (192.109.42.8) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 17 Oct 2010 12:44:23 +0000 X-Envelope-From: stsp@stsp.name Received: from ted.stsp.name (ted.stsp.name [217.197.84.34]) by einhorn.in-berlin.de (8.13.6/8.13.6/Debian-1) with ESMTP id o9HChw4d031489 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sun, 17 Oct 2010 14:43:59 +0200 Received: from ted.stsp.name (stsp@localhost [127.0.0.1]) by ted.stsp.name (8.14.3/8.14.3) with ESMTP id o9HChw6e013765; Sun, 17 Oct 2010 14:43:58 +0200 (CEST) Received: (from stsp@localhost) by ted.stsp.name (8.14.3/8.14.3/Submit) id o9HChvde010496; Sun, 17 Oct 2010 14:43:57 +0200 (CEST) Date: Sun, 17 Oct 2010 14:43:57 +0200 From: Stefan Sperling To: Daniel Shahaf Cc: Paul Maier , users@subversion.apache.org Subject: Re: Bug report against SVN 1.6.13 Message-ID: <20101017124357.GA16990@ted.stsp.name> Mail-Followup-To: Daniel Shahaf , Paul Maier , users@subversion.apache.org References: <8B679D2178A2408FAD50F5B6DDF0D436@sulzer.de> <20101014100133.GB3830@jack.stsp.name> <20101016134046.GB18430@ted.stsp.name> <20101017030937.GA15231@daniel3.local> <20101017032449.GB18802@daniel3.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20101017032449.GB18802@daniel3.local> User-Agent: Mutt/1.5.21 (2010-09-15) X-Scanned-By: MIMEDefang_at_IN-Berlin_e.V. on 192.109.42.8 X-Virus-Checked: Checked by ClamAV on apache.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.3.5 (giant.haxx.se [80.67.6.50]); Sun, 17 Oct 2010 14:44:44 +0200 (CEST) X-Friend: Friend On Sun, Oct 17, 2010 at 05:24:49AM +0200, Daniel Shahaf wrote: > Daniel Shahaf wrote on Sun, Oct 17, 2010 at 05:09:37 +0200: > > Index: subversion/libsvn_wc/copy.c > > =================================================================== > > --- subversion/libsvn_wc/copy.c (revision 1023400) > > +++ subversion/libsvn_wc/copy.c (working copy) > > @@ -238,6 +238,17 @@ copy_versioned_file(svn_wc__db_t *db, > > tmpdir_abspath, > > TRUE, /* recursive */ > > cancel_func, cancel_baton, scratch_pool)); > > + > > + /* Remove 'read-only' from the copied file. */ > > + { > > + const svn_string_t *needs_lock; > > + SVN_ERR(svn_wc__internal_propget(&needs_lock, db, src_abspath, > > + SVN_PROP_NEEDS_LOCK, scratch_pool, > > + scratch_pool)); > > + if (needs_lock) > > + svn_io_set_file_read_write(tmp_dst_abspath, FALSE, scratch_pool); > > + } > > + > > if (tmp_dst_abspath) > > { > > svn_skel_t *work_item; > > Probably not a good idea to set_file_read_write(tmp_dst_abspath) > before the check that it's non-NULL. I'll have to look into that. Thanks for looking into this, Daniel! Your patch seems to handle copies only. What about locally added files?