subversion-users mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dcz <...@phpbb-seo.com>
Subject Re: Junior developers
Date Thu, 18 Feb 2010 08:39:25 GMT
Le 17/02/2010 18:34, Ryan Schmidt a écrit :
> On Feb 17, 2010, at 08:36, dcz wrote:
>
>    
>> Le 17/02/2010 15:24, Andy Levy a écrit :
>>      
>>>        
>>      
>>> There is no "dry run" for a commit. It's conceivable that you could
>>> check the user ID in the pre-commit, and if the committer is JD,
>>> reject the commit while mailing a diff to SD which represents the
>>> change being attempted. This would require a lot of overhead on the
>>> server though.
>>>
>>> Honestly, I think you're trying to apply an excessively technical
>>> solution to a fundamentally non-technical idea.
>>>
>>>        
>> You're probably right, I was just thinking that a bit more automation could be handy.
>> Though solution 1) is very close to do it, could use a mailing list to warn all SD
at a time and see who handles first.
>> I would just have liked to skip the JD "putting together a patch" step and have it
done by the server, but ho well.
>>      
> I think it would be easy -- for the server or the JD manually -- to put together a patch
-- it's simply:
>
> svn di>  patchfile
>
> It could even be mailed to the SD straightaway:
>
> svn di | mail sd@example.com
>
>
> You could try to build this into the pre-commit script, but I'd think the JD would start
getting annoyed that his patch review process keeps giving him negative feedback by telling
him "Your commit was rejected with the following message" (or whatever the verbiage is that
Subversion prints out). I'd also say it's confusing that the JD has to run "svn commit" when
he's not really committing anything to the repository. Instead I'd suggest you write a new
script, call it svnreview.sh or something, and have the JD run that instead. This script runs
"svn di", maybe some other sanity checks first, then sends the email.
>
>    

Hello,

I just need time to look into svn hooks a bit more.
As dumb as it seems, I did not think about this as code review yet, I 
was struck with the perm / auth concept while searching. Your phrasing 
made me find few more things I may also have to consider :
http://ostatic.com/blog/open-source-code-review-tools

Did anyone of you tried on of those with svn yet ?
 From what I've read so far, it seems that "review board" may be able to 
do such thing :
http://www.reviewboard.org/docs/manual/dev/faq/#what-are-pre-commit-and-post-commit-reviews
"Pre-commit reviews are where code is reviewed before it’s checked into 
a public repository and mainline, non-developer branch. Code isn’t 
committed until reviewers sign off on it, leaving the tree stable and 
easing changes."

I already use redmine to handle a dev team 
(http://phpbb-seo.coda-cola.net/), and find it handy especially since 
www.coda-cola.net is offering hosting for it (with the backup / 
maintenance harassement), but after I makes things a bit clearer about 
review board, I may convince them to add it or just install it myself 
somewhere else as a pre commit only tool.

I'll keep you in touch, meanwhile, if you have thoughts about this, do 
not hesitate to share ;-)





Mime
View raw message