From dev-return-39504-archive-asf-public=cust-asf.ponee.io@subversion.apache.org Wed Oct 9 08:39:23 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 2C02F180645 for ; Wed, 9 Oct 2019 10:39:23 +0200 (CEST) Received: (qmail 49137 invoked by uid 500); 9 Oct 2019 08:39:22 -0000 Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@subversion.apache.org Received: (qmail 49122 invoked by uid 99); 9 Oct 2019 08:39:21 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 09 Oct 2019 08:39:21 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 3087BC2147 for ; Wed, 9 Oct 2019 08:39:21 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.199 X-Spam-Level: X-Spam-Status: No, score=-0.199 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, KAM_SHORT=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-ec2-va.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id qLsVJzTe5tws for ; Wed, 9 Oct 2019 08:39:19 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=209.85.221.176; helo=mail-vk1-f176.google.com; envelope-from=jcorvel@gmail.com; receiver= Received: from mail-vk1-f176.google.com (mail-vk1-f176.google.com [209.85.221.176]) by mx1-ec2-va.apache.org (ASF Mail Server at mx1-ec2-va.apache.org) with ESMTPS id F26F6BC8BD for ; Wed, 9 Oct 2019 08:39:18 +0000 (UTC) Received: by mail-vk1-f176.google.com with SMTP id u4so357972vkl.6 for ; Wed, 09 Oct 2019 01:39:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wjQA/flXMTkYb60Umvr+75Fe4JhWDrgMzxtFgNmceUg=; b=EYO+Vu0dJwilErByzmHUnrTtaHhIEoiWAqbz835G9k/GkV4dVFso/4cl4+oG9EbzIv MYgp1Uz155Y9n91mBBbeJ2AjDanza7QjErm7li/POe44a3RNyHjAqSkjIzieKn+AhKrc DjtnfZXgIYRzSXPXq3C8ZS0mrP9GiI/TQqtEChzWfIozNqmgSwKH98qlj6R0inQoP68K arpBILxkMpgheyEF3DV3gLQf2e6KavAI1BcqAGk06fhICpPOb1ysYEP8ZNr9jY8LrapC jzYiggmT7aQkxzDmcdn4zX2MULJIQQeMr1H99HQ41AO7cUsD7EQu/wFhtS19WxF1aFoX d2jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wjQA/flXMTkYb60Umvr+75Fe4JhWDrgMzxtFgNmceUg=; b=KZR4cKDfQjFMVS+yytS64n51ZtxqNPK1/mX3RTsFPUPG33l9oQF6A8kE3i/I6usR8r 8nY7euGvlk5Q/CIMTe3HufIey2zM/kMHaWoe1TuMrSp4x3M/HHrxO0ZdmKTkrXsAX7vG JfVzwk7QoEh6yZ8DaV10cK4x68QsbZsuS93QJ0YC//+rN4LfrHvuxFtdEiEbHpr43V3z 3M/a9rztuwXhj2kTTx2vuapLP/TkPfBf+ZtY5wR2oD80Xyjds0wz6iKZr0oqeh/RHQ0p IowCUZ+TBAhQpYLJDf3fUU5M6OAikTHT+g7EZnDQ39zvVPOx8RgHEOk05n80/0Y2siWn 72ww== X-Gm-Message-State: APjAAAWUnEQVSJBfYGuDiIw1jZlxhkJKUITs2rfxg2jLaDMTfTzEQtiw bfID+jfXi0nxO/cnDz/VedgFvTXWo5DYah2bvis= X-Google-Smtp-Source: APXvYqx9I8kFYQWWV5wCOX9sD32b40MGYiRZXbWzaGaneN7zQRpkMoJnaq6CpWlsensF5jtGbIXAaKpoHDV0TW7SxMk= X-Received: by 2002:a1f:2e0a:: with SMTP id u10mr1376316vku.79.1570610352355; Wed, 09 Oct 2019 01:39:12 -0700 (PDT) MIME-Version: 1.0 References: <49ddad98-c55e-4255-9aeb-245a54cc75af@www.fastmail.com> <2f9bc052-7077-417c-8622-d3b33185873d@www.fastmail.com> <2732ed6f-e59c-a840-1952-dab1c97be856@apache.org> In-Reply-To: <2732ed6f-e59c-a840-1952-dab1c97be856@apache.org> From: Johan Corveleyn Date: Wed, 9 Oct 2019 10:39:01 +0200 Message-ID: Subject: SVN-4065 - server should enforce LF normalization for svn:eol-style=native (was: PMCs: any Hackathon requests? (deadline 11 October)) To: Julian Foad Cc: Daniel Shahaf , Subversion Developers Content-Type: text/plain; charset="UTF-8" On Tue, Oct 8, 2019 at 6:13 PM Julian Foad wrote: > Daniel Shahaf wrote: > > SVN-4065 - server should enforce LF normalization for svn:eol- > > style=native files. (Not just a patch is needed, but also a FAQ entry > > that explains how to handle existing repositories that have this > > problem, once the patch is released. If it'll be like when > > svn_repos__validate_prop() was added, then dump/load will still work, > > but svnsync not.) > > That issue appears to need review. It's not clear to me whether the > server should really enforce LF normalization. I rather think not. > There's a discussion thread linked from it, with no final conclusion. My last comment in the issue [1] summarizes the discussion(s) as follows: [[[ Some recent discussion on dev@: http://svn.haxx.se/dev/archive-2012-12/0179.shtml The current thinking from that thread is that this should (or can only) be enforced through a pre-commit hook. It was suggested that this would ideally be some standard, supported (and efficient) pre-commit hook. In a follow-up thread, Ivan suggested to create a new program "svnhooks" for standardizing such hooks (and go together with a configuration file to enable/disable certain behaviors): http://svn.haxx.se/dev/archive-2012-12/0217.shtml ]]] I think that was the conclusion from those threads. I.e. it would be best if we developed a standard "svnhooks" program that can be invoked from the pre-commit hook (and not try to implement this directly in the repos layer). At least, after those svnhooks suggestions no-one objected, so I assumed silent consensus about that way forward :-) ... Not sure if this is a good bite-sized task for interested hackers though ... Though it's quite well-contained (develop a separate (small) program with a configuration file, depending on existing server-side API's), and we have a clear use case to start with. [1] https://issues.apache.org/jira/browse/SVN-4065?focusedCommentId=14931167&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-14931167 -- Johan