From dev-return-39579-archive-asf-public=cust-asf.ponee.io@subversion.apache.org Tue Oct 15 23:07:52 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 3D5BC180651 for ; Wed, 16 Oct 2019 01:07:52 +0200 (CEST) Received: (qmail 74229 invoked by uid 500); 15 Oct 2019 23:07:51 -0000 Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@subversion.apache.org Received: (qmail 74207 invoked by uid 99); 15 Oct 2019 23:07:51 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 15 Oct 2019 23:07:51 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id A1A74C1431 for ; Tue, 15 Oct 2019 23:07:50 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.199 X-Spam-Level: X-Spam-Status: No, score=-0.199 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001] autolearn=disabled Authentication-Results: spamd4-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-he-de.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id ry1zUS8GAMPX for ; Tue, 15 Oct 2019 23:07:48 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2607:f8b0:4864:20::941; helo=mail-ua1-x941.google.com; envelope-from=jcorvel@gmail.com; receiver= Received: from mail-ua1-x941.google.com (mail-ua1-x941.google.com [IPv6:2607:f8b0:4864:20::941]) by mx1-he-de.apache.org (ASF Mail Server at mx1-he-de.apache.org) with ESMTPS id 1B0B87DDBE for ; Tue, 15 Oct 2019 23:07:48 +0000 (UTC) Received: by mail-ua1-x941.google.com with SMTP id q11so6659852uao.1 for ; Tue, 15 Oct 2019 16:07:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=R2tI1xPx8YkW4gc+mUI0f0hXpAOZErzfXiOSvMjNjFc=; b=K2INZSErtumaq/IRoA/u+r82r/TNa9Tjouw52hZ4uFria77aCYr0HnGC1nt9EQI/Bc lzFQc1b5HJZ0HjMYB8a1rfnQoVIgfA0mGmy4FlWPXCtsJDF9+VUEuFtlQWlNWVKZvdlA BCZiHpjKcz7KA7j7YIBZ6wMUNo2m+2ujeuCFR8PTugpAxzI14d+FU3EIjQ5IY/eYQo49 YPUUuMvT1p3TCRC0f8C70e0TuJe2bAsDYRHFJq0RkahcGEWYzN0O7fqH0yD4+xwUrU76 64dAPO6nNr9BIOgQmS0PyNL8id00f0tqyoCuCshEFVZtFxb2j9b06OEptrzszb/ILZTY rxeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=R2tI1xPx8YkW4gc+mUI0f0hXpAOZErzfXiOSvMjNjFc=; b=NX3djXV34QKfGCERTjiXiGA2T3lC5WVOsS5KLa8tebsoqAzs8W3On6zqR3UjYVkAlM Iw4+GBUix7vZmNvEBOMzyH5tusP2mzHTTL7PcEi9KVjVqBo7efMjTGy9WI6K/5dHqL6f 4JPphkIfi6s8PyDZknxYB1zThg3PM5V24kkErmTwXswQQiE4zVG2O6sFmOwWvRK2fTHm QCJLkMDzTv9q2D2ck4PQf7p0gukoSv8Ytwn5CG+pw3HivZFlsx8IWEjobrsnV4U1Nspv tHcZL+KIypfRvOHyUL+eTKOse2icSeJSgnXXFUrdAYI+y3CschMQaPnlM7PqwFicDElm WT8g== X-Gm-Message-State: APjAAAU0kMwXBO+hsJqJKtL0+Z8ETaDDesUbnmGqPNF6duqPq9KtdQYd XFB44JSMh0UVxtc3YO222q9sjpi/e5S5qz601y60JwHM X-Google-Smtp-Source: APXvYqxSFm1LgytDo8FS/1YZZ7FU87dDBuTjexcHh7AuTqqaEc8XKeMjN4Nc+hjw43u/Jb1IwrQZpwZzHj3sH8eq2nY= X-Received: by 2002:ab0:d82:: with SMTP id i2mr19436771uak.34.1571180866616; Tue, 15 Oct 2019 16:07:46 -0700 (PDT) MIME-Version: 1.0 References: <20191010205444.srzggabby2en27xg@tarpaulin.shahaf.local2> <9e97a2ad-854b-4cb3-af3a-b80c6a14fa0b@www.fastmail.com> <20191011175601.y4rlv62tvmbcxkjn@tarpaulin.shahaf.local2> <631611e4-0eb3-c3cc-b087-cc33dacc20bb@poem.co.jp> <20191011224709.reoh6tycyk3nyhsb@tarpaulin.shahaf.local2> <77168982-1be9-4ce5-9dc1-a1eefa5dd6e1@www.fastmail.com> <7fb80cbe-62a6-23e5-ad19-c6b09a7f5c3f@poem.co.jp> <45c1b6f1-d392-9a2c-7f2c-0bea80a4d6aa@poem.co.jp> <592f1891-fe42-b402-dbd0-521520f08cfd@poem.co.jp> In-Reply-To: <592f1891-fe42-b402-dbd0-521520f08cfd@poem.co.jp> From: Johan Corveleyn Date: Wed, 16 Oct 2019 01:07:32 +0200 Message-ID: Subject: Re: Test failures with Python 3 (Re: PMCs: any Hackathon requests? (deadline 11 October)) To: Yasuhito FUTATSUKI Cc: Subversion Developers Content-Type: text/plain; charset="UTF-8" On Tue, Oct 15, 2019 at 6:20 PM Yasuhito FUTATSUKI wrote: > > On 2019-10-15 17:17, Johan Corveleyn wrote: > > On Tue, Oct 15, 2019 at 9:26 AM Yasuhito FUTATSUKI wrote: > >> > >> On 2019-10-15 07:04, Daniel Shahaf wrote: > >>> Yasuhito FUTATSUKI wrote on Sun, 13 Oct 2019 04:01 +00:00: > >>>> On 2019/10/13 7:24, Daniel Shahaf wrote: > >> > >>>> I see. Now I agree it would suffice here. > >>>> > >>>>> So, how about: > >>>>> > >>>>> 1. Make the test use non-binary mode for changing and reading the > >>>>> file 'lambda'. > > >>>>> 2. Locally revert the C part of r1841731 and make sure the modified test > >>>>> still (correctly) fails. (That revision both added the test and > >>>>> fixed the bug the test checks for.) > > I overlooked comments in this test. On step 2 the test will continue to loop > as far as resource is available, or until signaled. > > And yes, after 'svn merge -r1841731:1841730 subversion/libsvn_client/conflicts.c', > the test can't reach patched line. So no more test is needed on step 2, both > on Unix/Linux and on Windows. > > >>>> > >>>> So it looks sufficient to me. > >>> > >>> Cool. Will you perchance have time to do this? No worries if not. > >> > >> Yes, I'll do it on FreeBSD on tonight or tomorrow night (in JST :)). > > with the attached patch, both with Python 2.7.15 and Python 3.7.0 on FreeBSD, > tree_conflict_tests passed. > > >> However I think it is also need to test for each 1 and 2 on Windows, > >> because r1841736 and r1841743 also were attempt to fix this test > >> on Windows, with Python 2. > > > > Feel free to let me know if I need to test something on Windows. > > Thank you. Could you please test the tree_conflict_tests with this patch, > both with Python 2 and Python 3 on Windows? Okay, I can confirm that tree_conflict_tests works with Python 2.7.16 (both with and without the patch) and with 3.7.5 (with the patch) on Windows 7. I did have some trouble testing it with Python 3.7 though: - First, I had to try it on the swig-py3 branch, because on trunk I get this when trying to run any test with py 3.7: [[[ Traceback (most recent call last): File "win-tests.py", line 134, in cp.items('options')) File "build\generator\gen_win_dependencies.py", line 306, in __init__ self.find_libraries(False) File "build\generator\gen_win_dependencies.py", line 327, in find_libraries self._find_jdk(show_warnings) File "build\generator\gen_win_dependencies.py", line 1085, in _find_jdk vermatch = re.search(r'(([0-9]+(\.[0-9]+)+)(_[._0-9]+)?)', line, re.M) File "C:\Python37\lib\re.py", line 183, in search return _compile(pattern, flags).search(string) TypeError: cannot use a string pattern on a bytes-like object ]]] I guess that's one of the issues fixed by the swig-py3 branch. - Then, on the swig-py3 branch, with py 3.7.4 I ran into this issue: https://bugs.python.org/issue37549 (os.dup() fails for standard streams on Windows 7) This fails for any *.py test, because of line 836 in build/run_tests.py: old_stdout = os.dup(sys.stdout.fileno()) It errors out with: OSError: [WinError 87] The parameter is incorrect - Upgraded to py 3.7.5, in which the above issue seems to be fixed. Now, *.py tests still don't work. I get no output at all: [[[ C:\research\svn\dev\swig-py3>python win-tests.py --release -t tree_conflict . 'ruby' is not recognized as an internal or external command, operable program or batch file. Testing Release configuration on local repository. [1/1] tree_conflict_tests.py C:\research\svn\dev\swig-py3> ]]] tests.log only contains one line: START: tree_conflict_tests.py However, if I run it with --log-to-stdout, the tests do work (with a lot of output on stdout). I.e. I get some fails without your fix_tree_conflict_tests_patch.txt, and all tests successful if I apply the patch. Conclusion: I can confirm your patch works on Windows, for both Pyton 2.7.16 and 3.7.5 on the swig-py3 branch. As for the stdout redirection, I guess there might still be a problem ... perhaps the fix for https://bugs.python.org/issue37549 is not sufficient for Windows 7 ... dunno. Maybe someone can try this on Windows 10 and see if it makes a difference. -- Johan