From dev-return-39558-archive-asf-public=cust-asf.ponee.io@subversion.apache.org Sun Oct 13 04:02:26 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 177DF180608 for ; Sun, 13 Oct 2019 06:02:26 +0200 (CEST) Received: (qmail 18553 invoked by uid 500); 13 Oct 2019 04:02:24 -0000 Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@subversion.apache.org Received: (qmail 18529 invoked by uid 99); 13 Oct 2019 04:02:24 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 13 Oct 2019 04:02:24 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 94BA6C056A for ; Sun, 13 Oct 2019 04:02:23 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.002 X-Spam-Level: X-Spam-Status: No, score=-0.002 tagged_above=-999 required=6.31 tests=[SPF_HELO_PASS=-0.001, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-he-de.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id HNGObgDFc2uz for ; Sun, 13 Oct 2019 04:02:20 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=124.35.235.17; helo=poem.co.jp; envelope-from=futatuki@poem.co.jp; receiver= Received: from poem.co.jp (sv.poem.co.jp [124.35.235.17]) by mx1-he-de.apache.org (ASF Mail Server at mx1-he-de.apache.org) with ESMTPS id 41D367DDD3 for ; Sun, 13 Oct 2019 04:02:18 +0000 (UTC) Received: from leopardon-alpha.yf.bsdclub.org (FL1-220-144-210-154.iba.mesh.ad.jp [220.144.210.154]) (authenticated bits=0) by poem.co.jp (8.13.8/8.13.8) with ESMTP id x9D41xs5004764 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Sun, 13 Oct 2019 13:02:00 +0900 Subject: Re: Test failures with Python 3 (Re: PMCs: any Hackathon requests? (deadline 11 October)) To: Daniel Shahaf Cc: Subversion Developers References: <20191010205444.srzggabby2en27xg@tarpaulin.shahaf.local2> <9e97a2ad-854b-4cb3-af3a-b80c6a14fa0b@www.fastmail.com> <20191011175601.y4rlv62tvmbcxkjn@tarpaulin.shahaf.local2> <631611e4-0eb3-c3cc-b087-cc33dacc20bb@poem.co.jp> <20191011224709.reoh6tycyk3nyhsb@tarpaulin.shahaf.local2> <77168982-1be9-4ce5-9dc1-a1eefa5dd6e1@www.fastmail.com> From: Yasuhito FUTATSUKI Message-ID: <7fb80cbe-62a6-23e5-ad19-c6b09a7f5c3f@poem.co.jp> Date: Sun, 13 Oct 2019 13:01:38 +0900 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 MIME-Version: 1.0 In-Reply-To: <77168982-1be9-4ce5-9dc1-a1eefa5dd6e1@www.fastmail.com> Content-Type: text/plain; charset=iso-2022-jp; format=flowed; delsp=yes Content-Language: en-US Content-Transfer-Encoding: 7bit On 2019/10/13 7:24, Daniel Shahaf wrote: > Yasuhito FUTATSUKI wrote on Sat, 12 Oct 2019 03:01 +00:00: >> If textual comparison is sufficient here, it is right to open file >> text mode (with suitable, unified set of `encoding', `errors', and `newline' >> parameter). Otherwise, if strict comparison is needed, we must avoid unwanted, >> not one-on-one corresponding conversion from bytes to str applied by Python. >> In the latter case, it may be rather incorrect to use >> compare_and_display_lines(). > > Good question. I suspect textual comparison would suffice here, because > this is a tree conflicts test, not a keywords semantics test, and the > test case seems to revolve around the tree changes, not around the > newline characters. I see. Now I agree it would suffice here. > So, how about: > > 1. Make the test use non-binary mode for changing and reading the > file 'lambda'. > > 2. Locally revert the C part of r1841731 and make sure the modified test > still (correctly) fails. (That revision both added the test and > fixed the bug the test checks for.) So it looks sufficient to me. Thanks, -- Yasuhito FUTATSUKI