subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Branko Čibej <br...@apache.org>
Subject Re: Issue tracker housecleaning: SVN-1804
Date Tue, 29 Oct 2019 10:41:36 GMT
On 29.10.2019 04:30, Yasuhito FUTATSUKI wrote:
> On 2019-10-28 12:14, Nathan Hartman wrote:
>> Finally got back around to this...
>>
>> With these changes, I verified that:
>> * sending with SMTP works and mailer.py exits with 0 on success
>> * using a deliberately wrong configuration to trigger a failure, the
>> SMTP
>>    exception is caught, the message prints to stderr, and mailer.py
>> exits
>>    with 1 to indicate failure(s) occurred.
>>
>> Since I didn't send a secondary diff or proper log message before, here
>> it is, with the corrections suggested by Daniel.
>>
>> Currently we don't give different treatment to errors in SMTP.login and
>> SMTP.sendmail, although as Yasuhito points out, this may cause repeated
>> errors. Let me know if you feel this should be addressed.
>
> I worry about lock out caused by repeated helo/ehlo error or
> authentication
> failure when the user uses external SMTP service, watched by inspection
> tools (e.g. fail2ban, etc). So I think it is better that
> SMTPAuthenticationError and SMTPHeloError are treated as fatal.

+1

> Even if only one error caused per run, successive trigger to run the
> script
> can alse cause it, though.

Yes, but there's nothing we can do about that. We can only, as you
suggested, give the administrator some time to avoid the lockout by
failing early on fatal errors.


-- Brane

Mime
View raw message