subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Yasuhito FUTATSUKI <futat...@poem.co.jp>
Subject Re: Test failures with Python 3 (Re: PMCs: any Hackathon requests? (deadline 11 October))
Date Tue, 15 Oct 2019 16:20:23 GMT
On 2019-10-15 17:17, Johan Corveleyn wrote:
> On Tue, Oct 15, 2019 at 9:26 AM Yasuhito FUTATSUKI <futatuki@poem.co.jp> wrote:
>>
>> On 2019-10-15 07:04, Daniel Shahaf wrote:
>>> Yasuhito FUTATSUKI wrote on Sun, 13 Oct 2019 04:01 +00:00:
>>>> On 2019/10/13 7:24, Daniel Shahaf wrote:
>>
>>>> I see. Now I agree it would suffice here.
>>>>
>>>>> So, how about:
>>>>>
>>>>> 1. Make the test use non-binary mode for changing and reading the
>>>>>       file 'lambda'.

>>>>> 2. Locally revert the C part of r1841731 and make sure the modified test
>>>>>       still (correctly) fails.  (That revision both added the test and
>>>>>       fixed the bug the test checks for.)

I overlooked comments in this test. On step 2 the test will continue to loop
as far as resource is available, or until signaled.

And yes, after 'svn merge -r1841731:1841730 subversion/libsvn_client/conflicts.c',
the test can't reach patched line. So no more test is needed on step 2, both
on Unix/Linux and on Windows.

>>>>
>>>> So it looks sufficient to me.
>>>
>>> Cool.  Will you perchance have time to do this?  No worries if not.
>>
>> Yes, I'll do it on FreeBSD on tonight or tomorrow night (in JST :)).

with the attached patch, both with Python 2.7.15 and Python 3.7.0 on FreeBSD,
tree_conflict_tests passed.

>> However I think it is also need to test for each 1 and 2 on Windows,
>> because r1841736 and r1841743 also were attempt to fix this test
>> on Windows, with Python 2.
> 
> Feel free to let me know if I need to test something on Windows.

Thank you. Could you please test the tree_conflict_tests with this patch,
both with Python 2 and Python 3 on Windows?

Thanks,
-- 
Yasuhito FUTATSUKI <futatuki@poem.co.jp>

Mime
View raw message