subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Evgeny Kotkov <evgeny.kot...@visualsvn.com>
Subject Re: API to get revision size on disk
Date Fri, 12 Apr 2019 21:43:50 GMT
Julian Foad <julianfoad@apache.org> writes:

> I have reviewed and tested it. Can you commit?

Fixed the typo and committed in https://svn.apache.org/r1857435, thanks!

> * We could keep the existing private API declarations in
> include/private/svn_fs_fs_private.h as well as the new ioctl versions of
> them, rather than moving the existing declarations to a local header. It
> would reduce the patch size, and some people might like the ability to
> link to libsvn_fs_fs directly and and call those functions directly. But
> I don't feel strongly about this; either way is fine for me.

For now I chose to move the declarations to libsvn_fs_fs/fs_fs.h, to avoid
having two parallel interfaces and to only export the version that works
through the FS loader.


Thanks,
Evgeny Kotkov

Mime
View raw message