From dev-return-38994-archive-asf-public=cust-asf.ponee.io@subversion.apache.org Fri Feb 1 12:54:02 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 91805180627 for ; Fri, 1 Feb 2019 13:54:01 +0100 (CET) Received: (qmail 20560 invoked by uid 500); 1 Feb 2019 12:54:00 -0000 Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@subversion.apache.org Received: (qmail 20530 invoked by uid 99); 1 Feb 2019 12:54:00 -0000 Received: from mail-relay.apache.org (HELO mailrelay1-lw-us.apache.org) (207.244.88.152) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 Feb 2019 12:54:00 +0000 Received: from auth2-smtp.messagingengine.com (auth2-smtp.messagingengine.com [66.111.4.228]) by mailrelay1-lw-us.apache.org (ASF Mail Server at mailrelay1-lw-us.apache.org) with ESMTPSA id E020D10F4 for ; Fri, 1 Feb 2019 12:53:59 +0000 (UTC) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailauth.nyi.internal (Postfix) with ESMTP id 621792079B for ; Fri, 1 Feb 2019 07:53:59 -0500 (EST) Received: from web3 ([10.202.2.213]) by compute7.internal (MEProxy); Fri, 01 Feb 2019 07:53:59 -0500 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrjeekgdegjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthenuceurghilhhouhhtmecufedt tdenucenucfjughrpefkhffvggfgtgfoufgjfhffsehtjeertdertdejnecuhfhrohhmpe fluhhlihgrnhcuhfhorgguuceojhhulhhirghnfhhorggusegrphgrtghhvgdrohhrgheq necurfgrrhgrmhepmhgrihhlfhhrohhmpehjuhhlihgrnhdomhgvshhmthhprghuthhhph gvrhhsohhnrghlihhthidqkeegkeektdejvddtqdduledtudejuddvkedqjhhulhhirghn fhhorggupeeprghprggthhgvrdhorhhgsehfohgrugdrmhgvrdhukhenucevlhhushhtvg hrufhiiigvpedt X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 99) id DA3769E567; Fri, 1 Feb 2019 07:53:58 -0500 (EST) Message-Id: <1549025638.1851618.1648570056.0C6338FE@webmail.messagingengine.com> From: Julian Foad To: dev@subversion.apache.org MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" X-Mailer: MessagingEngine.com Webmail Interface - ajax-ec01da05 Subject: Re: [RFC] Incremental svn_delta_path_driver In-Reply-To: <1547666544.2285246.1636432224.0ADE1C23@webmail.messagingengine.com> References: <1547666544.2285246.1636432224.0ADE1C23@webmail.messagingengine.com> Date: Fri, 01 Feb 2019 12:53:58 +0000 Julian Foad wrote on 2019-01-16: > Does the attached patch look reasonable? It provides an incremental > version of the existing svn_delta_path_driver2() function, in which the > caller can provide one path at a time instead of all at once at the > start. It's now committed and debugged: * svn_delta_path_driver_start * svn_delta_path_driver_step -- drives the editor to a new path * svn_delta_path_driver_finish And the all-at-once path driver is slightly upgraded: the new version svn_delta_path_driver3() passes the 'editor' and 'edit_baton' to the callback, which makes most implementations a bit simpler. > We have a few (5 ~ 10) uses of svn_delta_path_driver2() in our codebase > and I think a few more places already where an incremental path driver > could be used if it existed, in addition to me now wanting to use it in > "unshelve" Only used in "unshelve", so far, and I might soon replace that with something else for Shelving v3, but I'm sure it will be useful anyway. -- - Julian