subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sergey Raevskiy <Sergey.Raevs...@visualsvn.com>
Subject Re: [PATCH] Add '--include' and '--exclude' options to 'svnadmin dump'
Date Tue, 12 Feb 2019 14:43:41 GMT
Hello!

After some investigation I realized that PATH passed by repos
layer to AUTHZ_FUNC is not guaranted to be canonical.  In fact, when
path is under copied directory (as in #4760) it does not contain
leading slash.  This causes ary_prefix_match() function to ignore
those paths, since it requires canonical path.

I've attached patch with fix.

Log message:
[[[
Follow-up to r1811992: Canonicalize PATH before passing it to the FILTER_FUNC.

In some cases (e.g. for nodes under copied directories) PATH passed by
repos layer to AUTHZ_FUNC may be non-canonical (missing leading '/').  This
causes FILTER_FUNC implemented in svnadmin to wrongly report PATH as "not
included".

This fixes #4760.

* subversion/libsvn_repos/dump.c
  (dump_filter_authz_func): Canonicalize PATH before passing it
   to the FILTER_FUNC.  Add comment.

* subversion/tests/cmdline/svnadmin_tests.py
  (dump_include_copied_directory): New.
  (test_list): Add new test to table.

Patch by: sergey.raevskiy{_AT_}visualsvn.com
]]]

On Fri, Feb 8, 2019 at 6:27 PM Julian Foad <julianfoad@apache.org> wrote:
>
> Sergey Raevskiy wrote:
> > > Ping! Sergey or anyone, are you able to investigate this?
> >
> > Hello!
> >
> > Sorry for the late reply. I'm plannig to investigate this in short time.
>
> That's good to hear! Thank you.
>
> If you need any help, please ask here or in the #svn-dev IRC channel. I'm sure we'll
be happy to help as much as we can.
>
> --
> - Julian
>
>
> > > Julian Foad wrote on 2018-11-30:
> > > >     https://issues.apache.org/jira/browse/SVN-4729
> [...]
> > > > A user has reported a problem with this feature.
> > > >     https://issues.apache.org/jira/browse/SVN-4760
> > > >
> > > > It looks like when the source of a copied directory is excluded, it is
> > > > only adding the directory itself and not adding the directory's
> > > > contents. That sounds to me like a bug -- it is not the behaviour I
> > > > would expect.
> > > >
> > > > I see that the regression tests only test with an empty source directory.
> > > >     subversion/tests/cmdline/svnadmin_tests.py : dump_exclude_copysource()
etc.

Mime
View raw message