From dev-return-38989-archive-asf-public=cust-asf.ponee.io@subversion.apache.org Mon Jan 28 18:09:36 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id C937818067A for ; Mon, 28 Jan 2019 18:09:35 +0100 (CET) Received: (qmail 53544 invoked by uid 500); 28 Jan 2019 17:09:34 -0000 Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@subversion.apache.org Received: (qmail 53533 invoked by uid 99); 28 Jan 2019 17:09:34 -0000 Received: from mail-relay.apache.org (HELO mailrelay1-lw-us.apache.org) (207.244.88.152) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 28 Jan 2019 17:09:34 +0000 Received: from auth2-smtp.messagingengine.com (auth2-smtp.messagingengine.com [66.111.4.228]) by mailrelay1-lw-us.apache.org (ASF Mail Server at mailrelay1-lw-us.apache.org) with ESMTPSA id 14BD01106; Mon, 28 Jan 2019 17:09:33 +0000 (UTC) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailauth.nyi.internal (Postfix) with ESMTP id 7461820E24; Mon, 28 Jan 2019 12:09:33 -0500 (EST) Received: from web3 ([10.202.2.213]) by compute7.internal (MEProxy); Mon, 28 Jan 2019 12:09:33 -0500 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtledrjedtgddutdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfquhhtnecuuegrihhlohhuthemucef tddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefkhffvggfgtg fofffujghfsehtjeertdertdejnecuhfhrohhmpefluhhlihgrnhcuhfhorgguuceojhhu lhhirghnfhhorggusegrphgrtghhvgdrohhrgheqnecuffhomhgrihhnpegrphgrtghhvg drohhrghenucfrrghrrghmpehmrghilhhfrhhomhepjhhulhhirghnodhmvghsmhhtphgr uhhthhhpvghrshhonhgrlhhithihqdekgeekkedtjedvtddqudeltddujeduvdekqdhjuh hlihgrnhhfohgrugeppegrphgrtghhvgdrohhrghesfhhorggurdhmvgdruhhknecuvehl uhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 99) id 255A49E3A2; Mon, 28 Jan 2019 12:09:33 -0500 (EST) Message-Id: <1548695373.1103997.1645381592.78B86684@webmail.messagingengine.com> From: Julian Foad To: Sergey Raevskiy Cc: dev@subversion.apache.org MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" X-Mailer: MessagingEngine.com Webmail Interface - ajax-36e4bfd3 Date: Mon, 28 Jan 2019 17:09:33 +0000 Subject: Re: [PATCH] Add '--include' and '--exclude' options to 'svnadmin dump' In-Reply-To: <1543567469.2094417.1594091408.1BA41F63@webmail.messagingengine.com> References: <1543567469.2094417.1594091408.1BA41F63@webmail.messagingengine.com> Ping! Sergey or anyone, are you able to investigate this? Julian Foad wrote on 2018-11-30: > Hello Sergey! > > Your patch was filed as issue #4729 > https://issues.apache.org/jira/browse/SVN-4729 > and released in Subversion 1.10 > > https://subversion.apache.org/docs/release-notes/1.10.html#dump-include-exclude > > A user has reported a problem with this feature. > https://issues.apache.org/jira/browse/SVN-4760 > > It looks like when the source of a copied directory is excluded, it is > only adding the directory itself and not adding the directory's > contents. That sounds to me like a bug -- it is not the behaviour I > would expect. > > I see that the regression tests only test with an empty source directory. > subversion/tests/cmdline/svnadmin_tests.py : dump_exclude_copysource() etc. > > Are you able to investigate this? > > -- > - Julian > > > Sergey Raevskiy wrote on 2016-10-12: > > I've attached a patch that adds '--include/--exclude' options to 'svnadmin > > dump'. These options work similarly to 'svndumpfilter include/exclude' > > but provide proper handling of 'copy from' paths. > > [...]