subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Branko Čibej <br...@apache.org>
Subject Re: [GitHub] subversion pull request #18: Add HTML lang="en"
Date Thu, 24 Jan 2019 11:08:24 GMT
On 24.01.2019 11:55, Julian Foad wrote:
> Branko Čibej wrote:
>> On Wed, 23 Jan 2019, 05:56 skotfred <git@git.apache.org wrote:
>>>      https://github.com/apache/subversion/pull/18
>>>  
>>>      Add HTML lang="en"
>>>  
>>>      Primarily an accessibility concern for screen reader software.
>> Before anyone starts saying that GitHub PR's are the wrong medium for sending patches:
> We should discuss that in another thread. Bearing in mind that "we" (the ASF) set up
that medium, what matters on this thread is that a user kindly offered us a patch.
>
>> the changes themselves are mostly irrelevant, and those that add the "lang" attribute
where it's not allowed by the DTD are actually wrong.
> Could you respond to the user, on github, or would you prefer someone else to?

We should put something there that points to this one of these pages,
and leave it at that:

    https://subversion.apache.org/contributing.html
    https://subversion.apache.org/reporting-issues.html

We have never encouraged throwing patches at us without discussion and I
would be against starting now. If I were to respond there, it would be
to reject the pull request and post one of those links as the reason.
However some people might not agree with such a blunt approach, so I'm
not going to do anything.

I only responded to this thread to point out that the patch is clearly
wrong, or at least most of it is. Which isn't surprising, given that it
was created without any discussion and apparently with very little
attempt at understanding.

-- Brane


Mime
View raw message