From dev-return-38808-archive-asf-public=cust-asf.ponee.io@subversion.apache.org Mon Dec 31 05:16:32 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 3CF7618062A for ; Mon, 31 Dec 2018 05:16:32 +0100 (CET) Received: (qmail 13938 invoked by uid 500); 31 Dec 2018 04:16:30 -0000 Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@subversion.apache.org Received: (qmail 13927 invoked by uid 99); 31 Dec 2018 04:16:29 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 31 Dec 2018 04:16:29 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 64E18C1ACD for ; Mon, 31 Dec 2018 04:16:29 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 2 X-Spam-Level: ** X-Spam-Status: No, score=2 tagged_above=-999 required=6.31 tests=[HEADER_FROM_DIFFERENT_DOMAINS=0.001, HTML_MESSAGE=2, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 2dy9ePeAAVCP for ; Mon, 31 Dec 2018 04:16:27 +0000 (UTC) Received: from mail-yb1-f179.google.com (mail-yb1-f179.google.com [209.85.219.179]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 02C85610FE for ; Mon, 31 Dec 2018 04:16:27 +0000 (UTC) Received: by mail-yb1-f179.google.com with SMTP id e1so5754023ybn.11 for ; Sun, 30 Dec 2018 20:16:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FKOfRLrWFGVxEeWrQamK+OZLAPQhfj5amgl1dpCfOXk=; b=HPTuJQkBXkDTprQ0vp+lpLXz1n9VzsTVvQMn3j5V+lmgH0JzMUCjNCQz5Qb1a4SA7A YdG9EjgkYb22Q61mfBcXYWoHqdMXyLgma7roW1guUEFhTrrMeTVeXYaN+1FCpy9gWPP5 iLc09eOUEJFFGampWsJZhV5Uw5TfdKnS27VuBlwhZQnEoi1ksXgF+qXK+Cw3SAReLvou UjtxMlP3S82Sw3FUg7dk8kLQhbNs34qRjRgi+tx6vtqzGgVtZgK7Rlmp1gG47EFa8+Bl bpjsBcusVmnZRIUFfdQ0M4kFsRbwu1NYM21AriU5Kj3IShuX9sJNVDrz2AsVNEG8FY8Y hRYg== X-Gm-Message-State: AJcUukdjlI3qI/vlOg4zfT4++36Pce1moTeCZfQOQvzqi0EZfJCPQECH XHNIl8Kb/YGTdtm2fDeOwDLVeUrbXqM= X-Google-Smtp-Source: ALg8bN6WxfxfahnAobEIqKNqYT2K5qU9zaT3lJQ/+AX3bZiMhkWppmyJcv0oP+/YoLqfaf3MenMC7A== X-Received: by 2002:a25:cf43:: with SMTP id f64mr24127165ybg.260.1546229779634; Sun, 30 Dec 2018 20:16:19 -0800 (PST) Received: from mail-yw1-f41.google.com (mail-yw1-f41.google.com. [209.85.161.41]) by smtp.gmail.com with ESMTPSA id n65sm16094172ywf.15.2018.12.30.20.16.19 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 30 Dec 2018 20:16:19 -0800 (PST) Received: by mail-yw1-f41.google.com with SMTP id i73so10236370ywg.3 for ; Sun, 30 Dec 2018 20:16:19 -0800 (PST) X-Received: by 2002:a81:3a4f:: with SMTP id h76mr27657792ywa.394.1546229779002; Sun, 30 Dec 2018 20:16:19 -0800 (PST) MIME-Version: 1.0 References: <1542939701.3975740.1586165808.71DB1FCF@webmail.messagingengine.com> <20181123085747.hxlyh2dyc5i6sbwr@tarpaulin.shahaf.local2> <5eb61bdf-be4b-a854-37a3-ab802b0cc0f1@poem.co.jp> <20181128154039.76ksvew7iybufobo@tarpaulin.shahaf.local2> <1544977683.820108.1610663952.7D9615EE@webmail.messagingengine.com> <12cc6d46-c449-3316-a3a2-5cbd6567085f@poem.co.jp> <1352e713-5442-9f49-f133-7acceee828d5@troycurtisjr.com> <8f98f1d1-26af-d822-04ad-6bb51b1c3e3d@apache.org> In-Reply-To: From: Troy Curtis Jr Date: Sun, 30 Dec 2018 23:16:07 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [swig-py3][patch] interfacing bytes object instead of str To: Yasuhito FUTATSUKI Cc: Daniel Shahaf , Subversion Development , futatuki@yf.bsdclub.org Content-Type: multipart/alternative; boundary="000000000000b7fbc6057e49ac06" --000000000000b7fbc6057e49ac06 Content-Type: text/plain; charset="UTF-8" On Fri, Dec 28, 2018 at 8:20 AM Yasuhito FUTATSUKI wrote: > On 12/28/18 4:09 AM, Troy Curtis wrote: > > LGTM, committed as r1849804, but without the unnecessary gymnastics to > continue supporting str() in those two cases mentioned above. I also > tweaked the log message to use complete sentences (and removed references > to the code that I didn't include). > > Thank you for correct my broken log message. > > As the second step of follow up r1849784, I've fixed #if blocks usage > in subversion/bindings/swig/python/libsvn_swig_py/swigutil_py.c because > it is obvious and it doesn't contain any functional change. > > follow up r189784: fix macro usage to distinguish py2 and py3 context > > * subversion/bindings/swig/python/libsvn_swig_py/swigutil_py.c > Include "swigutil_py3c.h" file before define SVN_SWIG_BYTES_FMT to use > IS_PY3 macro to switch py2 and py3 context > (add_directory, add_file, apply_textdelta, change_file_prop, > close_file, parse_fn3_set_revision_property, > parse_fn3_set_node_property, svn_swig_py_notify_func, > svn_swig_py_notify_func, svn_swig_py_delta_path_driver_cb_func, > svn_swig_py_repos_authz_func, svn_swig_py_log_receiver, > svn_swig_py_client_blame_receiver_func, > svn_swig_py_changelist_receiver_func, > svn_swig_py_auth_simple_prompt_func, > svn_swig_py_config_auth_walk_func, > ra_callbacks_get_wc_prop, ra_callbacks_push_or_set_wc_prop, > ra_callbacks_invalidate_wc_props, svn_swig_py_commit_callback, > reporter_set_path, reporter_link_path, > wc_diff_callbacks2_file_changed_or_added, > wc_diff_callbacks2_file_deleted, wc_diff_callbacks2_dir_added, > wc_diff_callbacks2_dir_props_changed, > svn_swig_py_config_enumerator2): > Use IS_PY3 macro instead of comparison of PY_VERSION_HEX > (add_directory, add_file, apply_textdelta, change_file_prop, > close_file, parse_fn3_set_revision_property, > parse_fn3_set_node_property, ra_callbacks_get_wc_prop, > ra_callbacks_push_or_set_wc_prop, ra_callbacks_invalidate_wc_props): > Enclose only format argument of Py_CallFunction or Py_CallMethod > with #if IS_PY3 #else #endif block > Great! LGTM, committed as r1850011. > Cheers, > -- Yasuhito FUTATSUKI > Troy --000000000000b7fbc6057e49ac06 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Fri, Dec 28, 2018 at = 8:20 AM Yasuhito FUTATSUKI <futat= uki@poem.co.jp> wrote:
On 12/28/18 4:09 AM, Troy Curtis wrote:
> LGTM, committed as r1849804, but without the unnecessary gymnastics to= continue supporting str() in those two cases mentioned above. I also tweak= ed the log message to use complete sentences (and removed references to the= code that I didn't include).

Thank you for correct my broken log message.

As the second step of follow up r1849784, I've fixed #if blocks usage in subversion/bindings/swig/python/libsvn_swig_py/swigutil_py.c because
it is obvious and it doesn't contain any functional change.

follow up r189784: fix macro usage to distinguish py2 and py3 context

* subversion/bindings/swig/python/libsvn_swig_py/swigutil_py.c
=C2=A0 =C2=A0Include "swigutil_py3c.h" file before define SVN_SWI= G_BYTES_FMT to use
=C2=A0 =C2=A0IS_PY3 macro to switch py2 and py3 context
=C2=A0 =C2=A0(add_directory, add_file, apply_textdelta, change_file_prop, =C2=A0 =C2=A0 close_file, parse_fn3_set_revision_property,
=C2=A0 =C2=A0 parse_fn3_set_node_property, svn_swig_py_notify_func,
=C2=A0 =C2=A0 svn_swig_py_notify_func, svn_swig_py_delta_path_driver_cb_fun= c,
=C2=A0 =C2=A0 svn_swig_py_repos_authz_func, svn_swig_py_log_receiver,
=C2=A0 =C2=A0 svn_swig_py_client_blame_receiver_func,
=C2=A0 =C2=A0 svn_swig_py_changelist_receiver_func,
=C2=A0 =C2=A0 svn_swig_py_auth_simple_prompt_func,
=C2=A0 =C2=A0 svn_swig_py_config_auth_walk_func,
=C2=A0 =C2=A0 ra_callbacks_get_wc_prop, ra_callbacks_push_or_set_wc_prop, =C2=A0 =C2=A0 ra_callbacks_invalidate_wc_props, svn_swig_py_commit_callback= ,
=C2=A0 =C2=A0 reporter_set_path, reporter_link_path,
=C2=A0 =C2=A0 wc_diff_callbacks2_file_changed_or_added,
=C2=A0 =C2=A0 wc_diff_callbacks2_file_deleted, wc_diff_callbacks2_dir_added= ,
=C2=A0 =C2=A0 wc_diff_callbacks2_dir_props_changed,
=C2=A0 =C2=A0 svn_swig_py_config_enumerator2):
=C2=A0 =C2=A0 =C2=A0Use IS_PY3 macro instead of comparison of PY_VERSION_HE= X
=C2=A0 =C2=A0(add_directory, add_file, apply_textdelta, change_file_prop, =C2=A0 =C2=A0 close_file, parse_fn3_set_revision_property,
=C2=A0 =C2=A0 parse_fn3_set_node_property, ra_callbacks_get_wc_prop,
=C2=A0 =C2=A0 ra_callbacks_push_or_set_wc_prop, ra_callbacks_invalidate_wc_= props):
=C2=A0 =C2=A0 =C2=A0Enclose only format argument of Py_CallFunction or Py_C= allMethod
=C2=A0 =C2=A0 =C2=A0with #if IS_PY3 #else #endif block

Great! LGTM, committed as r1850011.


Cheers,
-- =C2=A0
Yasuhito FUTATSUKI

Troy
--000000000000b7fbc6057e49ac06--