From dev-return-38720-archive-asf-public=cust-asf.ponee.io@subversion.apache.org Thu Dec 13 16:43:00 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 01E0D180609 for ; Thu, 13 Dec 2018 16:42:59 +0100 (CET) Received: (qmail 72728 invoked by uid 500); 13 Dec 2018 15:42:59 -0000 Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@subversion.apache.org Received: (qmail 72716 invoked by uid 99); 13 Dec 2018 15:42:58 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 13 Dec 2018 15:42:58 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id E0744C8B87 for ; Thu, 13 Dec 2018 15:42:57 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.202 X-Spam-Level: X-Spam-Status: No, score=-0.202 tagged_above=-999 required=6.31 tests=[DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id 1IE2ty17fkXt for ; Thu, 13 Dec 2018 15:42:56 +0000 (UTC) Received: from mail-vs1-f47.google.com (mail-vs1-f47.google.com [209.85.217.47]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id 925F361070 for ; Thu, 13 Dec 2018 15:42:56 +0000 (UTC) Received: by mail-vs1-f47.google.com with SMTP id g68so1417389vsd.11 for ; Thu, 13 Dec 2018 07:42:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lFAPbP73zYHRfcMm97CCu8ekTSRDL7dEnuC7Dl/V9iw=; b=GnQBWbtEpuXHQfArsT0k4ZCtmXoIpZnp+hjKqOqn18V2mL4qS0djZFDPBj1ZiZZEW/ vVRb0TJEKikBCphp9R/JMkg/u+42MjT4hRIYdySfPczgXpSWDpE4a3Q2bt6S7RcGBwEa xZZ0lBW2J43q9Uh7GGzWYn8g1UE8D8yy+PJN7DB6wVua1Ags1cQyBOAMlmn+8qYV3SJT yCjqgqO9O6CEJGcwYkCrhHX8jnOIGyK6Egoq4ALm9tkqR68bFTb64mVpbOMneUEwMH6g su2/AerQCoqBawBSOTCKPW6Uzgjo59tTlqlnRHue61HZZQm+HREo9XbNjTLJi7HWA5dL IKIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lFAPbP73zYHRfcMm97CCu8ekTSRDL7dEnuC7Dl/V9iw=; b=HgBFKOb4YGzOIbBIIvpQREMnlJPlojb3lTbLxdQ9t35838BKXMIhnMpYG8I/KpXY0k 9tcbf3+kqYsenSF8wm+vc3P0XCOVM1nPtqT7miHrjsJVfk2wByCrDofWzxrrvtwAg6s0 egyMRAdqvQpT4XdRI6rpApZDXNNQriAGRk85guaEEDKEnqZWR93P2Ghs01Ghll82k7TP Y3N3xG0OK8qEdr9pqR/5Km+cEB54c/GN7uecyaCDzdOM5ufEDLWBDjpc5zqZaaCbfK2w g0foWwZeqBDEJCe9VTuM3GEgx02uOtWvYeJCFIMMuOeVRXpGyrV4LBP9Lvxzf75sZ9P5 qfAQ== X-Gm-Message-State: AA+aEWYdikrK66AgJzcQ8cFTfKf8lnmOwc01wtlORb4VxBTfMV1i7EuE X8610NkfSEGjVBNjwnvlzrgxb6sb8+anlf1/BNE= X-Google-Smtp-Source: AFSGD/WTB0qWRVx9KgoAEmg61p2KOPA3PbIU2Jcnjobjl4iz2tMJNhewbq8j3honbOb98hDD3Mevi2qefzwxY5k1UTI= X-Received: by 2002:a67:7d06:: with SMTP id y6mr11670183vsc.22.1544715775699; Thu, 13 Dec 2018 07:42:55 -0800 (PST) MIME-Version: 1.0 References: <89de5509-04b7-2dc6-cfa4-7f55edf62282@apache.org> <1e53afe3-947a-a7a6-848c-1eae397fea68@gmail.com> <1544649829.433922.1607507080.5C9EC775@webmail.messagingengine.com> <1544713530.3935559.1608222856.3F4F26D0@webmail.messagingengine.com> In-Reply-To: <1544713530.3935559.1608222856.3F4F26D0@webmail.messagingengine.com> From: Johan Corveleyn Date: Thu, 13 Dec 2018 16:42:43 +0100 Message-ID: Subject: Re: Subversion Exception! To: Julian Foad Cc: Subversion Development , =?UTF-8?B?U3RlZmFuIEvDvG5n?= , Daniel Shahaf Content-Type: text/plain; charset="UTF-8" On Thu, Dec 13, 2018 at 4:05 PM Julian Foad wrote: > > Johan Corveleyn wrote: > > Just thinking out loud here, but could we perhaps log the > > non-canonical value as part of the assertion output? > > [...] > > something like > > > > line 10238: assertion failed > > (svn_dirent_is_absolute(local_abspath='C:ImNotCanonical')) > > Yes, Johan, we could do that. > > The attached patch demonstrates it working. > > Test output: > [[[ > $ subversion/tests/libsvn_wc/wc-test 1 > ... > svn_tests: E235000: In file '.../subversion/libsvn_wc/wc_db.c' line 10238: assertion failed (svn_dirent_is_absolute(local_abspath='C:ImNotAbsolute')) > ... > ]]] Nice :-). I'm not sure what others think, but IMHO that would make these error reports a lot more useful ... -- Johan