From dev-return-38772-archive-asf-public=cust-asf.ponee.io@subversion.apache.org Mon Dec 17 14:10:16 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 5F159180652 for ; Mon, 17 Dec 2018 14:10:16 +0100 (CET) Received: (qmail 97265 invoked by uid 500); 17 Dec 2018 13:10:15 -0000 Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@subversion.apache.org Received: (qmail 97246 invoked by uid 99); 17 Dec 2018 13:10:14 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 Dec 2018 13:10:14 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 70ECB180A7D for ; Mon, 17 Dec 2018 13:10:14 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.002 X-Spam-Level: X-Spam-Status: No, score=-0.002 tagged_above=-999 required=6.31 tests=[SPF_HELO_PASS=-0.001, SPF_PASS=-0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id km6bFDzO0uGX for ; Mon, 17 Dec 2018 13:10:13 +0000 (UTC) Received: from poem.co.jp (sv.poem.co.jp [124.35.235.17]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 2CE8A5F570 for ; Mon, 17 Dec 2018 13:10:11 +0000 (UTC) Received: from air-alpha.yf.bsdclub.org (du.poem.co.jp [124.35.235.5]) (authenticated bits=0) by poem.co.jp (8.13.8/8.13.8) with ESMTP id wBH49ueC011630 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 17 Dec 2018 13:09:58 +0900 Subject: Re: [swig-py3][patch] interfacing bytes object instead of str To: Daniel Shahaf Cc: Troy Curtis Jr , Subversion Development , futatuki@yf.bsdclub.org References: <1542939701.3975740.1586165808.71DB1FCF@webmail.messagingengine.com> <20181123085747.hxlyh2dyc5i6sbwr@tarpaulin.shahaf.local2> <5eb61bdf-be4b-a854-37a3-ab802b0cc0f1@poem.co.jp> <20181128154039.76ksvew7iybufobo@tarpaulin.shahaf.local2> <1544977683.820108.1610663952.7D9615EE@webmail.messagingengine.com> <12cc6d46-c449-3316-a3a2-5cbd6567085f@poem.co.jp> <20181217093511.qwbirjbrbahz2jkp@tarpaulin.shahaf.local2> From: futatuki@poem.co.jp Message-ID: <957c52e9-4672-2f93-c796-ca568a283429@poem.co.jp> Date: Mon, 17 Dec 2018 22:09:56 +0900 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20181217093511.qwbirjbrbahz2jkp@tarpaulin.shahaf.local2> Content-Type: text/plain; charset=iso-2022-jp; format=flowed; delsp=yes Content-Language: en-US Content-Transfer-Encoding: 7bit On 12/17/18 18:35, Daniel Shahaf wrote: > Yasuhito FUTATSUKI wrote on Mon, Dec 17, 2018 at 05:50:03 +0900: >> On 12/17/18 2:08 AM, Troy Curtis Jr wrote: >>> On Sun, Dec 16, 2018 at 11:28 AM Daniel Shahaf >>> wrote: >>> >>>> Troy Curtis Jr wrote on Sun, 16 Dec 2018 09:59 -0500: >>>>> But there was one item I wanted to talk about related to the patch. I >>>>> agree that "svn_stringbuf_t" => "bytes" and "svn_string_t" => "str" is the >>>>> right general path, > > Would svn_stringbuf_t map better to bytearray? Sorry, that didn't occur > to me yesterday. I think if proxy object for svn_stringbuf_t can support buffer protocol, no need to translate to bytes object for return values, however, for input values, it is still need to translation to svn_stringbuf_t with entity copy except proxy objects. (I already agreed that propety values should be mapped to bytes objects, so I ommit latter half.) Cheers, -- Yasuhito FUTATSUKI