From dev-return-38714-archive-asf-public=cust-asf.ponee.io@subversion.apache.org Wed Dec 12 21:47:24 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 4A98A180679 for ; Wed, 12 Dec 2018 21:47:24 +0100 (CET) Received: (qmail 62608 invoked by uid 500); 12 Dec 2018 20:47:23 -0000 Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@subversion.apache.org Received: (qmail 62591 invoked by uid 99); 12 Dec 2018 20:47:23 -0000 Received: from mail-relay.apache.org (HELO mailrelay2-lw-us.apache.org) (207.244.88.137) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 12 Dec 2018 20:47:23 +0000 Received: from [172.17.13.1] (unknown [77.234.149.122]) by mailrelay2-lw-us.apache.org (ASF Mail Server at mailrelay2-lw-us.apache.org) with ESMTPSA id C90A0AF2; Wed, 12 Dec 2018 20:47:21 +0000 (UTC) Subject: Re: Subversion Exception! To: Stefan Kueng , TortoiseSVN-dev on behalf of Julian Foad , dev@subversion.apache.org References: <89de5509-04b7-2dc6-cfa4-7f55edf62282@apache.org> <1e53afe3-947a-a7a6-848c-1eae397fea68@gmail.com> From: =?UTF-8?Q?Branko_=c4=8cibej?= Openpgp: preference=signencrypt Autocrypt: addr=brane@apache.org; prefer-encrypt=mutual; keydata= xsFNBFG3qpMBEACi+jRQDd2TiYeAxVgrLZ3cyyuGOFSMh4nCyUOG9BwXC69cDLH48RcE0Mpu TFTGlfdokz6JgLKU3uqShPXiflrL6JIVnJX4rTEKRzFNkcS6Zq0PfNRnFnkwiD2KIzyAG8XE y0c1Bt7hqZ5dfXaC1b7Xo+1cnlqjdLAOnr1ruTrtfQ5sO81p9jYtARVa+iVmf8bs/FvC9Yn2 QtEDtuUfUUHx2bnB9vmh8tOjErfIcWtzCPt8uTUkmiszlkRMiB5/X97oqXlX/5dSQWE9m4M5 6Fc9ixIrmCwkF515RLrCNTv/YAtmpu4VaB0rxgTuSku0cVk83xSMrH2hNFx1fAeYBZpwp2GL ONlTy3D2N+BjWXjEUE9baGOoYM7QUbAdj4JMstSByppaAi4AiG9+raxknTWtWt2IT9LHW7Pu i6S3k4WL5jmTdQKqNQ9/+vRqiSVsA98yHQLa+s19IYh4F7WIfo2lzBAn06HEntpKS9TtV20o JyMBLOVqQP1dARWRfB0xIxGtbI61CfjEhCeG8H+UynCrHkUxgUoKsXXkI/JxsIMZ3TivFj3U MJVur7KVwg/isqqaEyMfUnCrXJxexZp8kuTjkzzvDKfYs0vHJezPQYhlqBLkK2w9VzktGjA7 lb+TO69bEyPOcBjVsCtrdYVc442/Z37G+1UV5+1X06m14Pt9UQARAQABzSBCcmFua28gxIxp YmVqIDxicmFuZUBhcGFjaGUub3JnPsLBegQTAQoAJAIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgAUCUbetMwIZAQAKCRAbymWGo0eUP2tOD/9KOLYfxwTcGV/Nj3lnKE4Y4gRl0r4cfnWm 1/2KyPYVsmQ8vWRUZxjuVHAvZrAkTBvlu+CVzrCWEEpCzQC/jki0xkPQchTEU2XOHQ6PzkXB 17o1NSSu/vyKynh0pXMRTHm4wZodzUw/tHn/Ism5QyRyhlYUP4mVX8v2hbN+stkJHrkdVBPm FspnFidhulUP5hr+LWz2qd+Ab8MOn3+x25jsGE8yaUiqmNdrmq/trvHPGThySa4Hz0uEkhfP K2knc6PpV5GTbeRn/J1eu17xVgXYVgko35Qwz5s/LRat+5R79tgBAL9SKFybCVBPr6/1Zp4u w9b0NcHW6t3aQHCxv8iEqxrJ7UIDhh/hXh4no0vzpPR1Cgjn6fK997WrpUyaAtlnbSH5QGad YY9rpFka3o2Gj+f+cr75hq6c7DnNJo94eGw9L0JEjfgordi8UkWErGOklnGf8N8brlVG0TdW 7KOz60m1E3UzIwd2lQd9a0zd8Mqrmn2MMPdJt4EpKQWaJsoK+FOdEBX0Ezm3StEXufe1IOG9 DihVcOnsx/G6aTS9GyKjURVt0jDB4wsVSzsRHYHmQpw7/ekvHFNKZS5yMNwSt2X/Szmk4GmV 69gaI79kf8VD87xwE31p0s0uVIVp7MTOTEYT5HUh5Rz6Rr66+vg9qgN1enMj5sh4f8krXgRR wM7BTQRRt6qTARAAnxIdGqDTC2FU9AE2ElT/m/Hs/57BwqUUb8qod3mJ6Qkp7PpHCBnvtbwm krrCsJl5rR1fliton6qoJUNCSfmcfeujcU8Be+q75rNZxIWi6AjMmyrjyMp9JIO7g/7+VYmL dm9c1wRn4QDnIKxl7qMPz9q8/OF6BGEMEW4zRL8rHvM7CCapOikHUKKq7GnZMVyYbue6KUTA Tczxjt6E9Av1QDnnW9zbW56jqUKdgpNek/bSTuef2xYEDzIzFPQREyw8E/C3xx8zZfOJ0+XV s1n39GLp3vugP5IBNE2pgqcyFtKISj1pVJgDr7zXjD92ZGS8xgqDxePTuf1LcCwd65BJNVVK IFsFicvBVhdslCZ7l8jkCuZAzYoFJZthUKuuJg1n7HYi8XLifZmun9Z3fbM5gk9/vA1rXsWt An597BACKDUkWA5tOb3Si4/MaRDiZYvzplHGc4sTn4aBIj3VFGGFNlOUPFLWjZLHdudNOBGj 3eIlz/DQZh/mwNGn5g98c3xehHnWxcXa0PsN2Xl1iRM2dec8drEVVRYaWPcOmGhKfqnlwl2z OeuST2TMcWhxKshVimR9eSt5pX1oGOD9PZ9V0gQDIr4d35UjQaW5ABCWbgTd7e3yPTlHoWx4 qyv+YoxEf6AlQ4nvE+q1s4wRBs/eNVQsROnYmhKhYPZUsDE6EocAEQEAAcLBXwQYAQoACQUC UbeqkwIbDAAKCRAbymWGo0eUPwd6D/92i5LBHSluiBdnzYH3kYlkIMjhy3lcqtxb/TWV1X/z CVpaZkEXvL9NQ44ZqfiOFB8fnaJvy+9rfIL3MwHKLVHOjsurBRP2DJ8H/EI6QuZV//Nxh66A dicXlE5SSiKQ5KcIH+eqZHa4XjVeXGeNZummrlhOv3ItKXETVhh2qeIQ/7zCjuw5rQk606+2 isg6cs4Nwtie1rXQ1KFtkTNQqWfqyM4PrEP9Bq5pWBQVkcxDsxk1Yj3A8L80IY3Hzwm8nRlq F+HkD/0IPgHICVDyiOB4XZtqVk+DHNOolCcdrFSXOcwt+qwD5zk4p0hdHKHagAPGBDXS8shm k2vaUDbKMUoVDdj579Jtp4tNOoVEEqqXspT995w7+ckbHGoQhFlSxCwtaXCr/8wwdwcCA2eO w0aLYrU04EbnH7Ryj4aTjsBGvJdmyZQT8/lTj5VARbEkNXTdTOs61pebDliyWtcF9Uz9b44p cLNniphcBO4SP/IMlEh8pBAJ1C2QlD4G90iJ1WK0MsJsUDix9Vb5s1AE6WA/Ss1iPCOdhhif eToCAwoobIipoxUZF2ik3oESskmMDolpVBiaPaFg+YPtNp/53dLap7jBNRNgyKXaGJAZaolp L+9hCU1EOWswqusDHDFSRUuYOXfuXZJxcbQUTnhQhRbvSDy3tDMRGd252Ur1sCOU5g== Organization: The Apache Software Foundation Message-ID: <94532b4c-57ca-95b3-6842-fd8d50a6ad4b@apache.org> Date: Wed, 12 Dec 2018 21:47:20 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1e53afe3-947a-a7a6-848c-1eae397fea68@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-GB On 12.12.2018 21:16, Stefan Kueng wrote: > > > On 12.12.2018 21:12, Branko Čibej wrote: >> On 12.12.2018 19:07, Stefan Kueng wrote: >>> >>> >>> On 12.12.2018 13:55, TortoiseSVN-dev on behalf of Julian Foad wrote: >>>>>> Subversion encountered a serious problem. >>>>>> Please take the time to report this on the Subversion mailing list >>>> […] >>>>>> https://subversion.apache.org/mailing-lists.html >>>> >>>>> It is likely that this is a problem specific to TortoiseSVN, and not >>>>> to core SVN. TortoiseSVN has its own mailinglists, so you should >>>>> report your problem there: >>>> (Cross-posting.) >>> >>> Since this happens in the project monitor, my best guess is that the >>> path/url the user entered to be monitored is not correct. >>> >>>> >>>> It makes me sad every time I see this pattern. Software is often >>>> frustrating to use, but should at least aim to be polite to its >>>> users. Telling the user "Please do X" and then when the user does X >>>> saying "No, it's no good doing X; do Y" is not polite, and I would >>>> not expect anyone but the most calm, patient and helpful of users to >>>> gracefully comply with such a request. >>>> >>>> I'm not meaning to criticise Johan but rather our whole system. >>>> >>>> Can we please fix this problem. Both: >>>> 1) Tsvn please change the message. >>> >>> Sorry, won't do that. Because I've argued multiple times over the >>> years here that calling exit() or even abort() in a library is the >>> worst idea ever. Especially if this can happen by having the user >>> enter a wrong path/url. >> >> >> It's not the user entering the wrong path or URL. It's the code that >> uses the Subversion libraries — in this case TSVN — not validating and >> de-tainting its input. Yes, this has been going on for years due to your > > And as I repeatedly said: TSVN does validate the input as good as it > can. But if svn does neither describe the *exact* specs in the docs > nor provide any APIs that do that, then TSVN has to guess. > And no: specifying that paths/uris have to be "canonicalized" is not > enough because I do that, using the svn APIs. > So apparently that's not enough. Get one of the dumps the crash reporter is supposed to generate, then show us a stack trace that shows there's a bug in the Subversion code, and you'll get results. Waxing philosophical about how you believe a library should behave is not productive. These silly "Subversion Exception" mails are no help at all, they provide exactly *zero* information on which anyone can act. And your refusal to direct TSVN users to TSVN support lists is just bloody annoying and hence also not productive. If there is a bug in our code, which of course is possible, we can do exactly nothing about it given the amount of info we have. Oh by the way, I doubt this had anything to do with user input, as the OP states: > got following exception at trying to start the tortoisesvn Project > Monitor with a doubleclick on the tray icon. -- Brane P.S.: I keep wondering where these crash reports from all the other Subversion clients out there are going. We don't seem to be seeing (m)any.