From dev-return-38780-archive-asf-public=cust-asf.ponee.io@subversion.apache.org Wed Dec 19 00:53:20 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id D5990180669 for ; Wed, 19 Dec 2018 00:53:19 +0100 (CET) Received: (qmail 91522 invoked by uid 500); 18 Dec 2018 23:53:18 -0000 Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@subversion.apache.org Received: (qmail 91512 invoked by uid 99); 18 Dec 2018 23:53:18 -0000 Received: from mail-relay.apache.org (HELO mailrelay1-lw-us.apache.org) (207.244.88.152) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Dec 2018 23:53:18 +0000 Received: from [172.23.17.71] (89-233-126-4.dynamic.t-2.net [89.233.126.4]) by mailrelay1-lw-us.apache.org (ASF Mail Server at mailrelay1-lw-us.apache.org) with ESMTPSA id BE4CB1050 for ; Tue, 18 Dec 2018 23:53:16 +0000 (UTC) Subject: Re: Problems accessing GitHub's SVN-bridge with SVN 1.11 To: dev@subversion.apache.org References: <1759573844.20181104160551@am-soft.de> <1754014200.20181104164211@am-soft.de> <1544300284.20181104170645@am-soft.de> <95e1dd9a-ea8b-c70f-42bb-db09a447f738@apache.org> <455835768.20181104185710@am-soft.de> <223869ad-94a0-2857-abdb-b5eed82669c3@apache.org> <509782c2-1233-6f5c-2c5f-32c795dfe657@apache.org> <87b49809-97e9-b81c-592f-be996f00a67a@apache.org> From: =?UTF-8?Q?Branko_=c4=8cibej?= Openpgp: preference=signencrypt Autocrypt: addr=brane@apache.org; prefer-encrypt=mutual; keydata= mQINBFG3qpMBEACi+jRQDd2TiYeAxVgrLZ3cyyuGOFSMh4nCyUOG9BwXC69cDLH48RcE0Mpu TFTGlfdokz6JgLKU3uqShPXiflrL6JIVnJX4rTEKRzFNkcS6Zq0PfNRnFnkwiD2KIzyAG8XE y0c1Bt7hqZ5dfXaC1b7Xo+1cnlqjdLAOnr1ruTrtfQ5sO81p9jYtARVa+iVmf8bs/FvC9Yn2 QtEDtuUfUUHx2bnB9vmh8tOjErfIcWtzCPt8uTUkmiszlkRMiB5/X97oqXlX/5dSQWE9m4M5 6Fc9ixIrmCwkF515RLrCNTv/YAtmpu4VaB0rxgTuSku0cVk83xSMrH2hNFx1fAeYBZpwp2GL ONlTy3D2N+BjWXjEUE9baGOoYM7QUbAdj4JMstSByppaAi4AiG9+raxknTWtWt2IT9LHW7Pu i6S3k4WL5jmTdQKqNQ9/+vRqiSVsA98yHQLa+s19IYh4F7WIfo2lzBAn06HEntpKS9TtV20o JyMBLOVqQP1dARWRfB0xIxGtbI61CfjEhCeG8H+UynCrHkUxgUoKsXXkI/JxsIMZ3TivFj3U MJVur7KVwg/isqqaEyMfUnCrXJxexZp8kuTjkzzvDKfYs0vHJezPQYhlqBLkK2w9VzktGjA7 lb+TO69bEyPOcBjVsCtrdYVc442/Z37G+1UV5+1X06m14Pt9UQARAQABtCBCcmFua28gxIxp YmVqIDxicmFuZUBhcGFjaGUub3JnPokCOgQTAQoAJAIbAwULCQgHAwUVCgkICwUWAgMBAAIe AQIXgAUCUbetMwIZAQAKCRAbymWGo0eUP2tOD/9KOLYfxwTcGV/Nj3lnKE4Y4gRl0r4cfnWm 1/2KyPYVsmQ8vWRUZxjuVHAvZrAkTBvlu+CVzrCWEEpCzQC/jki0xkPQchTEU2XOHQ6PzkXB 17o1NSSu/vyKynh0pXMRTHm4wZodzUw/tHn/Ism5QyRyhlYUP4mVX8v2hbN+stkJHrkdVBPm FspnFidhulUP5hr+LWz2qd+Ab8MOn3+x25jsGE8yaUiqmNdrmq/trvHPGThySa4Hz0uEkhfP K2knc6PpV5GTbeRn/J1eu17xVgXYVgko35Qwz5s/LRat+5R79tgBAL9SKFybCVBPr6/1Zp4u w9b0NcHW6t3aQHCxv8iEqxrJ7UIDhh/hXh4no0vzpPR1Cgjn6fK997WrpUyaAtlnbSH5QGad YY9rpFka3o2Gj+f+cr75hq6c7DnNJo94eGw9L0JEjfgordi8UkWErGOklnGf8N8brlVG0TdW 7KOz60m1E3UzIwd2lQd9a0zd8Mqrmn2MMPdJt4EpKQWaJsoK+FOdEBX0Ezm3StEXufe1IOG9 DihVcOnsx/G6aTS9GyKjURVt0jDB4wsVSzsRHYHmQpw7/ekvHFNKZS5yMNwSt2X/Szmk4GmV 69gaI79kf8VD87xwE31p0s0uVIVp7MTOTEYT5HUh5Rz6Rr66+vg9qgN1enMj5sh4f8krXgRR wLkCDQRRt6qTARAAnxIdGqDTC2FU9AE2ElT/m/Hs/57BwqUUb8qod3mJ6Qkp7PpHCBnvtbwm krrCsJl5rR1fliton6qoJUNCSfmcfeujcU8Be+q75rNZxIWi6AjMmyrjyMp9JIO7g/7+VYmL dm9c1wRn4QDnIKxl7qMPz9q8/OF6BGEMEW4zRL8rHvM7CCapOikHUKKq7GnZMVyYbue6KUTA Tczxjt6E9Av1QDnnW9zbW56jqUKdgpNek/bSTuef2xYEDzIzFPQREyw8E/C3xx8zZfOJ0+XV s1n39GLp3vugP5IBNE2pgqcyFtKISj1pVJgDr7zXjD92ZGS8xgqDxePTuf1LcCwd65BJNVVK IFsFicvBVhdslCZ7l8jkCuZAzYoFJZthUKuuJg1n7HYi8XLifZmun9Z3fbM5gk9/vA1rXsWt An597BACKDUkWA5tOb3Si4/MaRDiZYvzplHGc4sTn4aBIj3VFGGFNlOUPFLWjZLHdudNOBGj 3eIlz/DQZh/mwNGn5g98c3xehHnWxcXa0PsN2Xl1iRM2dec8drEVVRYaWPcOmGhKfqnlwl2z OeuST2TMcWhxKshVimR9eSt5pX1oGOD9PZ9V0gQDIr4d35UjQaW5ABCWbgTd7e3yPTlHoWx4 qyv+YoxEf6AlQ4nvE+q1s4wRBs/eNVQsROnYmhKhYPZUsDE6EocAEQEAAYkCHwQYAQoACQUC UbeqkwIbDAAKCRAbymWGo0eUPwd6D/92i5LBHSluiBdnzYH3kYlkIMjhy3lcqtxb/TWV1X/z CVpaZkEXvL9NQ44ZqfiOFB8fnaJvy+9rfIL3MwHKLVHOjsurBRP2DJ8H/EI6QuZV//Nxh66A dicXlE5SSiKQ5KcIH+eqZHa4XjVeXGeNZummrlhOv3ItKXETVhh2qeIQ/7zCjuw5rQk606+2 isg6cs4Nwtie1rXQ1KFtkTNQqWfqyM4PrEP9Bq5pWBQVkcxDsxk1Yj3A8L80IY3Hzwm8nRlq F+HkD/0IPgHICVDyiOB4XZtqVk+DHNOolCcdrFSXOcwt+qwD5zk4p0hdHKHagAPGBDXS8shm k2vaUDbKMUoVDdj579Jtp4tNOoVEEqqXspT995w7+ckbHGoQhFlSxCwtaXCr/8wwdwcCA2eO w0aLYrU04EbnH7Ryj4aTjsBGvJdmyZQT8/lTj5VARbEkNXTdTOs61pebDliyWtcF9Uz9b44p cLNniphcBO4SP/IMlEh8pBAJ1C2QlD4G90iJ1WK0MsJsUDix9Vb5s1AE6WA/Ss1iPCOdhhif eToCAwoobIipoxUZF2ik3oESskmMDolpVBiaPaFg+YPtNp/53dLap7jBNRNgyKXaGJAZaolp L+9hCU1EOWswqusDHDFSRUuYOXfuXZJxcbQUTnhQhRbvSDy3tDMRGd252Ur1sCOU5g== Organization: The Apache Software Foundation Message-ID: <4716eb89-8182-3be1-a672-fdc3ea91ef84@apache.org> Date: Wed, 19 Dec 2018 00:53:13 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.3.3 MIME-Version: 1.0 In-Reply-To: <87b49809-97e9-b81c-592f-be996f00a67a@apache.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: sl On 15.11.2018 21:18, Branko Čibej wrote: > On 15.11.2018 17:27, Branko Čibej wrote: >> [Moved from users@] >> >> On 06.11.2018 19:16, Branko Čibej wrote: >>> On 04.11.2018 20:11, Branko Čibej wrote: >>>> On 04.11.2018 18:57, Thorsten Schöning wrote: >>>>> Guten Tag Branko Čibej, >>>>> am Sonntag, 4. November 2018 um 17:47 schrieben Sie: >>>>> >>>>>> I'm not sure what you mean by "handles more than only DAV successfully" >>>>> I thought it might be possible that GitHub answers differently but >>>>> properly, because the other check mentioned something about HTTP v2. >>>>> Because of TLS, I was unable to look at the requests and responses >>>>> then, but it's like you said, they don't provide DAV-headers in their >>>>> response to OPTION. >>>>> >>>>>> And yes, the HTTP/DAV specification requires that header to be present >>>>>> in the response. >>>>> Which you didn't care about before and things worked for some years >>>>> for some users. >>>> We made this change because users complained about unhelpful error >>>> messages when they tried to connect to a server that did not even >>>> implement HTTP/DAV. The error message was "Malformed XML in response" >>>> which wasn't exactly helpful for diagnosing the problem. >>>> >>>> I admit I didn't have GitHub in mind when I added this check. ... >>> I added a test case to our suite that tries the following command: >>> >>> svn info https://github.com/apache/subversion/trunk >>> >>> >>> It runs on one of our build slaves, so we'll know fairly soon when (if) >>> GitHub deploys a fix. And, of course, we'll also know if this feature >>> breaks again in future. >>> >>> http://svn.apache.org/r1845942 >> I created SVN-4789 to track this and added a patch with a possible fix. >> I did not commit it because it contains what is, in my opinion, a really >> horrible hack; but it does let our client work against >> https://github.com again. I would very much prefer that GitHub adds that >> trivial one-liner fix to their bridge implementation. However, if this >> issue persists and prevents users from migrating to 1.11.x and later, we >> may have to use this hack under protest. Note that it is in some ways >> similar to the now-defunct ASP.NET hack. >> >> [[[ >> Hack ra_serf to work with GitHub's bridge again. >> >> * subversion/libsvn_ra_serf/options.c >> (options_context_t): New member 'received_github_request_id_header'. >> (capabilities_headers_iterator_callback): Check if we received that header. >> (options_response_handler): Allow DAV responses without DAV headers, if >> the 'X-GitHub-Request-Id' header is present. >> >> * subversion/tests/cmdline/dav_tests.py >> (connect_to_github_server): >> Remove the @XFail annotation. Add an @Issue annotation. >> Change the test URL to point at HTTPd's GitHub mirror. >> >> Issue: SVN-4789 >> ]]] > Actually the attached updated patch is a bit more to my taste. This has been resolved by GitHub. -- Brane