From dev-return-38771-archive-asf-public=cust-asf.ponee.io@subversion.apache.org Mon Dec 17 13:48:00 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 2949D180652 for ; Mon, 17 Dec 2018 13:47:59 +0100 (CET) Received: (qmail 60656 invoked by uid 500); 17 Dec 2018 12:47:59 -0000 Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@subversion.apache.org Received: (qmail 60646 invoked by uid 99); 17 Dec 2018 12:47:59 -0000 Received: from mail-relay.apache.org (HELO mailrelay1-lw-us.apache.org) (207.244.88.152) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 Dec 2018 12:47:59 +0000 Received: from auth2-smtp.messagingengine.com (auth2-smtp.messagingengine.com [66.111.4.228]) by mailrelay1-lw-us.apache.org (ASF Mail Server at mailrelay1-lw-us.apache.org) with ESMTPSA id 6F1CF103F for ; Mon, 17 Dec 2018 12:47:58 +0000 (UTC) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailauth.nyi.internal (Postfix) with ESMTP id 0648E211B7 for ; Mon, 17 Dec 2018 07:47:57 -0500 (EST) Received: from web3 ([10.202.2.213]) by compute7.internal (MEProxy); Mon, 17 Dec 2018 07:47:58 -0500 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtkedrudeivddggeehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfquhhtnecuuegrihhlohhuthemucef tddtnecunecujfgurhepkffhvfgggfgtofhfufgjffesthhqredtredtjeenucfhrhhomh eplfhulhhirghnucfhohgrugcuoehjuhhlihgrnhhfohgrugesrghprggthhgvrdhorhhg qeenucfrrghrrghmpehmrghilhhfrhhomhepjhhulhhirghnodhmvghsmhhtphgruhhthh hpvghrshhonhgrlhhithihqdekgeekkedtjedvtddqudeltddujeduvdekqdhjuhhlihgr nhhfohgrugeppegrphgrtghhvgdrohhrghesfhhorggurdhmvgdruhhknecuvehluhhsth gvrhfuihiivgeptd X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 99) id 7DC789E4E9; Mon, 17 Dec 2018 07:47:57 -0500 (EST) Message-Id: <1545050877.2924182.1611329368.04FFADAA@webmail.messagingengine.com> From: Julian Foad To: dev@subversion.apache.org MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-Mailer: MessagingEngine.com Webmail Interface - ajax-2f590f9a References: <20181217112645.A3F023A00A1@svn01-us-west.apache.org> <1545048681.3814743.1611311064.486C4874@webmail.messagingengine.com> <1545049685.3818859.1611322432.4CA7A7D4@webmail.messagingengine.com> <224e28f1-cb60-9215-4388-1a0d3966d022@apache.org> Subject: Re: svn commit: r1849080 - in /subversion/trunk/subversion: bindings/javahl/native/Path.cpp include/svn_dirent_uri.h libsvn_subr/dirent_uri.c svndumpfilter/svndumpfilter.c tests/libsvn_subr/dirent_uri-test.c In-Reply-To: <224e28f1-cb60-9215-4388-1a0d3966d022@apache.org> Date: Mon, 17 Dec 2018 12:47:57 +0000 Branko =C4=8Cibej wrote: > >>>> (svn_relpath__internal_style): Change prototype so that the functi= on can > >>>> return an error instead of aborting if anything goes wrong. > [...]=C2=A0 I'll rename the function at the same time. See IRC: I suggest a name like "svn_relpath__from_rel_dirent", and its use = in JavaHL appears to be erroneous or at the very least error-prone. --=20 - Julian