From dev-return-38739-archive-asf-public=cust-asf.ponee.io@subversion.apache.org Fri Dec 14 16:18:47 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id B6BE8180645 for ; Fri, 14 Dec 2018 16:18:46 +0100 (CET) Received: (qmail 90730 invoked by uid 500); 14 Dec 2018 15:18:45 -0000 Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@subversion.apache.org Received: (qmail 90720 invoked by uid 99); 14 Dec 2018 15:18:45 -0000 Received: from mail-relay.apache.org (HELO mailrelay1-lw-us.apache.org) (207.244.88.152) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 14 Dec 2018 15:18:45 +0000 Received: from auth2-smtp.messagingengine.com (auth2-smtp.messagingengine.com [66.111.4.228]) by mailrelay1-lw-us.apache.org (ASF Mail Server at mailrelay1-lw-us.apache.org) with ESMTPSA id 196AB1006 for ; Fri, 14 Dec 2018 15:18:45 +0000 (UTC) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailauth.nyi.internal (Postfix) with ESMTP id C54F7218C9 for ; Fri, 14 Dec 2018 10:18:44 -0500 (EST) Received: from web3 ([10.202.2.213]) by compute7.internal (MEProxy); Fri, 14 Dec 2018 10:18:44 -0500 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtkedrudehgedgjeehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfquhhtnecuuegrihhlohhuthemucef tddtnecunecujfgurhepkffhvfgggfgtofgjfhffufesthhqredtredtjeenucfhrhhomh eplfhulhhirghnucfhohgrugcuoehjuhhlihgrnhhfohgrugesrghprggthhgvrdhorhhg qeenucfrrghrrghmpehmrghilhhfrhhomhepjhhulhhirghnodhmvghsmhhtphgruhhthh hpvghrshhonhgrlhhithihqdekgeekkedtjedvtddqudeltddujeduvdekqdhjuhhlihgr nhhfohgrugeppegrphgrtghhvgdrohhrghesfhhorggurdhmvgdruhhknecuvehluhhsth gvrhfuihiivgeptd X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 99) id 6970C9E562; Fri, 14 Dec 2018 10:18:44 -0500 (EST) Message-Id: <1544800724.2286371.1609242384.37887FB2@webmail.messagingengine.com> From: Julian Foad To: dev@subversion.apache.org MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" X-Mailer: MessagingEngine.com Webmail Interface - ajax-2f590f9a In-Reply-To: References: <89de5509-04b7-2dc6-cfa4-7f55edf62282@apache.org> <1e53afe3-947a-a7a6-848c-1eae397fea68@gmail.com> <1544649829.433922.1607507080.5C9EC775@webmail.messagingengine.com> <1544713530.3935559.1608222856.3F4F26D0@webmail.messagingengine.com> <53e25894-e9ff-6b1b-def3-e9d0e348a868@collab.net> <6f32d532-f52e-5625-3efe-6ea284dd0525@apache.org> Date: Fri, 14 Dec 2018 15:18:44 +0000 Subject: Re: New canonicalization functions [was: Subversion Exception!] Branko =C4=8Cibej wrote: > r1848943, for review. [...] Woo hoo! Thanks, Brane. Are you willing to add random-input testing for them? Minor comments: * the 'relpath' one is not needed because, AFAIK, it's possible to canoni= calize any relpath and we already do; * the non-canonical 'result' and scratch pool params are probably over-ki= ll; a subjective judgment, I know, so just a suggestion. --=20 - Julian