subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Branko ─îibej <br...@apache.org>
Subject Re: New canonicalization functions [was: Subversion Exception!]
Date Sat, 15 Dec 2018 11:24:28 GMT
On 14.12.2018 19:05, Branko ─îibej wrote:
> On Fri, 14 Dec 2018, 18:14 Julian Foad <julianfoad@apache.org wrote:
>
>> Julian Foad wrote:
>>> Are you willing to add random-input testing for them?
>> The attached patch 'dirent-uri-test-random-2.patch' tests rules like:
>>
>>   * every result should pass an X_is_canonical() test (obvious by code
>> inspection);
>>   * every other input should produce SVN_ERR_CANONICALIZATION_FAILED;
>>   * when a path is "canonical", it should be unchanged by "canonicalize".
>>
>> Some findings:
>>
>>   * svn_uri_canonicalize_safe("") aborts;
>>   * svn_uri_canonicalize_safe("/foo") aborts;
>>
>
> We can fix this in the private "canonicalize()" function that all these
> eventually call. As before, I didn't have time to unknit the internal
> implementation.


I saw a funny thing in that function the other day ...

  if (SVN_PATH_IS_EMPTY(path))
    {
      assert(type != type_uri);
      return "";
    }


-- Brane


Mime
View raw message