subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Julian Foad <julianf...@apache.org>
Subject Re: New canonicalization functions [was: Subversion Exception!]
Date Fri, 14 Dec 2018 15:18:44 GMT
Branko ─îibej wrote:
> r1848943, for review. [...]

Woo hoo! Thanks, Brane.

Are you willing to add random-input testing for them?

Minor comments:
  * the 'relpath' one is not needed because, AFAIK, it's possible to canonicalize any relpath
and we already do;
  * the non-canonical 'result' and scratch pool params are probably over-kill; a subjective
judgment, I know, so just a suggestion.

-- 
- Julian

Mime
View raw message