subversion-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Nikita Slyusarev <ns...@yandex-team.com>
Subject Re: [PATCH] fix repos-to-wc copy dst parents creation
Date Sun, 14 Oct 2018 19:39:48 GMT
<div xmlns="http://www.w3.org/1999/xhtml"> </div><div xmlns="http://www.w3.org/1999/xhtml">14.10.2018,
17:17, "Branko Čibej" &lt;brane@apache.org&gt;:</div><blockquote xmlns="http://www.w3.org/1999/xhtml"
type="cite"><p>Hey. Thanks for the nudge.<br /><br />I have just one
comment: The two new test scenarios you should be split<br />into their own test cases.
Not only is it bad practice to make a test<br />case test more than one scenario, it
also defeats parallel test execution.</p></blockquote><div xmlns="http://www.w3.org/1999/xhtml"><div>Fixed
version (the patch is also attached):</div><div> </div><div>[[[</div><div>Correctly
handle existing parent directories when performing repos-to-wc copy.</div><div> </div><div>*
subversion/libsvn_client/copy.c</div><div>  (repos_to_wc_copy): If add_parents
flag is set and destination parent</div><div>  directory exists, but is unversioned,
put it under version control. Wc-to-wc</div><div>  copy behaves this way, and
so should repos-to-wc copy do.</div><div> </div><div>* subversion/tests/cmdline/copy_tests.py</div><div> 
(copy_make_parents_repo_wc_existing_unversioned_dst,</div><div>   copy_make_parents_wc_wc_existing_unversioned_dst):
Check behaviour with dst</div><div>  directory pre-creation for both repo-to-wc
and wc-to-wc test cases.</div><div>]]]</div></div><div xmlns="http://www.w3.org/1999/xhtml"> </div><div
xmlns="http://www.w3.org/1999/xhtml">-- </div><div xmlns="http://www.w3.org/1999/xhtml"><span
style="color:#ff0000;">N</span>ikita <span style="color:#ff0000;">S</span>lyusarev</div><div
xmlns="http://www.w3.org/1999/xhtml">Yandex</div><div xmlns="http://www.w3.org/1999/xhtml"> </div>
Mime
View raw message