Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm
Precedence: bulk
MIME-Version: 1.0
References: <20171106015822.C61AC3A028D@svn01-us-west.apache.org> <1509975202.257734.1163081224.387F1192@webmail.messagingengine.com>
In-Reply-To: <1509975202.257734.1163081224.387F1192@webmail.messagingengine.com>
From: Troy Curtis Jr <troycurtisjr@gmail.com>
Date: Tue, 07 Nov 2017 03:42:35 +0000
Message-ID: <CAEZNtZ+SGHcc5fL_7b31Z9JQorSeaJoLSahvqPbuKUaZTnVP3g@mail.gmail.com>
Subject: Re: svn commit: r1814386 - in /subversion/branches/swig-py3:
 build/generator/swig/ build/generator/util/ subversion/bindings/swig/python/svn/
 subversion/bindings/swig/python/tests/ subversion/bindings/swig/python/tests/trac/versioncontrol/
 subversion/bindi...
To: Daniel Shahaf <d.s@daniel.shahaf.name>
Cc: dev@subversion.apache.org, troycurtisjr@apache.org,
	commits@subversion.apache.org
Content-Type: multipart/alternative; boundary="94eb2c0924e23c6a9a055d5c5d92"
archived-at: Tue, 07 Nov 2017 03:42:50 -0000

--94eb2c0924e23c6a9a055d5c5d92
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Nov 6, 2017 at 7:33 AM Daniel Shahaf <d.s@daniel.shahaf.name> wrote=
:

> troycurtisjr@apache.org wrote on Mon, 06 Nov 2017 01:58 +0000:
> > +++
> subversion/branches/swig-py3/subversion/bindings/swig/python/tests/trac/v=
ersioncontrol/tests/svn_fs.py
> Mon Nov  6 01:58:20 2017
> > @@ -53,17 +53,19 @@ import shutil
> >  if sys.version_info[0] >=3D 3:
> =E2=8B=AE
> >  else:
> >    # Python <3.0
> >    try:
> > -    from cStringIO import StringIO
> > +    from io import StringIO
> >    except ImportError:
> > -    from StringIO import StringIO
> > +    from io import StringIO
>
> Is this intended to catch transient disk errors or something? :-)
>

Transient gray matter errors?  Looks like I missed an unnecessary 2to3
conversion. And since it happens to work in 2.7 now, I had no import
errors!  The whole block can be simplified a bit now that 2.7 is the
minimum version.


> > @@ -246,21 +249,21 @@ class SubversionRepositoryTestCase(unitt
> >          diffs =3D self.repos.get_deltas('trunk/README.txt', 2,
> 'trunk/README.txt', 3)
> >          self._cmp_diff((('trunk/README.txt', 2),
> >                          ('trunk/README.txt', 3),
> > -                        (Node.FILE, Changeset.EDIT)), diffs.next())
> > -        self.assertRaises(StopIteration, diffs.next)
> > +                        (Node.FILE, Changeset.EDIT)), next(diffs))
> > +        self.assertRaises(StopIteration, lambda *args: next(diffs))
>
> Should this be "lambda: next(diffs)" without variadicity?
>

I don't have a good explanation for this.  I distinctly remember having
syntax errors trying to do just that, and running across the '*args' method
in my search for the right syntax...however your syntax works perfectly
find in both my 2.7 and 3.6.  I also did not find the web reference for
'*args' again that I seem to remember.  More transient gray matter errors
perhaps!?  I'll get that fixed up as well.

Thanks for the review!
Troy

--94eb2c0924e23c6a9a055d5c5d92
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><br><br><div class=3D"gmail_quote"><div dir=3D"ltr">On Mon=
, Nov 6, 2017 at 7:33 AM Daniel Shahaf &lt;<a href=3D"mailto:d.s@daniel.sha=
haf.name">d.s@daniel.shahaf.name</a>&gt; wrote:<br></div><blockquote class=
=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padd=
ing-left:1ex"><a href=3D"mailto:troycurtisjr@apache.org" target=3D"_blank">=
troycurtisjr@apache.org</a> wrote on Mon, 06 Nov 2017 01:58 +0000:<br>
&gt; +++ subversion/branches/swig-py3/subversion/bindings/swig/python/tests=
/trac/versioncontrol/tests/svn_fs.py Mon Nov=C2=A0 6 01:58:20 2017<br>
&gt; @@ -53,17 +53,19 @@ import shutil<br>
&gt;=C2=A0 if sys.version_info[0] &gt;=3D 3:<br>
=E2=8B=AE<br>
&gt;=C2=A0 else:<br>
&gt;=C2=A0 =C2=A0 # Python &lt;3.0<br>
&gt;=C2=A0 =C2=A0 try:<br>
&gt; -=C2=A0 =C2=A0 from cStringIO import StringIO<br>
&gt; +=C2=A0 =C2=A0 from io import StringIO<br>
&gt;=C2=A0 =C2=A0 except ImportError:<br>
&gt; -=C2=A0 =C2=A0 from StringIO import StringIO<br>
&gt; +=C2=A0 =C2=A0 from io import StringIO<br>
<br>
Is this intended to catch transient disk errors or something? :-)<br></bloc=
kquote><div><br></div><div>Transient gray matter errors?=C2=A0 Looks like I=
 missed an unnecessary 2to3 conversion. And since it happens to work in 2.7=
 now, I had no import errors!=C2=A0 The whole block can be simplified a bit=
 now that 2.7 is the minimum version.<br></div><div>=C2=A0</div><blockquote=
 class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc soli=
d;padding-left:1ex">
&gt; @@ -246,21 +249,21 @@ class SubversionRepositoryTestCase(unitt<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 diffs =3D self.repos.get_deltas(&#39=
;trunk/README.txt&#39;, 2, &#39;trunk/README.txt&#39;, 3)<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 self._cmp_diff(((&#39;trunk/README.t=
xt&#39;, 2),<br>
&gt;=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =
=C2=A0 =C2=A0 =C2=A0 (&#39;trunk/README.txt&#39;, 3),<br>
&gt; -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=
 =C2=A0 =C2=A0 (Node.FILE, Changeset.EDIT)), diffs.next())<br>
&gt; -=C2=A0 =C2=A0 =C2=A0 =C2=A0 self.assertRaises(StopIteration, diffs.ne=
xt)<br>
&gt; +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0=
 =C2=A0 =C2=A0 (Node.FILE, Changeset.EDIT)), next(diffs))<br>
&gt; +=C2=A0 =C2=A0 =C2=A0 =C2=A0 self.assertRaises(StopIteration, lambda *=
args: next(diffs))<br>
<br>
Should this be &quot;lambda: next(diffs)&quot; without variadicity?<br>
</blockquote><div><br></div><div>I don&#39;t have a good explanation for th=
is.=C2=A0 I distinctly remember having syntax errors trying to do just that=
, and running across the &#39;*args&#39; method in my search for the right =
syntax...however your syntax works perfectly find in both my 2.7 and 3.6.=
=C2=A0 I also did not find the web reference for &#39;*args&#39; again that=
 I seem to remember.=C2=A0 More transient gray matter errors perhaps!?=C2=
=A0 I&#39;ll get that fixed up as well.<br><br></div><div>Thanks for the re=
view!<br></div><div>Troy<br></div><div>=C2=A0</div></div></div>

--94eb2c0924e23c6a9a055d5c5d92--