Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 4A797200CCF for ; Mon, 24 Jul 2017 18:24:04 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 488BA16553E; Mon, 24 Jul 2017 16:24:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 904031654FE for ; Mon, 24 Jul 2017 18:24:03 +0200 (CEST) Received: (qmail 21549 invoked by uid 500); 24 Jul 2017 16:23:57 -0000 Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@subversion.apache.org Received: (qmail 21539 invoked by uid 99); 24 Jul 2017 16:23:56 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 24 Jul 2017 16:23:56 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 76E9C180145 for ; Mon, 24 Jul 2017 16:23:56 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.699 X-Spam-Level: X-Spam-Status: No, score=-0.699 tagged_above=-999 required=6.31 tests=[RCVD_IN_DNSWL_LOW=-0.7, UNPARSEABLE_RELAY=0.001] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id SutOF4Ms3h9Z for ; Mon, 24 Jul 2017 16:23:54 +0000 (UTC) Received: from einhorn-mail.in-berlin.de (einhorn-mail.in-berlin.de [217.197.80.20]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTPS id 1A3B35FDBF for ; Mon, 24 Jul 2017 16:23:54 +0000 (UTC) X-Envelope-From: stsp@elego.de Received: from ted.stsp.name (ted.stsp.name [217.197.84.34]) by einhorn.in-berlin.de (8.14.4/8.14.4/Debian-8+deb8u2) with ESMTP id v6OGMAvc001296 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 24 Jul 2017 18:22:10 +0200 Received: from localhost (ted.stsp.name [local]) by ted.stsp.name (OpenSMTPD) with ESMTPA id 1cc48a95; Mon, 24 Jul 2017 18:22:10 +0200 (CEST) Date: Mon, 24 Jul 2017 18:22:10 +0200 From: Stefan Sperling To: Daniel Shahaf Cc: dev@subversion.apache.org Subject: Re: default mode of 'svn cleanup' changed Message-ID: <20170724162210.GE90677@ted.stsp.name> Mail-Followup-To: Daniel Shahaf , dev@subversion.apache.org References: <20170724120913.GB90677@ted.stsp.name> <1500910832.650285.1050829952.55F2721E@webmail.messagingengine.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1500910832.650285.1050829952.55F2721E@webmail.messagingengine.com> User-Agent: Mutt/1.8.0 (2017-02-23) archived-at: Mon, 24 Jul 2017 16:24:04 -0000 On Mon, Jul 24, 2017 at 03:40:32PM +0000, Daniel Shahaf wrote: > It seems the real fix would be figuring out a way for 'cleanup' not to > break all locks it sees. Actually, I missed that cleanup_internal() grabs a WC lock, so the entire point of my argument is moot. The other client manipulating WC state will error out if it runs any DB operation after 'cleanup' has stolen the lock. So I guess I'll just revert my commits :-)