Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm
Precedence: bulk
Message-Id: <1501075912.895255.1053200944.57B741E6@webmail.messagingengine.com>
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Evgeny Kotkov <evgeny.kotkov@visualsvn.com>
Cc: Subversion Development <dev@subversion.apache.org>,
 Stefan Sperling <stsp@elego.de>,
 Philip Martin <philip@codematters.co.uk>
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Type: multipart/mixed; boundary="_----------=_15010759128952550"
Date: Wed, 26 Jul 2017 13:31:52 +0000
In-Reply-To: <CAP_GPNiZym-+tkwEPMVda_o5zmGU2CiLmSAZ6M95WFRiMg4U0A@mail.gmail.com>
Subject: Re: svn commit: r1801940 - in /subversion/trunk: ./ notes/
 subversion/include/ subversion/include/private/ subversion/libsvn_delta/
 subversion/libsvn_fs_fs/ subversion/libsvn_subr/
 subversion/tests/libsvn_delta/ subversion/tests/libsvn_subr/
References: <20170714111350.B07063A0F99@svn01-us-west.apache.org>
 <87379j790z.fsf@codematters.co.uk> <87y3rb5t22.fsf@codematters.co.uk>
 <20170726115326.GW90677@ted.stsp.name>
 <CAP_GPNiZym-+tkwEPMVda_o5zmGU2CiLmSAZ6M95WFRiMg4U0A@mail.gmail.com>
archived-at: Wed, 26 Jul 2017 13:31:59 -0000

This is a multi-part message in MIME format.

--_----------=_15010759128952550
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"

Evgeny Kotkov wrote on Wed, 26 Jul 2017 15:48 +0300:
> And building using an embedded copy of the source isn't something new,
> as we already do that for utf8proc and with sqlite-amalgamation.

utf8proc is indeed a precedent, but sqlite is not.

- We support linking against an external sqlite lib too, not just
  against sqlite-amalgamation.  (On Unix, at least, which is what stsp
  and Philip discuss)

- sqlite-amalgamation is not _embedded_ in the source; it is retrieved
  by the user, so they can use an sqlite that was released after the
  subversion tarball they're building.

> Furthermore, we only require the core part of the LZ4 library =E2=80=94 t=
hat is, two
> relatively small files (lz4.c and lz4.h), which I think were specifically
> designed this way to simplify the process of using LZ4 in various
> applications.

This may be related to something I've been meaning to bring up: adding
lz4 has added five new warnings to the build (see attachment).  I meant
to bring them up and ask if they could please be addressed, but I wonder
if those warnings are related to your "designed to be importable" point.

Cheers,

Daniel

--_----------=_15010759128952550
Content-Disposition: attachment; filename="lz4-warnings.txt"
Content-Id: <1501075758.894289.d2030485eab7b931955d37f7bf2e70ee8231b7d9.68ADEEC1@content.messagingengine.com>
Content-Transfer-Encoding: base64
Content-Type: text/plain; name="lz4-warnings.txt"

JSBtYWtlIC1zIHN2bmFkbWluCnN1YnZlcnNpb24vbGlic3ZuX3N1YnIvbHo0
L2x6NC5jOjcwNzo1OiB3YXJuaW5nOiBubyBwcmV2aW91cyBwcm90b3R5cGUg
Zm9yIGZ1bmN0aW9uICdMWjRfY29tcHJlc3NfZmFzdF9mb3JjZScKICAgICAg
Wy1XbWlzc2luZy1wcm90b3R5cGVzXQppbnQgTFo0X2NvbXByZXNzX2Zhc3Rf
Zm9yY2UoY29uc3QgY2hhciogc291cmNlLCBjaGFyKiBkZXN0LCBpbnQgaW5w
dXRTaXouLi4KICAgIF4Kc3VidmVyc2lvbi9saWJzdm5fc3Vici9sejQvbHo0
LmM6MTAzNzo1OiB3YXJuaW5nOiBubyBwcmV2aW91cyBwcm90b3R5cGUgZm9y
IGZ1bmN0aW9uICdMWjRfY29tcHJlc3NfZm9yY2VFeHREaWN0JwogICAgICBb
LVdtaXNzaW5nLXByb3RvdHlwZXNdCmludCBMWjRfY29tcHJlc3NfZm9yY2VF
eHREaWN0IChMWjRfc3RyZWFtX3QqIExaNF9kaWN0LCBjb25zdCBjaGFyKiBz
b3VyYy4uLgogICAgXgpzdWJ2ZXJzaW9uL2xpYnN2bl9zdWJyL2x6NC9sejQu
YzoxMzk1OjU6IHdhcm5pbmc6IG5vIHByZXZpb3VzIHByb3RvdHlwZSBmb3Ig
ZnVuY3Rpb24gJ0xaNF9kZWNvbXByZXNzX3NhZmVfZm9yY2VFeHREaWN0Jwog
ICAgICBbLVdtaXNzaW5nLXByb3RvdHlwZXNdCmludCBMWjRfZGVjb21wcmVz
c19zYWZlX2ZvcmNlRXh0RGljdChjb25zdCBjaGFyKiBzb3VyY2UsIGNoYXIq
IGRlc3QsIGluLi4uCiAgICBeCnN1YnZlcnNpb24vbGlic3ZuX3N1YnIvbHo0
L2x6NC5jOjE0MTg6NTogd2FybmluZzogbm8gcHJldmlvdXMgcHJvdG90eXBl
IGZvciBmdW5jdGlvbiAnTFo0X3VuY29tcHJlc3MnIFstV21pc3NpbmctcHJv
dG90eXBlc10KaW50IExaNF91bmNvbXByZXNzIChjb25zdCBjaGFyKiBzb3Vy
Y2UsIGNoYXIqIGRlc3QsIGludCBvdXRwdXRTaXplKSB7IHJlLi4uCiAgICBe
CnN1YnZlcnNpb24vbGlic3ZuX3N1YnIvbHo0L2x6NC5jOjE0MTk6NTogd2Fy
bmluZzogbm8gcHJldmlvdXMgcHJvdG90eXBlIGZvciBmdW5jdGlvbiAnTFo0
X3VuY29tcHJlc3NfdW5rbm93bk91dHB1dFNpemUnCiAgICAgIFstV21pc3Np
bmctcHJvdG90eXBlc10KaW50IExaNF91bmNvbXByZXNzX3Vua25vd25PdXRw
dXRTaXplIChjb25zdCBjaGFyKiBzb3VyY2UsIGNoYXIqIGRlc3QsIGluLi4u
CiAgICBeCjUgd2FybmluZ3MgZ2VuZXJhdGVkLgoK

--_----------=_15010759128952550--