Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 4671A200C6A for ; Wed, 19 Apr 2017 21:14:26 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 44F67160B9C; Wed, 19 Apr 2017 19:14:26 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 83F1D160B94 for ; Wed, 19 Apr 2017 21:14:25 +0200 (CEST) Received: (qmail 80055 invoked by uid 500); 19 Apr 2017 19:14:24 -0000 Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@subversion.apache.org Received: (qmail 80041 invoked by uid 99); 19 Apr 2017 19:14:24 -0000 Received: from mail-relay.apache.org (HELO mail-relay.apache.org) (140.211.11.15) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 19 Apr 2017 19:14:24 +0000 Received: from [192.168.1.2] (unknown [81.174.159.228]) by mail-relay.apache.org (ASF Mail Server at mail-relay.apache.org) with ESMTPSA id 0BD151A00A6; Wed, 19 Apr 2017 19:14:23 +0000 (UTC) Subject: Re: API review for 1.10 -- svn_ra_list() To: Stefan Fuhrmann References: Cc: dev@subversion.apache.org From: Julian Foad Message-ID: <664815d0-63db-948c-15ed-17d523f919e4@apache.org> Date: Wed, 19 Apr 2017 20:14:22 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit archived-at: Wed, 19 Apr 2017 19:14:26 -0000 Stefan Fuhrmann wrote: > On 16.03.2017 16:32, Julian Foad wrote: >> In svn_ra.h around line 1132, two new-in-1.10 additions, with several >> issues with their doc strings. >> >> svn_ra_dirent_receiver_t: >> >> bad @a/@c references: svn_repos_list, path/rel_path, path_info_only >> >> svn_ra_list(): >> >> bad @a/@c references: root, authz_read_func, cancel_func, cancel_baton >> no reference for the 'dirent_fields' > > Thank for the review. > r1791771 should fix these. Thanks. That looks better. - Julian