Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 1F1A9200C11 for ; Sat, 4 Feb 2017 11:16:33 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 1DA3E160B63; Sat, 4 Feb 2017 10:16:33 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 67B9C160B56 for ; Sat, 4 Feb 2017 11:16:32 +0100 (CET) Received: (qmail 46924 invoked by uid 500); 4 Feb 2017 10:16:31 -0000 Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@subversion.apache.org Received: (qmail 46914 invoked by uid 99); 4 Feb 2017 10:16:31 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 04 Feb 2017 10:16:31 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id DDA1AC028C for ; Sat, 4 Feb 2017 10:16:30 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -0.699 X-Spam-Level: X-Spam-Status: No, score=-0.699 tagged_above=-999 required=6.31 tests=[RCVD_IN_DNSWL_LOW=-0.7, UNPARSEABLE_RELAY=0.001] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id 490l5rcqGh3L for ; Sat, 4 Feb 2017 10:16:29 +0000 (UTC) Received: from einhorn.in-berlin.de (einhorn.in-berlin.de [192.109.42.8]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTPS id D0DC65F340 for ; Sat, 4 Feb 2017 10:16:28 +0000 (UTC) X-Envelope-From: stsp@elego.de Received: from jim.stsp.name (jim.stsp.name [217.197.84.42]) (authenticated bits=0) by einhorn.in-berlin.de (8.14.4/8.14.4/Debian-8+deb8u1) with ESMTP id v14AGGNa021925 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 4 Feb 2017 11:16:16 +0100 Received: from localhost (jim.stsp.name [local]) by jim.stsp.name (OpenSMTPD) with ESMTPA id d10a7c04; Sat, 4 Feb 2017 11:16:15 +0100 (CET) Date: Sat, 4 Feb 2017 11:16:15 +0100 From: Stefan Sperling To: Stefan Kueng Cc: Subversion Development Subject: Re: wish for new API or extended one Message-ID: <20170204101615.n52atjsucsqlqpdg@jim.stsp.name> Mail-Followup-To: Stefan Kueng , Subversion Development References: <68b74702-0be0-c402-3fce-982713dc8676@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <68b74702-0be0-c402-3fce-982713dc8676@gmail.com> User-Agent: NeoMutt/20170128 (1.7.2) archived-at: Sat, 04 Feb 2017 10:16:33 -0000 On Sat, Feb 04, 2017 at 09:23:06AM +0100, Stefan Kueng wrote: > Hi, > > while trying out the new conflict resolver APIs I came upon a slight > problem. The API svn_client_conflict_option_get_description() returns a > string that can be used to show to the user as a choice - in TSVN that would > be the text on a two-line button (the 'label' is the first line, the > 'description' the second line). > > The problem I'm having now is that the description is always the same, even > if there are multiple 'moved-to-candidates' available. And if we use another > than the first moved-to-candidate, the description mentions the wrong path. So you're calling svn_client_conflict_option_set_moved_to_repos_relpath() and if you then get the description again the path isn't updated? That would be a bug.