Mailing-List: contact dev-help@subversion.apache.org; run by ezmlm
Precedence: bulk
Date: Thu, 19 Jan 2017 07:41:03 +0000
From: Daniel Shahaf <d.s@daniel.shahaf.name>
To: Brian Colavito <brian.colavito@gmail.com>
Cc: dev@subversion.apache.org
Subject: Re: Svndumpfilter crash on Windows 10
Message-ID: <20170119074103.GA26015@fujitsu.shahaf.local2>
References: <8846993B-ADA9-47D7-A3A4-D2B15F8E8D74@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <8846993B-ADA9-47D7-A3A4-D2B15F8E8D74@gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
archived-at: Thu, 19 Jan 2017 07:44:58 -0000

[users@->dev@]

Brian Colavito wrote on Wed, Jan 18, 2017 at 21:12:15 -0500:
> This was using the binary bundled with VisualSVN.  I got similar results using the one from TortoiseSVN.

Reproduction recipe:

[[[
% svnadmin create r 
% svnadmin delrevprop r -r0 svn:date 
% svnadmin dump r | svndumpfilter include / 
Including prefixes:
   '/'

SVN-fs-dump-format-version: 2

UUID: dfb98010-aee2-4f39-91c0-2fefa7ca3986

* Dumped revision 0.
zsh: done                svnadmin dump r | 
zsh: segmentation fault  svndumpfilter include /
]]]

The fix should be just a matter of not dereferencing 'propstring' in
svn_repos__dump_revision_record() in at the point
SVN_REPOS_DUMPFILE_CONTENT_LENGTH is printed.

However, I won't be investigating this further (no build environment).

Thanks for the report, Brian.

Cheers,

Daniel